[INFO] fetching crate arithmetic 2.1.2... [INFO] checking arithmetic-2.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate arithmetic 2.1.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate arithmetic 2.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate arithmetic 2.1.2 [INFO] finished tweaking crates.io crate arithmetic 2.1.2 [INFO] tweaked toml for crates.io crate arithmetic 2.1.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 109 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bitvec v0.20.4 (latest: v1.0.1) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding funty v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding proc-macro-crate v0.1.5 (latest: v3.2.0) [INFO] [stderr] Adding radium v0.6.2 (latest: v1.1.0) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wyz v0.2.0 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eca95b27704f3b5a1b6a863465c34485152b410ca70c7e2e10e20934fedae988 [INFO] running `Command { std: "docker" "start" "-a" "eca95b27704f3b5a1b6a863465c34485152b410ca70c7e2e10e20934fedae988", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eca95b27704f3b5a1b6a863465c34485152b410ca70c7e2e10e20934fedae988", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eca95b27704f3b5a1b6a863465c34485152b410ca70c7e2e10e20934fedae988", kill_on_drop: false }` [INFO] [stdout] eca95b27704f3b5a1b6a863465c34485152b410ca70c7e2e10e20934fedae988 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2369dbd77ac85497de474216787ee310cbae100d46b8ebb24ff8ded150233272 [INFO] running `Command { std: "docker" "start" "-a" "2369dbd77ac85497de474216787ee310cbae100d46b8ebb24ff8ded150233272", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling radium v0.6.2 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking byte-slice-cast v1.2.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking rustc-hex v2.1.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking integer-sqrt v0.1.5 [INFO] [stderr] Checking tetcore-std v2.1.2 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking uint-crate v0.9.1 [INFO] [stderr] Checking bitvec v0.20.4 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling debug-derive v2.1.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tetsy-fixed-hash v0.7.1 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling proc-macro-crate v0.1.5 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Compiling tetsy-scale-codec-derive v2.0.1 [INFO] [stderr] Checking tetsy-scale-codec v2.0.1 [INFO] [stderr] Checking tetsy-impl-codec v0.5.1 [INFO] [stderr] Checking arithmetic v2.1.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking tetsy-primitive-types v0.9.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:103:3 [INFO] [stdout] | [INFO] [stdout] 102 | fn unique_saturated_from(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | S::try_from(t).unwrap_or_else(|_| Bounded::max_value()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:109:3 [INFO] [stdout] | [INFO] [stdout] 108 | fn unique_saturated_into(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | self.try_into().unwrap_or_else(|_| Bounded::max_value()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:142:3 [INFO] [stdout] | [INFO] [stdout] 141 | fn saturating_mul(self, o: Self) -> Self { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | self.checked_mul(&o) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:154:3 [INFO] [stdout] | [INFO] [stdout] 152 | fn saturating_pow(self, exp: usize) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let neg = self < T::zero() && exp % 2 != 0; [INFO] [stdout] 154 | checked_pow(self, exp) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/per_things.rs:255:2 [INFO] [stdout] | [INFO] [stdout] 241 | fn saturating_reciprocal_mul(x: N, part: P::Inner, rounding: Rounding) -> N [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let maximum: N = P::ACCURACY.into(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | let c = rational_mul_correction::( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | (x / part.into()).saturating_mul(maximum).saturating_add(c) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/per_things.rs:274:2 [INFO] [stdout] | [INFO] [stdout] 259 | fn overflow_prune_mul(x: N, part: P::Inner, rounding: Rounding) -> N [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | let maximum: N = P::ACCURACY.into(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 267 | let part_n: N = part.into(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | let c = rational_mul_correction::( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | (x / maximum) * part_n + c [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arithmetic` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "2369dbd77ac85497de474216787ee310cbae100d46b8ebb24ff8ded150233272", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2369dbd77ac85497de474216787ee310cbae100d46b8ebb24ff8ded150233272", kill_on_drop: false }` [INFO] [stdout] 2369dbd77ac85497de474216787ee310cbae100d46b8ebb24ff8ded150233272