[INFO] fetching crate arimaa_engine_step 1.0.1... [INFO] checking arimaa_engine_step-1.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate arimaa_engine_step 1.0.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate arimaa_engine_step 1.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate arimaa_engine_step 1.0.1 [INFO] finished tweaking crates.io crate arimaa_engine_step 1.0.1 [INFO] tweaked toml for crates.io crate arimaa_engine_step 1.0.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 72 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 060eb4b76c96f3dc3aa1a4e8223bc51b56a6bf0827f31abaf81b651e7824ede3 [INFO] running `Command { std: "docker" "start" "-a" "060eb4b76c96f3dc3aa1a4e8223bc51b56a6bf0827f31abaf81b651e7824ede3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "060eb4b76c96f3dc3aa1a4e8223bc51b56a6bf0827f31abaf81b651e7824ede3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "060eb4b76c96f3dc3aa1a4e8223bc51b56a6bf0827f31abaf81b651e7824ede3", kill_on_drop: false }` [INFO] [stdout] 060eb4b76c96f3dc3aa1a4e8223bc51b56a6bf0827f31abaf81b651e7824ede3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 63f8919d2246796c27423d2ba3c78121b7013b37074ef079309a2940d41c5f87 [INFO] running `Command { std: "docker" "start" "-a" "63f8919d2246796c27423d2ba3c78121b7013b37074ef079309a2940d41c5f87", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking arimaa_engine_step v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `macros::*` [INFO] [stdout] --> src/lib.rs:236:9 [INFO] [stdout] | [INFO] [stdout] 236 | pub use macros::*; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 55 | let regex = regex::Regex::new(r"^\s*(\d+)([gswb])").unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let hash_history = List::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let hash_history = hash_history.append(hash); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | [INFO] [stdout] 109 | Ok(GameState::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 110 | | p1_turn_to_move, [INFO] [stdout] 111 | | move_number, [INFO] [stdout] 112 | | Phase::PlayPhase(PlayPhase::initial(hash, hash_history)), [INFO] [stdout] 113 | | piece_board, [INFO] [stdout] 114 | | hash, [INFO] [stdout] 115 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `finish` that must be used [INFO] [stdout] --> src/engine.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | state.finish(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 227 | let _ = state.finish(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:696:20 [INFO] [stdout] | [INFO] [stdout] 688 | let new_hash_history = if play_phase.piece_trapped_this_turn { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 693 | let new_hash_history = new_hash_history.append(hash); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 696 | phase: Phase::PlayPhase(PlayPhase::initial(hash, new_hash_history)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:752:20 [INFO] [stdout] | [INFO] [stdout] 726 | let new_hash_history = if new_animal_was_trapped { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 732 | let new_play_phase = if is_last_step { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 733 | let hash_history = new_hash_history.append(new_hash); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 752 | phase: Phase::PlayPhase(new_play_phase), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linked_list.rs:26:19 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn append(&self, elem: T) -> List { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | head: Some(Arc::new(Node { [INFO] [stdout] | ___________________^ [INFO] [stdout] 27 | | elem, [INFO] [stdout] 28 | | next: self.head.clone(), [INFO] [stdout] 29 | | len, [INFO] [stdout] 30 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arimaa_engine_step` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "63f8919d2246796c27423d2ba3c78121b7013b37074ef079309a2940d41c5f87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63f8919d2246796c27423d2ba3c78121b7013b37074ef079309a2940d41c5f87", kill_on_drop: false }` [INFO] [stdout] 63f8919d2246796c27423d2ba3c78121b7013b37074ef079309a2940d41c5f87