[INFO] fetching crate aria2-rs 0.2.1... [INFO] checking aria2-rs-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate aria2-rs 0.2.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate aria2-rs 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate aria2-rs 0.2.1 [INFO] finished tweaking crates.io crate aria2-rs 0.2.1 [INFO] tweaked toml for crates.io crate aria2-rs 0.2.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate aria2-rs 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bed93d950e75c67c3ad8d281c52835e4cf35d788bb096bf3c57a7fe58eb01e69 [INFO] running `Command { std: "docker" "start" "-a" "bed93d950e75c67c3ad8d281c52835e4cf35d788bb096bf3c57a7fe58eb01e69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bed93d950e75c67c3ad8d281c52835e4cf35d788bb096bf3c57a7fe58eb01e69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bed93d950e75c67c3ad8d281c52835e4cf35d788bb096bf3c57a7fe58eb01e69", kill_on_drop: false }` [INFO] [stdout] bed93d950e75c67c3ad8d281c52835e4cf35d788bb096bf3c57a7fe58eb01e69 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9096dbb5deef2a408747860e39d6280c6f2c1260ae4a43887f305ed6a622660f [INFO] running `Command { std: "docker" "start" "-a" "9096dbb5deef2a408747860e39d6280c6f2c1260ae4a43887f305ed6a622660f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking rustls-pki-types v1.1.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling rustls v0.22.2 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking unicode-bidi v0.3.14 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Checking webpki-roots v0.26.0 [INFO] [stderr] Checking http v1.0.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking uuid v1.6.1 [INFO] [stderr] Compiling ring v0.17.7 [INFO] [stderr] Compiling darling_core v0.20.3 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking rustls-webpki v0.102.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling darling_macro v0.20.3 [INFO] [stderr] Compiling darling v0.20.3 [INFO] [stderr] Compiling serde_with_macros v3.4.0 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking smallvec v1.12.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking smol_str v0.2.1 [INFO] [stderr] Checking serde_with v3.4.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking small-map v0.1.3 [INFO] [stderr] Checking aria2-rs v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/call.rs:392:9 [INFO] [stdout] | [INFO] [stdout] 388 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 392 | String::deserialize(deserializer).map(|s| if s == "OK" { OK::Ok } else { OK::Err(s) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/call.rs:428:12 [INFO] [stdout] | [INFO] [stdout] 423 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 427 | let inner = SmallVec::>::deserialize(deserializer)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 428 | Ok(MultiResponse(inner.into_iter().flatten().collect())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:76:86 [INFO] [stdout] | [INFO] [stdout] 70 | notification_cb: CB, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | ) -> Result { [INFO] [stdout] 72 | let (ws, _) = tokio_tungstenite::connect_async(&meta.url).await?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let (message_tx, message_rx) = mpsc::channel(channel_buffer_size); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let (shutdown_tx, _shutdown_rx) = oneshot::channel(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | tokio::spawn(async move { [INFO] [stdout] 76 | Self::background(ws, meta.url, message_rx, shutdown_tx, notification_cb).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:320:77 [INFO] [stdout] | [INFO] [stdout] 314 | let (shutdown_tx, shutdown_rx) = oneshot::channel(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | let raw_clone = raw.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 318 | let batch_clone = batch.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | tokio::spawn(async move { [INFO] [stdout] 320 | Self::background(raw_clone, batch_clone, interval, shutdown_tx).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aria2-rs` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/call.rs:392:9 [INFO] [stdout] | [INFO] [stdout] 388 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 392 | String::deserialize(deserializer).map(|s| if s == "OK" { OK::Ok } else { OK::Err(s) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/call.rs:428:12 [INFO] [stdout] | [INFO] [stdout] 423 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 427 | let inner = SmallVec::>::deserialize(deserializer)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 428 | Ok(MultiResponse(inner.into_iter().flatten().collect())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:76:86 [INFO] [stdout] | [INFO] [stdout] 70 | notification_cb: CB, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | ) -> Result { [INFO] [stdout] 72 | let (ws, _) = tokio_tungstenite::connect_async(&meta.url).await?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let (message_tx, message_rx) = mpsc::channel(channel_buffer_size); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let (shutdown_tx, _shutdown_rx) = oneshot::channel(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | tokio::spawn(async move { [INFO] [stdout] 76 | Self::background(ws, meta.url, message_rx, shutdown_tx, notification_cb).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:320:77 [INFO] [stdout] | [INFO] [stdout] 314 | let (shutdown_tx, shutdown_rx) = oneshot::channel(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | let raw_clone = raw.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 318 | let batch_clone = batch.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | tokio::spawn(async move { [INFO] [stdout] 320 | Self::background(raw_clone, batch_clone, interval, shutdown_tx).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aria2-rs` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "9096dbb5deef2a408747860e39d6280c6f2c1260ae4a43887f305ed6a622660f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9096dbb5deef2a408747860e39d6280c6f2c1260ae4a43887f305ed6a622660f", kill_on_drop: false }` [INFO] [stdout] 9096dbb5deef2a408747860e39d6280c6f2c1260ae4a43887f305ed6a622660f