[INFO] fetching crate arcs-ctf_yaml-parser 0.1.0... [INFO] checking arcs-ctf_yaml-parser-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate arcs-ctf_yaml-parser 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate arcs-ctf_yaml-parser 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate arcs-ctf_yaml-parser 0.1.0 [INFO] finished tweaking crates.io crate arcs-ctf_yaml-parser 0.1.0 [INFO] tweaked toml for crates.io crate arcs-ctf_yaml-parser 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate arcs-ctf_yaml-parser 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 71c1edfb37ec77ef826f0d809051497f98b35cbff7a86549912dced6113fe21e [INFO] running `Command { std: "docker" "start" "-a" "71c1edfb37ec77ef826f0d809051497f98b35cbff7a86549912dced6113fe21e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "71c1edfb37ec77ef826f0d809051497f98b35cbff7a86549912dced6113fe21e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "71c1edfb37ec77ef826f0d809051497f98b35cbff7a86549912dced6113fe21e", kill_on_drop: false }` [INFO] [stdout] 71c1edfb37ec77ef826f0d809051497f98b35cbff7a86549912dced6113fe21e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7b9fa43f00f4ff2934fbeb6205b0fff19b3d2165f9c6d6f3a8f592bae3cecadc [INFO] running `Command { std: "docker" "start" "-a" "7b9fa43f00f4ff2934fbeb6205b0fff19b3d2165f9c6d6f3a8f592bae3cecadc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling unicode-ident v1.0.8 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Checking unsafe-libyaml v0.2.10 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Checking once_cell v1.17.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking indexmap v2.2.3 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Checking regex v1.7.3 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Checking serde_yaml v0.9.32 [INFO] [stderr] Checking arcs-ctf_yaml-parser v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/flag/mod.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | if let Ok(path) = PathBuf::from_str(file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `let...else` pattern [INFO] [stdout] --> src/files/get_file.rs:35:17 [INFO] [stdout] | [INFO] [stdout] 35 | let Ok(value) = $final_map(value) else { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 113 | let path = get_req!( [INFO] [stdout] | ________________- [INFO] [stdout] 114 | | mapping.src else FilePathErr::NoExist; [INFO] [stdout] 115 | | as_str else FilePathErr::NotStr; [INFO] [stdout] 116 | | (PathBuf::from_str) else (|s| FilePathErr::BadPath(s.to_string())); [INFO] [stdout] 117 | | ); [INFO] [stdout] | |_____- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `else` clause is useless [INFO] [stdout] = help: consider removing the `else` clause [INFO] [stdout] = note: this warning originates in the macro `get_req` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `let...else` pattern [INFO] [stdout] --> src/deploy/mod.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | let Ok(path) = PathBuf::from_str(string) else { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `else` clause is useless [INFO] [stdout] = help: consider removing the `else` clause [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/flag/mod.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | if let Ok(path) = PathBuf::from_str(file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `let...else` pattern [INFO] [stdout] --> src/files/get_file.rs:35:17 [INFO] [stdout] | [INFO] [stdout] 35 | let Ok(value) = $final_map(value) else { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 113 | let path = get_req!( [INFO] [stdout] | ________________- [INFO] [stdout] 114 | | mapping.src else FilePathErr::NoExist; [INFO] [stdout] 115 | | as_str else FilePathErr::NotStr; [INFO] [stdout] 116 | | (PathBuf::from_str) else (|s| FilePathErr::BadPath(s.to_string())); [INFO] [stdout] 117 | | ); [INFO] [stdout] | |_____- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `else` clause is useless [INFO] [stdout] = help: consider removing the `else` clause [INFO] [stdout] = note: this warning originates in the macro `get_req` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `let...else` pattern [INFO] [stdout] --> src/deploy/mod.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | let Ok(path) = PathBuf::from_str(string) else { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `else` clause is useless [INFO] [stdout] = help: consider removing the `else` clause [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:252:21 [INFO] [stdout] | [INFO] [stdout] 252 | Err(_) => { [INFO] [stdout] | ^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] ... [INFO] [stdout] 263 | .filter_map(|path| set_err_if!( [INFO] [stdout] | ________________________________- [INFO] [stdout] 264 | | PathBuf::from_str(&path); [INFO] [stdout] 265 | | errors_encountered: println!("`{path}` is not a valid path!"); [INFO] [stdout] 266 | | )) [INFO] [stdout] | |_____________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] = note: this warning originates in the macro `set_err_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lists/structs.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 14 | fn from_iter<'a>(iter: impl Iterator) -> Result { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(Authors(iter.map(str::to_string).collect())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lists/structs.rs:68:18 [INFO] [stdout] | [INFO] [stdout] 67 | fn from_iter<'a>(iter: impl Iterator) -> Result { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Ok(Hints(iter.map(str::to_string).collect())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/accessors.rs:10:31 [INFO] [stdout] | [INFO] [stdout] 10 | super::verify_yaml(s, Some(correctness.clone()), base_path.unwrap_or(curr_path.as_path())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arcs-ctf_yaml-parser` (lib) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:252:21 [INFO] [stdout] | [INFO] [stdout] 252 | Err(_) => { [INFO] [stdout] | ^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] ... [INFO] [stdout] 263 | .filter_map(|path| set_err_if!( [INFO] [stdout] | ________________________________- [INFO] [stdout] 264 | | PathBuf::from_str(&path); [INFO] [stdout] 265 | | errors_encountered: println!("`{path}` is not a valid path!"); [INFO] [stdout] 266 | | )) [INFO] [stdout] | |_____________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] = note: this warning originates in the macro `set_err_if` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lists/structs.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 14 | fn from_iter<'a>(iter: impl Iterator) -> Result { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(Authors(iter.map(str::to_string).collect())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lists/structs.rs:68:18 [INFO] [stdout] | [INFO] [stdout] 67 | fn from_iter<'a>(iter: impl Iterator) -> Result { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Ok(Hints(iter.map(str::to_string).collect())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/accessors.rs:10:31 [INFO] [stdout] | [INFO] [stdout] 10 | super::verify_yaml(s, Some(correctness.clone()), base_path.unwrap_or(curr_path.as_path())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arcs-ctf_yaml-parser` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7b9fa43f00f4ff2934fbeb6205b0fff19b3d2165f9c6d6f3a8f592bae3cecadc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b9fa43f00f4ff2934fbeb6205b0fff19b3d2165f9c6d6f3a8f592bae3cecadc", kill_on_drop: false }` [INFO] [stdout] 7b9fa43f00f4ff2934fbeb6205b0fff19b3d2165f9c6d6f3a8f592bae3cecadc