[INFO] fetching crate archiv 0.1.3... [INFO] checking archiv-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate archiv 0.1.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate archiv 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate archiv 0.1.3 [INFO] finished tweaking crates.io crate archiv 0.1.3 [INFO] tweaked toml for crates.io crate archiv 0.1.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate archiv 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 01ccbf7cdb62698d444e9b5e14e3eff36badbeff99f81c46de7f3d59d5f54fcc [INFO] running `Command { std: "docker" "start" "-a" "01ccbf7cdb62698d444e9b5e14e3eff36badbeff99f81c46de7f3d59d5f54fcc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "01ccbf7cdb62698d444e9b5e14e3eff36badbeff99f81c46de7f3d59d5f54fcc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01ccbf7cdb62698d444e9b5e14e3eff36badbeff99f81c46de7f3d59d5f54fcc", kill_on_drop: false }` [INFO] [stdout] 01ccbf7cdb62698d444e9b5e14e3eff36badbeff99f81c46de7f3d59d5f54fcc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0bf420515ec028f9bd744007631f8d42b578edb2f87ca4f9dd4f0e30e5caf93e [INFO] running `Command { std: "docker" "start" "-a" "0bf420515ec028f9bd744007631f8d42b578edb2f87ca4f9dd4f0e30e5caf93e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling pkg-config v0.3.28 [INFO] [stderr] Compiling proc-macro2 v1.0.74 [INFO] [stderr] Compiling zstd-safe v7.0.0 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.46 [INFO] [stderr] Compiling jobserver v0.1.27 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling zstd-sys v2.0.9+zstd.1.5.5 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Checking zstd v0.13.0 [INFO] [stderr] Checking archiv v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `never` [INFO] [stdout] --> src/read.rs:204:7 [INFO] [stdout] | [INFO] [stdout] 204 | #[cfg(never)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(never)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(never)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `never` [INFO] [stdout] --> src/read.rs:204:7 [INFO] [stdout] | [INFO] [stdout] 204 | #[cfg(never)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(never)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(never)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:134:12 [INFO] [stdout] | [INFO] [stdout] 133 | let decoder = self.zstd.decode(take)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Ok(Some(Box::new(decoder))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn stream(&self, mut inner: R) -> Result> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | Ok(match kind { [INFO] [stdout] | ____________^ [INFO] [stdout] 160 | | Kinds::Plain => Box::new(ExpandStream { [INFO] [stdout] 161 | | inner, [INFO] [stdout] 162 | | max_item_size, [INFO] [stdout] ... | [INFO] [stdout] 169 | | }), [INFO] [stdout] 170 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn stream_compress(&self, inner: W) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let mut inner = self.zstd.encode(inner)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | inner.write_all(&header(Kinds::Plain))?; [INFO] [stdout] 130 | Ok(CompressStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 131 | | off: GLOBAL_MARKER_LEN, [INFO] [stdout] 132 | | inner, [INFO] [stdout] 133 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn item_compress(&self, mut inner: W) -> Result> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | inner.write_all(&header(Kinds::ItemCompressed))?; [INFO] [stdout] 138 | Ok(CompressItem { [INFO] [stdout] | ____________^ [INFO] [stdout] 139 | | off: GLOBAL_MARKER_LEN, [INFO] [stdout] 140 | | inner, [INFO] [stdout] 141 | | zstd: self.zstd.clone(), [INFO] [stdout] 142 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zbuild.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn encode<'e: 'd, W: Write>(&self, inner: W) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | EncoderDict::None(level) => zstd::Encoder::new(inner, *level)?, [INFO] [stdout] 24 | | EncoderDict::Dict(p) => zstd::Encoder::with_prepared_dictionary(inner, p)?, [INFO] [stdout] 25 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zbuild.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn decode(&self, inner: R) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | DecoderDict::None => zstd::Decoder::with_buffer(inner)?, [INFO] [stdout] 33 | | DecoderDict::Dict(p) => zstd::Decoder::with_prepared_dictionary(inner, p)?, [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `archiv` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:134:12 [INFO] [stdout] | [INFO] [stdout] 133 | let decoder = self.zstd.decode(take)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Ok(Some(Box::new(decoder))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn stream(&self, mut inner: R) -> Result> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | Ok(match kind { [INFO] [stdout] | ____________^ [INFO] [stdout] 160 | | Kinds::Plain => Box::new(ExpandStream { [INFO] [stdout] 161 | | inner, [INFO] [stdout] 162 | | max_item_size, [INFO] [stdout] ... | [INFO] [stdout] 169 | | }), [INFO] [stdout] 170 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn stream_compress(&self, inner: W) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let mut inner = self.zstd.encode(inner)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | inner.write_all(&header(Kinds::Plain))?; [INFO] [stdout] 130 | Ok(CompressStream { [INFO] [stdout] | ____________^ [INFO] [stdout] 131 | | off: GLOBAL_MARKER_LEN, [INFO] [stdout] 132 | | inner, [INFO] [stdout] 133 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn item_compress(&self, mut inner: W) -> Result> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | inner.write_all(&header(Kinds::ItemCompressed))?; [INFO] [stdout] 138 | Ok(CompressItem { [INFO] [stdout] | ____________^ [INFO] [stdout] 139 | | off: GLOBAL_MARKER_LEN, [INFO] [stdout] 140 | | inner, [INFO] [stdout] 141 | | zstd: self.zstd.clone(), [INFO] [stdout] 142 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zbuild.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn encode<'e: 'd, W: Write>(&self, inner: W) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | EncoderDict::None(level) => zstd::Encoder::new(inner, *level)?, [INFO] [stdout] 24 | | EncoderDict::Dict(p) => zstd::Encoder::with_prepared_dictionary(inner, p)?, [INFO] [stdout] 25 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zbuild.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn decode(&self, inner: R) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | DecoderDict::None => zstd::Decoder::with_buffer(inner)?, [INFO] [stdout] 33 | | DecoderDict::Dict(p) => zstd::Decoder::with_prepared_dictionary(inner, p)?, [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `archiv` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "0bf420515ec028f9bd744007631f8d42b578edb2f87ca4f9dd4f0e30e5caf93e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0bf420515ec028f9bd744007631f8d42b578edb2f87ca4f9dd4f0e30e5caf93e", kill_on_drop: false }` [INFO] [stdout] 0bf420515ec028f9bd744007631f8d42b578edb2f87ca4f9dd4f0e30e5caf93e