[INFO] fetching crate apub-ingest 0.2.0... [INFO] checking apub-ingest-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate apub-ingest 0.2.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate apub-ingest 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate apub-ingest 0.2.0 [INFO] finished tweaking crates.io crate apub-ingest 0.2.0 [INFO] tweaked toml for crates.io crate apub-ingest 0.2.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5237380f7af3cce788c0f63f8a21fad6ff3b2a39c902d2bfd851c1130de01ec5 [INFO] running `Command { std: "docker" "start" "-a" "5237380f7af3cce788c0f63f8a21fad6ff3b2a39c902d2bfd851c1130de01ec5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5237380f7af3cce788c0f63f8a21fad6ff3b2a39c902d2bfd851c1130de01ec5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5237380f7af3cce788c0f63f8a21fad6ff3b2a39c902d2bfd851c1130de01ec5", kill_on_drop: false }` [INFO] [stdout] 5237380f7af3cce788c0f63f8a21fad6ff3b2a39c902d2bfd851c1130de01ec5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac69f04905061f2b62c4fc88b028453c250b7b9f35d2c800fe418fe2fb3d897d [INFO] running `Command { std: "docker" "start" "-a" "ac69f04905061f2b62c4fc88b028453c250b7b9f35d2c800fe418fe2fb3d897d", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking apub-core v0.2.0 [INFO] [stderr] Checking apub-ingest v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 82 | actor_id: Self::ActorId, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | activity: &A, [INFO] [stdout] 84 | remote_repo: R, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | session: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | / { [INFO] [stdout] 90 | | let activity_actor = activity.actor_id(); [INFO] [stdout] 91 | | [INFO] [stdout] 92 | | let valid = match &authority { [INFO] [stdout] ... | [INFO] [stdout] 109 | | .await [INFO] [stdout] 110 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 136 | actor_id: Self::ActorId, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | activity: &A, [INFO] [stdout] 138 | remote_repo: R, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | session: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | / { [INFO] [stdout] 144 | | // delivered a public activity to a user inbox [INFO] [stdout] 145 | | if !actor_id.is_shared() && activity.is_public() { [INFO] [stdout] 146 | | return Err(I::Error::from(InboxError)); [INFO] [stdout] ... | [INFO] [stdout] 156 | | .await [INFO] [stdout] 157 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:188:5 [INFO] [stdout] | [INFO] [stdout] 181 | actor_id: Self::ActorId, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | activity: &A, [INFO] [stdout] 183 | remote_repo: R, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | session: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | / { [INFO] [stdout] 189 | | if activity.id().host() != activity.actor_id().host() [INFO] [stdout] 190 | | || activity.id().port() != activity.actor_id().port() [INFO] [stdout] 191 | | { [INFO] [stdout] ... | [INFO] [stdout] 197 | | .await [INFO] [stdout] 198 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `apub-ingest` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 82 | actor_id: Self::ActorId, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | activity: &A, [INFO] [stdout] 84 | remote_repo: R, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | session: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | / { [INFO] [stdout] 90 | | let activity_actor = activity.actor_id(); [INFO] [stdout] 91 | | [INFO] [stdout] 92 | | let valid = match &authority { [INFO] [stdout] ... | [INFO] [stdout] 109 | | .await [INFO] [stdout] 110 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 136 | actor_id: Self::ActorId, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | activity: &A, [INFO] [stdout] 138 | remote_repo: R, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | session: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | / { [INFO] [stdout] 144 | | // delivered a public activity to a user inbox [INFO] [stdout] 145 | | if !actor_id.is_shared() && activity.is_public() { [INFO] [stdout] 146 | | return Err(I::Error::from(InboxError)); [INFO] [stdout] ... | [INFO] [stdout] 156 | | .await [INFO] [stdout] 157 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:188:5 [INFO] [stdout] | [INFO] [stdout] 181 | actor_id: Self::ActorId, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | activity: &A, [INFO] [stdout] 183 | remote_repo: R, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | session: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | / { [INFO] [stdout] 189 | | if activity.id().host() != activity.actor_id().host() [INFO] [stdout] 190 | | || activity.id().port() != activity.actor_id().port() [INFO] [stdout] 191 | | { [INFO] [stdout] ... | [INFO] [stdout] 197 | | .await [INFO] [stdout] 198 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `apub-ingest` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "ac69f04905061f2b62c4fc88b028453c250b7b9f35d2c800fe418fe2fb3d897d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac69f04905061f2b62c4fc88b028453c250b7b9f35d2c800fe418fe2fb3d897d", kill_on_drop: false }` [INFO] [stdout] ac69f04905061f2b62c4fc88b028453c250b7b9f35d2c800fe418fe2fb3d897d