[INFO] fetching crate apr 0.1.10... [INFO] checking apr-0.1.10 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate apr 0.1.10 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate apr 0.1.10 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate apr 0.1.10 [INFO] finished tweaking crates.io crate apr 0.1.10 [INFO] tweaked toml for crates.io crate apr 0.1.10 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 61 packages to latest compatible versions [INFO] [stderr] Adding cfg-expr v0.15.8 (latest: v0.16.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding system-deps v6.2.2 (latest: v7.0.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ca16cec922e3fffb60b3237ed660dc07b7a8f0789942c37c008b7a85446eba1f [INFO] running `Command { std: "docker" "start" "-a" "ca16cec922e3fffb60b3237ed660dc07b7a8f0789942c37c008b7a85446eba1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ca16cec922e3fffb60b3237ed660dc07b7a8f0789942c37c008b7a85446eba1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca16cec922e3fffb60b3237ed660dc07b7a8f0789942c37c008b7a85446eba1f", kill_on_drop: false }` [INFO] [stdout] ca16cec922e3fffb60b3237ed660dc07b7a8f0789942c37c008b7a85446eba1f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 65ba9ca5e7cfc8fd90b83116f9c70c7141b6d6bae7dcf07dda517a15e2a2708f [INFO] running `Command { std: "docker" "start" "-a" "65ba9ca5e7cfc8fd90b83116f9c70c7141b6d6bae7dcf07dda517a15e2a2708f", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling winnow v0.6.18 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling libloading v0.8.5 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling bindgen v0.70.1 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling cfg-expr v0.15.8 [INFO] [stderr] Compiling version-compare v0.2.0 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling serde_spanned v0.6.7 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Compiling ctor v0.2.8 [INFO] [stderr] Compiling toml v0.8.19 [INFO] [stderr] Compiling system-deps v6.2.2 [INFO] [stderr] Compiling apr v0.1.10 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/getopt.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 60 | let name = std::ffi::CString::new(name).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let description = description.map(|s| std::ffi::CString::new(s).unwrap()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | / PooledPtr::initialize(|pool| unsafe { [INFO] [stdout] 65 | | let option = pool.calloc::(); [INFO] [stdout] 66 | | (*option).name = name.as_ptr() as *mut _; [INFO] [stdout] 67 | | (*option).has_arg = if has_arg { 1 } else { 0 }; [INFO] [stdout] ... | [INFO] [stdout] 73 | | }) [INFO] [stdout] 74 | | .unwrap(), [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/getopt.rs:61:47 [INFO] [stdout] | [INFO] [stdout] 61 | let description = description.map(|s| std::ffi::CString::new(s).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:167:12 [INFO] [stdout] | [INFO] [stdout] 163 | cb: impl FnOnce(&mut Pool) -> Result, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | ) -> Result { [INFO] [stdout] 165 | let mut pool = std::rc::Rc::new(Pool::new()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let data = cb(std::rc::Rc::get_mut(&mut pool).as_mut().unwrap())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | Ok(Pooled { pool, data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 224 | cb: impl FnOnce(&mut Pool) -> Result<*mut T, E>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | ) -> Result { [INFO] [stdout] 226 | let mut pool = std::rc::Rc::new(Pool::new()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let data = cb(std::rc::Rc::get_mut(&mut pool).as_mut().unwrap())?; [INFO] [stdout] 228 | Ok(PooledPtr { pool, data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `apr` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/getopt.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 60 | let name = std::ffi::CString::new(name).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let description = description.map(|s| std::ffi::CString::new(s).unwrap()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | / PooledPtr::initialize(|pool| unsafe { [INFO] [stdout] 65 | | let option = pool.calloc::(); [INFO] [stdout] 66 | | (*option).name = name.as_ptr() as *mut _; [INFO] [stdout] 67 | | (*option).has_arg = if has_arg { 1 } else { 0 }; [INFO] [stdout] ... | [INFO] [stdout] 73 | | }) [INFO] [stdout] 74 | | .unwrap(), [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/getopt.rs:61:47 [INFO] [stdout] | [INFO] [stdout] 61 | let description = description.map(|s| std::ffi::CString::new(s).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:167:12 [INFO] [stdout] | [INFO] [stdout] 163 | cb: impl FnOnce(&mut Pool) -> Result, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | ) -> Result { [INFO] [stdout] 165 | let mut pool = std::rc::Rc::new(Pool::new()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let data = cb(std::rc::Rc::get_mut(&mut pool).as_mut().unwrap())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | Ok(Pooled { pool, data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 224 | cb: impl FnOnce(&mut Pool) -> Result<*mut T, E>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | ) -> Result { [INFO] [stdout] 226 | let mut pool = std::rc::Rc::new(Pool::new()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let data = cb(std::rc::Rc::get_mut(&mut pool).as_mut().unwrap())?; [INFO] [stdout] 228 | Ok(PooledPtr { pool, data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `apr` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "65ba9ca5e7cfc8fd90b83116f9c70c7141b6d6bae7dcf07dda517a15e2a2708f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "65ba9ca5e7cfc8fd90b83116f9c70c7141b6d6bae7dcf07dda517a15e2a2708f", kill_on_drop: false }` [INFO] [stdout] 65ba9ca5e7cfc8fd90b83116f9c70c7141b6d6bae7dcf07dda517a15e2a2708f