[INFO] fetching crate appliance 0.2.4... [INFO] checking appliance-0.2.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate appliance 0.2.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate appliance 0.2.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate appliance 0.2.4 [INFO] finished tweaking crates.io crate appliance 0.2.4 [INFO] tweaked toml for crates.io crate appliance 0.2.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 119 packages to latest compatible versions [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding flume v0.10.14 (latest: v0.11.0) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 95de44f6a51bd47737c6614f30a7e84d992be2acde44c3d1618280f510514d7d [INFO] running `Command { std: "docker" "start" "-a" "95de44f6a51bd47737c6614f30a7e84d992be2acde44c3d1618280f510514d7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "95de44f6a51bd47737c6614f30a7e84d992be2acde44c3d1618280f510514d7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95de44f6a51bd47737c6614f30a7e84d992be2acde44c3d1618280f510514d7d", kill_on_drop: false }` [INFO] [stdout] 95de44f6a51bd47737c6614f30a7e84d992be2acde44c3d1618280f510514d7d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 03c434f6883376128aea4dcbacf66e5edd88789fbfc667e86729ca8151f4e39c [INFO] running `Command { std: "docker" "start" "-a" "03c434f6883376128aea4dcbacf66e5edd88789fbfc667e86729ca8151f4e39c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking appliance v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:36:42 [INFO] [stdout] | [INFO] [stdout] 36 | catch_unwind(|| block_on(DEFAULT_EXECUTOR.run(pending::<()>()))).ok(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:166:29 [INFO] [stdout] | [INFO] [stdout] 161 | fn new(message: M, reply_channel: Option>) -> Self [INFO] [stdout] | ---------- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | handle_message: Box::new(move |handler| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 167 | | if let Some(h) = handler { [INFO] [stdout] 168 | | let result = message.handle_by(h); [INFO] [stdout] 169 | | if let Some(rc) = reply_channel { [INFO] [stdout] ... | [INFO] [stdout] 175 | | Box::into_raw(bm) as *mut c_void [INFO] [stdout] 176 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:239:65 [INFO] [stdout] | [INFO] [stdout] 226 | let (in_, out_) = if let Some(mbs) = size.into() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | let mut appliance = Appliance { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | .spawn(async move { appliance.handle_messages(out_).await }) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:311:15 [INFO] [stdout] | [INFO] [stdout] 307 | pub fn send_sync(&self, message: M) -> Result<(), Error> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 311 | match self.inner.try_send(InnerMessage::new(message, None)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:338:42 [INFO] [stdout] | [INFO] [stdout] 335 | .map_err(|SendError(im)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 336 | let p = (im.handle_message)(None); [INFO] [stdout] 337 | let bm = unsafe { Box::from_raw(p as *mut M) }; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | Error::UnexpectedFailure(Some(*bm)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:381:59 [INFO] [stdout] | [INFO] [stdout] 381 | r.recv().map_err(|_| Error::UnexpectedFailure(None)) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:407:59 [INFO] [stdout] | [INFO] [stdout] 407 | .map_err(|_| Error::UnexpectedFailure(None)) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:417:55 [INFO] [stdout] | [INFO] [stdout] 417 | .map_err(|_| Error::UnexpectedFailure(None)) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `appliance` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "03c434f6883376128aea4dcbacf66e5edd88789fbfc667e86729ca8151f4e39c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03c434f6883376128aea4dcbacf66e5edd88789fbfc667e86729ca8151f4e39c", kill_on_drop: false }` [INFO] [stdout] 03c434f6883376128aea4dcbacf66e5edd88789fbfc667e86729ca8151f4e39c