[INFO] fetching crate apollo-at-link 0.0.1... [INFO] checking apollo-at-link-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate apollo-at-link 0.0.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate apollo-at-link 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate apollo-at-link 0.0.1 [INFO] finished tweaking crates.io crate apollo-at-link 0.0.1 [INFO] tweaked toml for crates.io crate apollo-at-link 0.0.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 102 packages to latest compatible versions [INFO] [stderr] Adding apollo-compiler v1.0.0-beta.3 (latest: v1.0.0-beta.20) [INFO] [stderr] Adding apollo-parser v0.7.7 (latest: v0.8.1) [INFO] [stderr] Adding ariadne v0.3.0 (latest: v0.4.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding env_logger v0.7.1 (latest: v0.11.5) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.45.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ae3aaa6d1b6a8969867461d12b67a88ce4485e7440daf687679125d7fdbd3bbe [INFO] running `Command { std: "docker" "start" "-a" "ae3aaa6d1b6a8969867461d12b67a88ce4485e7440daf687679125d7fdbd3bbe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ae3aaa6d1b6a8969867461d12b67a88ce4485e7440daf687679125d7fdbd3bbe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae3aaa6d1b6a8969867461d12b67a88ce4485e7440daf687679125d7fdbd3bbe", kill_on_drop: false }` [INFO] [stdout] ae3aaa6d1b6a8969867461d12b67a88ce4485e7440daf687679125d7fdbd3bbe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7e1a6a05d7763b216eeb8fae9f8bc7ef46588f602df75301ad4eab9d5dc31cd0 [INFO] running `Command { std: "docker" "start" "-a" "7e1a6a05d7763b216eeb8fae9f8bc7ef46588f602df75301ad4eab9d5dc31cd0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Checking concolor-query v0.3.3 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking rowan v0.15.16 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking concolor v0.1.1 [INFO] [stderr] Checking ariadne v0.3.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking apollo-parser v0.7.7 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking triomphe v0.1.13 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling salsa-macros v0.16.0 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking salsa v0.16.1 [INFO] [stderr] Checking apollo-compiler v1.0.0-beta.3 [INFO] [stderr] Checking apollo-at-link v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:98:8 [INFO] [stdout] | [INFO] [stdout] 31 | let mut links = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let mut by_identity = HashMap::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let mut by_name_in_schema = HashMap::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let mut types_by_imported_name = HashMap::new(); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let mut directives_by_imported_name = HashMap::new(); [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Ok(Some(LinksMetadata { [INFO] [stdout] | ________^ [INFO] [stdout] 99 | | links, [INFO] [stdout] 100 | | by_identity, [INFO] [stdout] 101 | | by_name_in_schema, [INFO] [stdout] 102 | | types_by_imported_name, [INFO] [stdout] 103 | | directives_by_imported_name, [INFO] [stdout] 104 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/link.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 227 | let mut imports = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | Ok(Link { [INFO] [stdout] | ____________^ [INFO] [stdout] 237 | | url, [INFO] [stdout] 238 | | spec_alias, [INFO] [stdout] 239 | | imports, [INFO] [stdout] 240 | | purpose, [INFO] [stdout] 241 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/link.rs:308:31 [INFO] [stdout] | [INFO] [stdout] 308 | link: Arc::clone(link), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/link.rs:309:33 [INFO] [stdout] | [INFO] [stdout] 309 | import: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/link.rs:339:27 [INFO] [stdout] | [INFO] [stdout] 339 | link: Arc::clone(link), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/link.rs:340:29 [INFO] [stdout] | [INFO] [stdout] 340 | import: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:98:8 [INFO] [stdout] | [INFO] [stdout] 31 | let mut links = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let mut by_identity = HashMap::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let mut by_name_in_schema = HashMap::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let mut types_by_imported_name = HashMap::new(); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let mut directives_by_imported_name = HashMap::new(); [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Ok(Some(LinksMetadata { [INFO] [stdout] | ________^ [INFO] [stdout] 99 | | links, [INFO] [stdout] 100 | | by_identity, [INFO] [stdout] 101 | | by_name_in_schema, [INFO] [stdout] 102 | | types_by_imported_name, [INFO] [stdout] 103 | | directives_by_imported_name, [INFO] [stdout] 104 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `apollo-at-link` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/link.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 227 | let mut imports = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | Ok(Link { [INFO] [stdout] | ____________^ [INFO] [stdout] 237 | | url, [INFO] [stdout] 238 | | spec_alias, [INFO] [stdout] 239 | | imports, [INFO] [stdout] 240 | | purpose, [INFO] [stdout] 241 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/link.rs:308:31 [INFO] [stdout] | [INFO] [stdout] 308 | link: Arc::clone(link), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/link.rs:309:33 [INFO] [stdout] | [INFO] [stdout] 309 | import: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/link.rs:339:27 [INFO] [stdout] | [INFO] [stdout] 339 | link: Arc::clone(link), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/link.rs:340:29 [INFO] [stdout] | [INFO] [stdout] 340 | import: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `apollo-at-link` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "7e1a6a05d7763b216eeb8fae9f8bc7ef46588f602df75301ad4eab9d5dc31cd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e1a6a05d7763b216eeb8fae9f8bc7ef46588f602df75301ad4eab9d5dc31cd0", kill_on_drop: false }` [INFO] [stdout] 7e1a6a05d7763b216eeb8fae9f8bc7ef46588f602df75301ad4eab9d5dc31cd0