[INFO] fetching crate aph_disjoint_set 0.1.1... [INFO] checking aph_disjoint_set-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate aph_disjoint_set 0.1.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate aph_disjoint_set 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate aph_disjoint_set 0.1.1 [INFO] finished tweaking crates.io crate aph_disjoint_set 0.1.1 [INFO] tweaked toml for crates.io crate aph_disjoint_set 0.1.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 12 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding rstest v0.17.0 (latest: v0.22.0) [INFO] [stderr] Adding rstest_macros v0.17.0 (latest: v0.22.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 42303509ce2046c22dfc0ab84f5505e6657df1a8716baf18efb69f35eb3e910c [INFO] running `Command { std: "docker" "start" "-a" "42303509ce2046c22dfc0ab84f5505e6657df1a8716baf18efb69f35eb3e910c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "42303509ce2046c22dfc0ab84f5505e6657df1a8716baf18efb69f35eb3e910c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42303509ce2046c22dfc0ab84f5505e6657df1a8716baf18efb69f35eb3e910c", kill_on_drop: false }` [INFO] [stdout] 42303509ce2046c22dfc0ab84f5505e6657df1a8716baf18efb69f35eb3e910c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b7e7c0469fdee9b3d1f7d257e15342385f2d8c8a20b148bc06db7d950a38dc11 [INFO] running `Command { std: "docker" "start" "-a" "b7e7c0469fdee9b3d1f7d257e15342385f2d8c8a20b148bc06db7d950a38dc11", kill_on_drop: false }` [INFO] [stderr] Checking aph_disjoint_set v0.1.1 (/opt/rustwide/workdir) [INFO] [stderr] Compiling rstest_macros v0.17.0 [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/disjoint_set_array.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 236 | $enm(s) => $ro_type(s), [INFO] [stdout] | ------- matches all the relevant values [INFO] [stdout] 237 | _ => unreachable!(), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] ... [INFO] [stdout] 285 | / impl_array_djs!( [INFO] [stdout] 286 | | DisjointSetArrayU8, [INFO] [stdout] 287 | | RoDisjointSetArrayU8, [INFO] [stdout] 288 | | common_strct!(ArrayStorage, Impossible, Impossible,Impossible), [INFO] [stdout] ... | [INFO] [stdout] 291 | | BitsEnum::U8 [INFO] [stdout] 292 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_array_djs` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/disjoint_set_array.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 236 | $enm(s) => $ro_type(s), [INFO] [stdout] | ------- matches all the relevant values [INFO] [stdout] 237 | _ => unreachable!(), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] ... [INFO] [stdout] 293 | / impl_array_djs!( [INFO] [stdout] 294 | | DisjointSetArrayU16, [INFO] [stdout] 295 | | RoDisjointSetArrayU16, [INFO] [stdout] 296 | | common_strct!(Impossible, ArrayStorage, Impossible,Impossible), [INFO] [stdout] ... | [INFO] [stdout] 299 | | BitsEnum::U16 [INFO] [stdout] 300 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_array_djs` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/disjoint_set_array.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 236 | $enm(s) => $ro_type(s), [INFO] [stdout] | ------- matches all the relevant values [INFO] [stdout] 237 | _ => unreachable!(), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] ... [INFO] [stdout] 302 | / impl_array_djs!( [INFO] [stdout] 303 | | DisjointSetArrayU32, [INFO] [stdout] 304 | | RoDisjointSetArrayU32, [INFO] [stdout] 305 | | common_strct!(Impossible,Impossible, ArrayStorage, Impossible), [INFO] [stdout] ... | [INFO] [stdout] 308 | | BitsEnum::U32 [INFO] [stdout] 309 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_array_djs` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/disjoint_set_array.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 236 | $enm(s) => $ro_type(s), [INFO] [stdout] | ------- matches all the relevant values [INFO] [stdout] 237 | _ => unreachable!(), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] ... [INFO] [stdout] 311 | / impl_array_djs!( [INFO] [stdout] 312 | | DisjointSetArrayU64, [INFO] [stdout] 313 | | RoDisjointSetArrayU64, [INFO] [stdout] 314 | | common_strct!(Impossible,Impossible,Impossible, ArrayStorage), [INFO] [stdout] ... | [INFO] [stdout] 317 | | BitsEnum::U64 [INFO] [stdout] 318 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_array_djs` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disjoint_set_dynamic.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 26 | let storage = choose_by_size!(cap, { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let s = DynamicStorage::with_capacity(cap); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Self(unsafe { [INFO] [stdout] | ______________^ [INFO] [stdout] 32 | | // SAFETY: Our storage is empty. [INFO] [stdout] 33 | | Common::new(storage, Splittability::Allowed, PathsStatus::Compressed) [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disjoint_set_dynamic.rs:188:14 [INFO] [stdout] | [INFO] [stdout] 186 | let storage = for_current_bitness!(src; src; src.make_copied()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | [INFO] [stdout] 188 | Self(unsafe { [INFO] [stdout] | ______________^ [INFO] [stdout] 189 | | // SAFETY: Because our storage contains same data as original, [INFO] [stdout] 190 | | // maybe with different capacity and bitness, [INFO] [stdout] 191 | | // its correctness and flags must not be changed. [INFO] [stdout] 192 | | Common::new(storage, is_splittable, is_compressed) [INFO] [stdout] 193 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disjoint_set_dynamic.rs:227:14 [INFO] [stdout] | [INFO] [stdout] 226 | fn from(value: DisjointSetDynamicRo) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | Self(unsafe { [INFO] [stdout] | ______________^ [INFO] [stdout] 228 | | // SAFETY: `DisjointSetDynamicRo` cannot have uncompressed storage. [INFO] [stdout] 229 | | Common::from_compressed_storage(value.0) [INFO] [stdout] 230 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disjoint_set_fixed.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 24 | let storage = choose_by_size!(size, { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let mut storage = BoxStorage::new(size); [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Self(unsafe { [INFO] [stdout] | ______________^ [INFO] [stdout] 30 | | // SAFETY: We just initialized storage to default state. [INFO] [stdout] 31 | | Common::new(storage, Splittability::Allowed, PathsStatus::Compressed) [INFO] [stdout] 32 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disjoint_set_fixed.rs:338:14 [INFO] [stdout] | [INFO] [stdout] 337 | fn from(value: DisjointSetRo) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | Self(unsafe { [INFO] [stdout] | ______________^ [INFO] [stdout] 339 | | // SAFETY: `DisjointSetRo` can contain only compressed storage. [INFO] [stdout] 340 | | Common::from_compressed_storage(value.0) [INFO] [stdout] 341 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aph_disjoint_set` (lib) due to 6 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b7e7c0469fdee9b3d1f7d257e15342385f2d8c8a20b148bc06db7d950a38dc11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7e7c0469fdee9b3d1f7d257e15342385f2d8c8a20b148bc06db7d950a38dc11", kill_on_drop: false }` [INFO] [stdout] b7e7c0469fdee9b3d1f7d257e15342385f2d8c8a20b148bc06db7d950a38dc11