[INFO] fetching crate aper-websocket-client 0.3.0... [INFO] checking aper-websocket-client-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate aper-websocket-client 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate aper-websocket-client 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate aper-websocket-client 0.3.0 [INFO] finished tweaking crates.io crate aper-websocket-client 0.3.0 [INFO] tweaked toml for crates.io crate aper-websocket-client 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 61 packages to latest compatible versions [INFO] [stderr] Adding bitmaps v2.1.0 (latest: v3.2.1) [INFO] [stderr] Adding sized-chunks v0.6.5 (latest: v0.7.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5c7c081ba0749e0a5cc5c5e8cf2f82768d5121076e6a7334257bd48b8c742feb [INFO] running `Command { std: "docker" "start" "-a" "5c7c081ba0749e0a5cc5c5e8cf2f82768d5121076e6a7334257bd48b8c742feb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5c7c081ba0749e0a5cc5c5e8cf2f82768d5121076e6a7334257bd48b8c742feb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c7c081ba0749e0a5cc5c5e8cf2f82768d5121076e6a7334257bd48b8c742feb", kill_on_drop: false }` [INFO] [stdout] 5c7c081ba0749e0a5cc5c5e8cf2f82768d5121076e6a7334257bd48b8c742feb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 533b8430589fb5f7a12877d3348e99fe53014b3aa2754351d3eb965383f29301 [INFO] running `Command { std: "docker" "start" "-a" "533b8430589fb5f7a12877d3348e99fe53014b3aa2754351d3eb965383f29301", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling inflections v1.1.1 [INFO] [stderr] Compiling im-rc v15.1.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking fractional_index v2.0.1 [INFO] [stderr] Checking stateroom v0.4.4 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking web-sys v0.3.70 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Compiling aper_derive v0.3.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Checking sized-chunks v0.6.5 [INFO] [stderr] Checking aper v0.3.0 [INFO] [stderr] Checking aper-stateroom v0.3.0 [INFO] [stderr] Checking aper-websocket-client v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn new(url: &str, callback: F) -> Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let state_client: Rc>> = Rc::default(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let callback: BoxedCallback = Rc::new(Box::new(callback)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | let conn = Rc::new_cyclic(|conn: &Weak>| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(AperWebSocketStateProgramClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 68 | | conn, [INFO] [stdout] 69 | | state_client, [INFO] [stdout] 70 | | callback, [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 49 | let callback = callback.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let typed_callback: Box)> = { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let state_client = state_client.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let conn = conn.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | TypedWebsocketConnection::new(url, typed_callback).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/typed.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(url: &str, callback: F) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let f: Box = Box::new(move |m: Message| match m { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let conn = WebSocketConnection::new(url, f)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | [INFO] [stdout] 34 | Ok(TypedWebsocketConnection { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | conn, [INFO] [stdout] 36 | | _ph_f: PhantomData::default(), [INFO] [stdout] 37 | | _ph_inbound: PhantomData::default(), [INFO] [stdout] 38 | | _ph_outbound: PhantomData::default(), [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(url: &str, callback: F) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let ws = [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let message_handler = Closure::::wrap(Box::new(move |e: MessageEvent| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(WebSocketConnection { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | socket: ws, [INFO] [stdout] 50 | | _message_handler: message_handler, [INFO] [stdout] 51 | | _ph: PhantomData::default(), [INFO] [stdout] 52 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aper-websocket-client` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn new(url: &str, callback: F) -> Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let state_client: Rc>> = Rc::default(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let callback: BoxedCallback = Rc::new(Box::new(callback)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | let conn = Rc::new_cyclic(|conn: &Weak>| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(AperWebSocketStateProgramClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 68 | | conn, [INFO] [stdout] 69 | | state_client, [INFO] [stdout] 70 | | callback, [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 49 | let callback = callback.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let typed_callback: Box)> = { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let state_client = state_client.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let conn = conn.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | TypedWebsocketConnection::new(url, typed_callback).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/typed.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(url: &str, callback: F) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let f: Box = Box::new(move |m: Message| match m { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let conn = WebSocketConnection::new(url, f)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | [INFO] [stdout] 34 | Ok(TypedWebsocketConnection { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | conn, [INFO] [stdout] 36 | | _ph_f: PhantomData::default(), [INFO] [stdout] 37 | | _ph_inbound: PhantomData::default(), [INFO] [stdout] 38 | | _ph_outbound: PhantomData::default(), [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(url: &str, callback: F) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let ws = [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let message_handler = Closure::::wrap(Box::new(move |e: MessageEvent| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(WebSocketConnection { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | socket: ws, [INFO] [stdout] 50 | | _message_handler: message_handler, [INFO] [stdout] 51 | | _ph: PhantomData::default(), [INFO] [stdout] 52 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aper-websocket-client` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "533b8430589fb5f7a12877d3348e99fe53014b3aa2754351d3eb965383f29301", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "533b8430589fb5f7a12877d3348e99fe53014b3aa2754351d3eb965383f29301", kill_on_drop: false }` [INFO] [stdout] 533b8430589fb5f7a12877d3348e99fe53014b3aa2754351d3eb965383f29301