[INFO] fetching crate aocli 0.0.9... [INFO] checking aocli-0.0.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate aocli 0.0.9 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate aocli 0.0.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate aocli 0.0.9 [INFO] finished tweaking crates.io crate aocli 0.0.9 [INFO] tweaked toml for crates.io crate aocli 0.0.9 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate aocli 0.0.9 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3f507f4155da2a8ee24e9d6d138f383df4a4b043662aa48a4c478d2b97368137 [INFO] running `Command { std: "docker" "start" "-a" "3f507f4155da2a8ee24e9d6d138f383df4a4b043662aa48a4c478d2b97368137", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3f507f4155da2a8ee24e9d6d138f383df4a4b043662aa48a4c478d2b97368137", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f507f4155da2a8ee24e9d6d138f383df4a4b043662aa48a4c478d2b97368137", kill_on_drop: false }` [INFO] [stdout] 3f507f4155da2a8ee24e9d6d138f383df4a4b043662aa48a4c478d2b97368137 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f3fca27211cd285bdf1ec6fd7214bf6ecf62e983ee4c38ecd78cbe0f1012915f [INFO] running `Command { std: "docker" "start" "-a" "f3fca27211cd285bdf1ec6fd7214bf6ecf62e983ee4c38ecd78cbe0f1012915f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling rustix v0.38.26 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling rustls v0.21.9 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking winnow v0.5.19 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking webpki-roots v0.25.3 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Checking home v0.5.5 [INFO] [stderr] Checking colored v2.0.4 [INFO] [stderr] Compiling ring v0.17.6 [INFO] [stderr] Checking webbrowser v0.8.12 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking serde_spanned v0.6.4 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking toml_edit v0.21.0 [INFO] [stderr] Checking ureq v2.9.1 [INFO] [stderr] Checking toml v0.8.8 [INFO] [stderr] Checking aocli v0.0.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `with_context` and `with_usage` are never used [INFO] [stdout] --> src/error.rs:118:8 [INFO] [stdout] | [INFO] [stdout] 116 | pub trait Context> { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] 117 | fn context(self, context: C) -> Result; [INFO] [stdout] 118 | fn with_context C>(self, context: F) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 119 | fn usage(self, usage: U) -> Result; [INFO] [stdout] 120 | fn with_usage U>(self, usage: F) -> Result; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:126:22 [INFO] [stdout] | [INFO] [stdout] 125 | fn context(self, context: C) -> Result { [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | self.map_err(|e| e.into().context(context)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:130:22 [INFO] [stdout] | [INFO] [stdout] 129 | fn with_context C>(self, context: F) -> Result { [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | self.map_err(|e| e.into().with_context(context)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:134:22 [INFO] [stdout] | [INFO] [stdout] 133 | fn usage(self, usage: U) -> Result { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | self.map_err(|e| e.into().usage(usage)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:138:22 [INFO] [stdout] | [INFO] [stdout] 137 | fn with_usage U>(self, usage: F) -> Result { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | self.map_err(|e| e.into().with_usage(usage)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:142:22 [INFO] [stdout] | [INFO] [stdout] 141 | fn usages(self, usages: impl IntoIterator) -> Result { [INFO] [stdout] | ---- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | self.map_err(|e| e.into().usages(usages)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aocli` (bin "aoc") due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: methods `with_context` and `with_usage` are never used [INFO] [stdout] --> src/error.rs:118:8 [INFO] [stdout] | [INFO] [stdout] 116 | pub trait Context> { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] 117 | fn context(self, context: C) -> Result; [INFO] [stdout] 118 | fn with_context C>(self, context: F) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 119 | fn usage(self, usage: U) -> Result; [INFO] [stdout] 120 | fn with_usage U>(self, usage: F) -> Result; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:126:22 [INFO] [stdout] | [INFO] [stdout] 125 | fn context(self, context: C) -> Result { [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | self.map_err(|e| e.into().context(context)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:130:22 [INFO] [stdout] | [INFO] [stdout] 129 | fn with_context C>(self, context: F) -> Result { [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | self.map_err(|e| e.into().with_context(context)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:134:22 [INFO] [stdout] | [INFO] [stdout] 133 | fn usage(self, usage: U) -> Result { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | self.map_err(|e| e.into().usage(usage)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:138:22 [INFO] [stdout] | [INFO] [stdout] 137 | fn with_usage U>(self, usage: F) -> Result { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | self.map_err(|e| e.into().with_usage(usage)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:142:22 [INFO] [stdout] | [INFO] [stdout] 141 | fn usages(self, usages: impl IntoIterator) -> Result { [INFO] [stdout] | ---- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | self.map_err(|e| e.into().usages(usages)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aocli` (bin "aoc" test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f3fca27211cd285bdf1ec6fd7214bf6ecf62e983ee4c38ecd78cbe0f1012915f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3fca27211cd285bdf1ec6fd7214bf6ecf62e983ee4c38ecd78cbe0f1012915f", kill_on_drop: false }` [INFO] [stdout] f3fca27211cd285bdf1ec6fd7214bf6ecf62e983ee4c38ecd78cbe0f1012915f