[INFO] fetching crate aoa 0.1.0... [INFO] checking aoa-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate aoa 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate aoa 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate aoa 0.1.0 [INFO] finished tweaking crates.io crate aoa 0.1.0 [INFO] tweaked toml for crates.io crate aoa 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate aoa 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ae185074a8420ce8287226933d343d667935531ba4de2a3f586f5d9ae8fe170b [INFO] running `Command { std: "docker" "start" "-a" "ae185074a8420ce8287226933d343d667935531ba4de2a3f586f5d9ae8fe170b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ae185074a8420ce8287226933d343d667935531ba4de2a3f586f5d9ae8fe170b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae185074a8420ce8287226933d343d667935531ba4de2a3f586f5d9ae8fe170b", kill_on_drop: false }` [INFO] [stdout] ae185074a8420ce8287226933d343d667935531ba4de2a3f586f5d9ae8fe170b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 16d762139c60de1b295a16b9e9302edac6eec3ab61a7ffe5db2b55d8bd8b9cea [INFO] running `Command { std: "docker" "start" "-a" "16d762139c60de1b295a16b9e9302edac6eec3ab61a7ffe5db2b55d8bd8b9cea", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling adler32 v1.2.0 [INFO] [stderr] Compiling libflate_lz77 v1.0.0 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling rle-decode-fast v1.0.1 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling cc v1.0.66 [INFO] [stderr] Compiling syn v1.0.54 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling libflate v1.0.3 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling filetime v0.2.13 [INFO] [stderr] Compiling xattr v0.2.2 [INFO] [stderr] Compiling tar v0.4.30 [INFO] [stderr] Compiling libusb1-sys v0.4.3 [INFO] [stderr] Checking rusb v0.6.5 [INFO] [stderr] Compiling thiserror-impl v1.0.22 [INFO] [stderr] Checking thiserror v1.0.22 [INFO] [stderr] Checking aoa v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:154:12 [INFO] [stdout] | [INFO] [stdout] 147 | manufacturer: T, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | model: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | description: T, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | version: T, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | uri: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | serial: T, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | ) -> Result { [INFO] [stdout] 154 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 155 | | manufacturer: CString::new(manufacturer)?, [INFO] [stdout] 156 | | model: CString::new(model)?, [INFO] [stdout] 157 | | description: CString::new(description)?, [INFO] [stdout] ... | [INFO] [stdout] 160 | | serial: CString::new(serial)?, [INFO] [stdout] 161 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:154:12 [INFO] [stdout] | [INFO] [stdout] 147 | manufacturer: T, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | model: T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | description: T, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | version: T, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | uri: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | serial: T, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | ) -> Result { [INFO] [stdout] 154 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 155 | | manufacturer: CString::new(manufacturer)?, [INFO] [stdout] 156 | | model: CString::new(model)?, [INFO] [stdout] 157 | | description: CString::new(description)?, [INFO] [stdout] ... | [INFO] [stdout] 160 | | serial: CString::new(serial)?, [INFO] [stdout] 161 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aoa` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:340:32 [INFO] [stdout] | [INFO] [stdout] 340 | Err(err) => panic!(err), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 340 | Err(err) => panic!("{}", err), [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 340 | Err(err) => std::panic::panic_any(err), [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aoa` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "16d762139c60de1b295a16b9e9302edac6eec3ab61a7ffe5db2b55d8bd8b9cea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16d762139c60de1b295a16b9e9302edac6eec3ab61a7ffe5db2b55d8bd8b9cea", kill_on_drop: false }` [INFO] [stdout] 16d762139c60de1b295a16b9e9302edac6eec3ab61a7ffe5db2b55d8bd8b9cea