[INFO] fetching crate anyways 0.3.0... [INFO] checking anyways-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate anyways 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate anyways 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate anyways 0.3.0 [INFO] finished tweaking crates.io crate anyways 0.3.0 [INFO] tweaked toml for crates.io crate anyways 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding owo-colors v3.5.0 (latest: v4.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d50ddb2467edd33589f17f95583660240e4cec3991ccc38d6ff07cb99108a51a [INFO] running `Command { std: "docker" "start" "-a" "d50ddb2467edd33589f17f95583660240e4cec3991ccc38d6ff07cb99108a51a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d50ddb2467edd33589f17f95583660240e4cec3991ccc38d6ff07cb99108a51a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d50ddb2467edd33589f17f95583660240e4cec3991ccc38d6ff07cb99108a51a", kill_on_drop: false }` [INFO] [stdout] d50ddb2467edd33589f17f95583660240e4cec3991ccc38d6ff07cb99108a51a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3924679e6175c6fd418a6dfeb2669ca483a29d8d5cb9c2394a02e90ef61f477f [INFO] running `Command { std: "docker" "start" "-a" "3924679e6175c6fd418a6dfeb2669ca483a29d8d5cb9c2394a02e90ef61f477f", kill_on_drop: false }` [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking anyways v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Style` [INFO] [stdout] --> src/lib.rs:14:18 [INFO] [stdout] | [INFO] [stdout] 14 | use owo_colors::{Style}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Style` [INFO] [stdout] --> src/lib.rs:14:18 [INFO] [stdout] | [INFO] [stdout] 14 | use owo_colors::{Style}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/lib.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/formatter.rs:3:27 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fmt::{Formatter, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/formatter.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | let mut fill = " ".repeat(max_width.saturating_sub(get_length(&line))); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/formatter.rs:3:27 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fmt::{Formatter, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/formatter.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | let mut fill = " ".repeat(max_width.saturating_sub(get_length(&line))); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audit.rs:163:20 [INFO] [stdout] | [INFO] [stdout] 161 | fn from(err: E) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | AuditError { [INFO] [stdout] 163 | error: err.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 5 | fn wrap_err>(self, err: E) -> crate::Result { [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | self.wrap(|audit| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 7 | | let mut e = err.into(); [INFO] [stdout] 8 | | e.location = get_caller(3); [INFO] [stdout] 9 | | audit.push_err(e); [INFO] [stdout] 10 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 13 | fn wrap_err_with>(self, err: impl FnOnce() -> E) -> crate::Result { [INFO] [stdout] | ---- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | self.wrap(|audit| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 15 | | let mut e = err().into(); [INFO] [stdout] 16 | | e.location = get_caller(3); [INFO] [stdout] 17 | | audit.push_err(e); [INFO] [stdout] 18 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 27 | fn wrap_section_with(self, section: impl FnOnce() -> AuditSection) -> crate::Result { [INFO] [stdout] | ---- -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | self.wrap(|audit| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 29 | | audit.push_section(section()); [INFO] [stdout] 30 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `anyways` (lib) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audit.rs:163:20 [INFO] [stdout] | [INFO] [stdout] 161 | fn from(err: E) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | AuditError { [INFO] [stdout] 163 | error: err.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 5 | fn wrap_err>(self, err: E) -> crate::Result { [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | self.wrap(|audit| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 7 | | let mut e = err.into(); [INFO] [stdout] 8 | | e.location = get_caller(3); [INFO] [stdout] 9 | | audit.push_err(e); [INFO] [stdout] 10 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 13 | fn wrap_err_with>(self, err: impl FnOnce() -> E) -> crate::Result { [INFO] [stdout] | ---- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | self.wrap(|audit| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 15 | | let mut e = err().into(); [INFO] [stdout] 16 | | e.location = get_caller(3); [INFO] [stdout] 17 | | audit.push_err(e); [INFO] [stdout] 18 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 27 | fn wrap_section_with(self, section: impl FnOnce() -> AuditSection) -> crate::Result { [INFO] [stdout] | ---- -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | self.wrap(|audit| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 29 | | audit.push_section(section()); [INFO] [stdout] 30 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `anyways` (lib test) due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3924679e6175c6fd418a6dfeb2669ca483a29d8d5cb9c2394a02e90ef61f477f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3924679e6175c6fd418a6dfeb2669ca483a29d8d5cb9c2394a02e90ef61f477f", kill_on_drop: false }` [INFO] [stdout] 3924679e6175c6fd418a6dfeb2669ca483a29d8d5cb9c2394a02e90ef61f477f