[INFO] fetching crate android-intent 0.2.1... [INFO] checking android-intent-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate android-intent 0.2.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate android-intent 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate android-intent 0.2.1 [INFO] finished tweaking crates.io crate android-intent 0.2.1 [INFO] tweaked toml for crates.io crate android-intent 0.2.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding jni v0.20.0 (latest: v0.21.1) [INFO] [stderr] Adding jni-sys v0.3.0 (latest: v0.4.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 228d349c3f278405e23865b1bf04b89fb790b04f94642e30686f624fe8dd786b [INFO] running `Command { std: "docker" "start" "-a" "228d349c3f278405e23865b1bf04b89fb790b04f94642e30686f624fe8dd786b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "228d349c3f278405e23865b1bf04b89fb790b04f94642e30686f624fe8dd786b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "228d349c3f278405e23865b1bf04b89fb790b04f94642e30686f624fe8dd786b", kill_on_drop: false }` [INFO] [stdout] 228d349c3f278405e23865b1bf04b89fb790b04f94642e30686f624fe8dd786b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bf96cea49c39e5d59136e1e39459162e17e88677bf37575c8b6ea8653dff03d3 [INFO] running `Command { std: "docker" "start" "-a" "bf96cea49c39e5d59136e1e39459162e17e88677bf37575c8b6ea8653dff03d3", kill_on_drop: false }` [INFO] [stderr] Checking cesu8 v1.1.0 [INFO] [stderr] Checking jni-sys v0.3.0 [INFO] [stderr] Checking ndk-context v0.1.1 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Compiling jni v0.20.0 [INFO] [stderr] Checking android-intent v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intent.rs:47:23 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new_with_uri(env: JNIEnv<'env>, action: impl AsRef, uri: impl AsRef) -> Self { [INFO] [stdout] | ----------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Self::from_fn(|| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 48 | | let url_string = env.new_string(uri)?; [INFO] [stdout] 49 | | let uri_class = env.find_class("android/net/Uri")?; [INFO] [stdout] 50 | | let uri = env.call_static_method( [INFO] [stdout] ... | [INFO] [stdout] 70 | | }) [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intent.rs:84:23 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn with_extra(self, key: impl AsRef, value: impl AsRef) -> Self { [INFO] [stdout] | ---- -------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | self.and_then(|inner| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 85 | | let key = inner.env.new_string(key)?; [INFO] [stdout] 86 | | let value = inner.env.new_string(value)?; [INFO] [stdout] ... | [INFO] [stdout] 95 | | Ok(inner) [INFO] [stdout] 96 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intent.rs:112:23 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn into_chooser_with_title(self, title: Option>) -> Self { [INFO] [stdout] | ---- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | self.and_then(|mut inner| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 113 | | let title_value = if let Some(title) = title { [INFO] [stdout] 114 | | let s = inner.env.new_string(title)?; [INFO] [stdout] 115 | | s.into() [INFO] [stdout] ... | [INFO] [stdout] 129 | | Ok(inner) [INFO] [stdout] 130 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intent.rs:143:23 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn with_type(self, type_name: impl AsRef) -> Self { [INFO] [stdout] | ---- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | self.and_then(|inner| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 144 | | let jstring = inner.env.new_string(type_name)?; [INFO] [stdout] 145 | | [INFO] [stdout] 146 | | inner.env.call_method( [INFO] [stdout] ... | [INFO] [stdout] 153 | | Ok(inner) [INFO] [stdout] 154 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `android-intent` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intent.rs:47:23 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new_with_uri(env: JNIEnv<'env>, action: impl AsRef, uri: impl AsRef) -> Self { [INFO] [stdout] | ----------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Self::from_fn(|| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 48 | | let url_string = env.new_string(uri)?; [INFO] [stdout] 49 | | let uri_class = env.find_class("android/net/Uri")?; [INFO] [stdout] 50 | | let uri = env.call_static_method( [INFO] [stdout] ... | [INFO] [stdout] 70 | | }) [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intent.rs:84:23 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn with_extra(self, key: impl AsRef, value: impl AsRef) -> Self { [INFO] [stdout] | ---- -------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | self.and_then(|inner| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 85 | | let key = inner.env.new_string(key)?; [INFO] [stdout] 86 | | let value = inner.env.new_string(value)?; [INFO] [stdout] ... | [INFO] [stdout] 95 | | Ok(inner) [INFO] [stdout] 96 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intent.rs:112:23 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn into_chooser_with_title(self, title: Option>) -> Self { [INFO] [stdout] | ---- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | self.and_then(|mut inner| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 113 | | let title_value = if let Some(title) = title { [INFO] [stdout] 114 | | let s = inner.env.new_string(title)?; [INFO] [stdout] 115 | | s.into() [INFO] [stdout] ... | [INFO] [stdout] 129 | | Ok(inner) [INFO] [stdout] 130 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/intent.rs:143:23 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn with_type(self, type_name: impl AsRef) -> Self { [INFO] [stdout] | ---- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | self.and_then(|inner| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 144 | | let jstring = inner.env.new_string(type_name)?; [INFO] [stdout] 145 | | [INFO] [stdout] 146 | | inner.env.call_method( [INFO] [stdout] ... | [INFO] [stdout] 153 | | Ok(inner) [INFO] [stdout] 154 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `android-intent` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "bf96cea49c39e5d59136e1e39459162e17e88677bf37575c8b6ea8653dff03d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf96cea49c39e5d59136e1e39459162e17e88677bf37575c8b6ea8653dff03d3", kill_on_drop: false }` [INFO] [stdout] bf96cea49c39e5d59136e1e39459162e17e88677bf37575c8b6ea8653dff03d3