[INFO] fetching crate analyzeme 12.0.0... [INFO] checking analyzeme-12.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate analyzeme 12.0.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate analyzeme 12.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate analyzeme 12.0.0 [INFO] finished tweaking crates.io crate analyzeme 12.0.0 [INFO] tweaked toml for crates.io crate analyzeme 12.0.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 42 packages to latest compatible versions [INFO] [stderr] Adding decodeme v10.1.3 (latest: v12.0.0) [INFO] [stderr] Adding measureme v10.1.3 (latest: v12.0.0) [INFO] [stderr] Adding memmap2 v0.2.3 (latest: v0.9.4) [INFO] [stderr] Adding perf-event-open-sys v3.0.0 (latest: v4.0.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f062e8028f4ae809741d85ea4bbe9819012c1f60b98a8e0d2bcd40f2766f62a3 [INFO] running `Command { std: "docker" "start" "-a" "f062e8028f4ae809741d85ea4bbe9819012c1f60b98a8e0d2bcd40f2766f62a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f062e8028f4ae809741d85ea4bbe9819012c1f60b98a8e0d2bcd40f2766f62a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f062e8028f4ae809741d85ea4bbe9819012c1f60b98a8e0d2bcd40f2766f62a3", kill_on_drop: false }` [INFO] [stdout] f062e8028f4ae809741d85ea4bbe9819012c1f60b98a8e0d2bcd40f2766f62a3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 091bfcadcd177e2b4cdafa19705e0f1125076b6d3ce17b963fd626139c633c51 [INFO] running `Command { std: "docker" "start" "-a" "091bfcadcd177e2b4cdafa19705e0f1125076b6d3ce17b963fd626139c633c51", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking memmap2 v0.2.3 [INFO] [stderr] Checking perf-event-open-sys v3.0.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking measureme v12.0.0 [INFO] [stderr] Checking measureme v10.1.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking decodeme v10.1.3 [INFO] [stderr] Checking decodeme v12.0.0 [INFO] [stderr] Checking analyzeme v12.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analysis.rs:274:25 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn perform_analysis(self) -> AnalysisResults { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | query_data: query_data.drain().map(|(_, value)| value).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profiling_data.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 62 | let event_decoder: Box = match file_format_version { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(ProfilingData { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | event_decoder, [INFO] [stdout] 90 | | metadata: OnceCell::new(), [INFO] [stdout] 91 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profiling_data.rs:301:28 [INFO] [stdout] | [INFO] [stdout] 286 | pub fn into_profiling_data(self) -> ProfilingData { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 301 | event_decoder: Box::new( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 302 | | file_formats::current::EventDecoder::from_separate_buffers( [INFO] [stdout] 303 | | string_data, [INFO] [stdout] 304 | | index_data, [INFO] [stdout] ... | [INFO] [stdout] 308 | | .unwrap(), [INFO] [stdout] 309 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing_common.rs:75:32 [INFO] [stdout] | [INFO] [stdout] 72 | let profiler = profiler.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | std::thread::spawn(move || { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 76 | | let mut expected_events = Vec::new(); [INFO] [stdout] 77 | | [INFO] [stdout] 78 | | for i in 0..num_stacks { [INFO] [stdout] ... | [INFO] [stdout] 92 | | expected_events [INFO] [stdout] 93 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing_common.rs:108:23 [INFO] [stdout] | [INFO] [stdout] 108 | .flat_map(|t| t.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `analyzeme` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analysis.rs:274:25 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn perform_analysis(self) -> AnalysisResults { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | query_data: query_data.drain().map(|(_, value)| value).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profiling_data.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 62 | let event_decoder: Box = match file_format_version { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(ProfilingData { [INFO] [stdout] | ____________^ [INFO] [stdout] 89 | | event_decoder, [INFO] [stdout] 90 | | metadata: OnceCell::new(), [INFO] [stdout] 91 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profiling_data.rs:301:28 [INFO] [stdout] | [INFO] [stdout] 286 | pub fn into_profiling_data(self) -> ProfilingData { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 301 | event_decoder: Box::new( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 302 | | file_formats::current::EventDecoder::from_separate_buffers( [INFO] [stdout] 303 | | string_data, [INFO] [stdout] 304 | | index_data, [INFO] [stdout] ... | [INFO] [stdout] 308 | | .unwrap(), [INFO] [stdout] 309 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing_common.rs:75:32 [INFO] [stdout] | [INFO] [stdout] 72 | let profiler = profiler.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | std::thread::spawn(move || { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 76 | | let mut expected_events = Vec::new(); [INFO] [stdout] 77 | | [INFO] [stdout] 78 | | for i in 0..num_stacks { [INFO] [stdout] ... | [INFO] [stdout] 92 | | expected_events [INFO] [stdout] 93 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing_common.rs:108:23 [INFO] [stdout] | [INFO] [stdout] 108 | .flat_map(|t| t.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `analyzeme` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "091bfcadcd177e2b4cdafa19705e0f1125076b6d3ce17b963fd626139c633c51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "091bfcadcd177e2b4cdafa19705e0f1125076b6d3ce17b963fd626139c633c51", kill_on_drop: false }` [INFO] [stdout] 091bfcadcd177e2b4cdafa19705e0f1125076b6d3ce17b963fd626139c633c51