[INFO] fetching crate analyst 0.1.0... [INFO] checking analyst-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate analyst 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate analyst 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate analyst 0.1.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate analyst 0.1.0 [INFO] tweaked toml for crates.io crate analyst 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate analyst 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de4b0095fc11a0c3c65f8fa9d1aad289c58da113f9c00609ea7e785d9fd9f0ae [INFO] running `Command { std: "docker" "start" "-a" "de4b0095fc11a0c3c65f8fa9d1aad289c58da113f9c00609ea7e785d9fd9f0ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de4b0095fc11a0c3c65f8fa9d1aad289c58da113f9c00609ea7e785d9fd9f0ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de4b0095fc11a0c3c65f8fa9d1aad289c58da113f9c00609ea7e785d9fd9f0ae", kill_on_drop: false }` [INFO] [stdout] de4b0095fc11a0c3c65f8fa9d1aad289c58da113f9c00609ea7e785d9fd9f0ae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aba3012a19547aa2f437834069d12371f701237ab9c8338795b958cce1c15f90 [INFO] running `Command { std: "docker" "start" "-a" "aba3012a19547aa2f437834069d12371f701237ab9c8338795b958cce1c15f90", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling serde v1.0.207 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling assert_cmd v2.0.16 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking prettytable v0.10.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking predicates v3.1.2 [INFO] [stderr] Checking clap v4.5.15 [INFO] [stderr] Checking analyst v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let mut reader = csv::Reader::from_reader(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let headers = reader.headers()?.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let current_record = StringRecord::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 21 | | reader, [INFO] [stdout] 22 | | headers, [INFO] [stdout] 23 | | current_record, [INFO] [stdout] 24 | | _marker: std::marker::PhantomData, [INFO] [stdout] 25 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `analyst` (lib test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let mut reader = csv::Reader::from_reader(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let headers = reader.headers()?.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let current_record = StringRecord::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 21 | | reader, [INFO] [stdout] 22 | | headers, [INFO] [stdout] 23 | | current_record, [INFO] [stdout] 24 | | _marker: std::marker::PhantomData, [INFO] [stdout] 25 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `analyst` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "aba3012a19547aa2f437834069d12371f701237ab9c8338795b958cce1c15f90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aba3012a19547aa2f437834069d12371f701237ab9c8338795b958cce1c15f90", kill_on_drop: false }` [INFO] [stdout] aba3012a19547aa2f437834069d12371f701237ab9c8338795b958cce1c15f90