[INFO] fetching crate ambience 0.2.1... [INFO] checking ambience-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ambience 0.2.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate ambience 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ambience 0.2.1 [INFO] finished tweaking crates.io crate ambience 0.2.1 [INFO] tweaked toml for crates.io crate ambience 0.2.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f4bd09a0103d87ac549dd792e4be21f61b8653ccef927cfa6cf111d945304398 [INFO] running `Command { std: "docker" "start" "-a" "f4bd09a0103d87ac549dd792e4be21f61b8653ccef927cfa6cf111d945304398", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f4bd09a0103d87ac549dd792e4be21f61b8653ccef927cfa6cf111d945304398", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4bd09a0103d87ac549dd792e4be21f61b8653ccef927cfa6cf111d945304398", kill_on_drop: false }` [INFO] [stdout] f4bd09a0103d87ac549dd792e4be21f61b8653ccef927cfa6cf111d945304398 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c8c688a3f9d591049dfb2a79eed81d2f056b168cc0a83980e4adf92faad29866 [INFO] running `Command { std: "docker" "start" "-a" "c8c688a3f9d591049dfb2a79eed81d2f056b168cc0a83980e4adf92faad29866", kill_on_drop: false }` [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking ambience v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:112:36 [INFO] [stdout] | [INFO] [stdout] 112 | THREAD_LOCALS.with(|frame_opt| frame_opt.borrow().has::()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:130:24 [INFO] [stdout] | [INFO] [stdout] 129 | pub fn set(new_val: T) -> AmbientGuard { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | THREAD_LOCALS.with(|frame_opt| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 131 | | let mut storage = frame_opt.borrow_mut(); [INFO] [stdout] 132 | | storage.push(Rc::new(new_val)) [INFO] [stdout] 133 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:132:22 [INFO] [stdout] | [INFO] [stdout] 129 | pub fn set(new_val: T) -> AmbientGuard { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | THREAD_LOCALS.with(|frame_opt| { [INFO] [stdout] 131 | let mut storage = frame_opt.borrow_mut(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | storage.push(Rc::new(new_val)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:139:24 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn set_rc(new_val: Rc) -> AmbientGuard { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | THREAD_LOCALS.with(|frame_opt| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 140 | | let mut storage = frame_opt.borrow_mut(); [INFO] [stdout] 141 | | storage.push(new_val) [INFO] [stdout] 142 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ambience` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:112:36 [INFO] [stdout] | [INFO] [stdout] 112 | THREAD_LOCALS.with(|frame_opt| frame_opt.borrow().has::()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:130:24 [INFO] [stdout] | [INFO] [stdout] 129 | pub fn set(new_val: T) -> AmbientGuard { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | THREAD_LOCALS.with(|frame_opt| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 131 | | let mut storage = frame_opt.borrow_mut(); [INFO] [stdout] 132 | | storage.push(Rc::new(new_val)) [INFO] [stdout] 133 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:132:22 [INFO] [stdout] | [INFO] [stdout] 129 | pub fn set(new_val: T) -> AmbientGuard { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | THREAD_LOCALS.with(|frame_opt| { [INFO] [stdout] 131 | let mut storage = frame_opt.borrow_mut(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | storage.push(Rc::new(new_val)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread.rs:139:24 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn set_rc(new_val: Rc) -> AmbientGuard { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | THREAD_LOCALS.with(|frame_opt| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 140 | | let mut storage = frame_opt.borrow_mut(); [INFO] [stdout] 141 | | storage.push(new_val) [INFO] [stdout] 142 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ambience` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "c8c688a3f9d591049dfb2a79eed81d2f056b168cc0a83980e4adf92faad29866", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c8c688a3f9d591049dfb2a79eed81d2f056b168cc0a83980e4adf92faad29866", kill_on_drop: false }` [INFO] [stdout] c8c688a3f9d591049dfb2a79eed81d2f056b168cc0a83980e4adf92faad29866