[INFO] fetching crate alto_logger 0.4.0... [INFO] checking alto_logger-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate alto_logger 0.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate alto_logger 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate alto_logger 0.4.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate alto_logger 0.4.0 [INFO] tweaked toml for crates.io crate alto_logger 0.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate alto_logger 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0f0eb6fa962a6de417cc2ebea658d065343507f99257f9d8ba44eb8fed64d2a1 [INFO] running `Command { std: "docker" "start" "-a" "0f0eb6fa962a6de417cc2ebea658d065343507f99257f9d8ba44eb8fed64d2a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0f0eb6fa962a6de417cc2ebea658d065343507f99257f9d8ba44eb8fed64d2a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f0eb6fa962a6de417cc2ebea658d065343507f99257f9d8ba44eb8fed64d2a1", kill_on_drop: false }` [INFO] [stdout] 0f0eb6fa962a6de417cc2ebea658d065343507f99257f9d8ba44eb8fed64d2a1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f31388cdc708693add0519a1ea1e4b5e4d5c6c36a5cce9245201e237d00936ea [INFO] running `Command { std: "docker" "start" "-a" "f31388cdc708693add0519a1ea1e4b5e4d5c6c36a5cce9245201e237d00936ea", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Compiling time-macros v0.2.4 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking alto_logger v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:61:27 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn init(logger: impl log::Log + 'static) -> Result<(), Error> { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | log::set_boxed_logger(Box::new(logger)).map_err(Error::SetLogger) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loggers/file.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 18 | options: impl Into, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | / std::fs::OpenOptions::new() [INFO] [stdout] 25 | | .create(true) [INFO] [stdout] 26 | | .write(true) [INFO] [stdout] 27 | | .open(path) [INFO] [stdout] ... | [INFO] [stdout] 31 | | this [INFO] [stdout] 32 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loggers/file.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 38 | options: impl Into, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | / std::fs::OpenOptions::new() [INFO] [stdout] 45 | | .create(true) [INFO] [stdout] 46 | | .append(true) [INFO] [stdout] 47 | | .write(true) [INFO] [stdout] ... | [INFO] [stdout] 52 | | this [INFO] [stdout] 53 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loggers/file.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 63 | options: impl Into, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | / std::fs::OpenOptions::new() [INFO] [stdout] 105 | | .create_new(true) [INFO] [stdout] 106 | | .write(true) [INFO] [stdout] 107 | | .open(&path) [INFO] [stdout] ... | [INFO] [stdout] 111 | | this [INFO] [stdout] 112 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loggers/file.rs:69:38 [INFO] [stdout] | [INFO] [stdout] 68 | fn io_err(reason: impl Into>) -> crate::Error { [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | crate::Error::FileLogger(std::io::Error::new(std::io::ErrorKind::Other, reason)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loggers/file.rs:134:20 [INFO] [stdout] | [INFO] [stdout] 129 | pub fn new(options: impl Into, writer: W) -> Self { [INFO] [stdout] | --------------------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | write: Mutex::new(writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `alto_logger` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f31388cdc708693add0519a1ea1e4b5e4d5c6c36a5cce9245201e237d00936ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f31388cdc708693add0519a1ea1e4b5e4d5c6c36a5cce9245201e237d00936ea", kill_on_drop: false }` [INFO] [stdout] f31388cdc708693add0519a1ea1e4b5e4d5c6c36a5cce9245201e237d00936ea