[INFO] fetching crate alternate 0.0.0... [INFO] checking alternate-0.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate alternate 0.0.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate alternate 0.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/.cargo/config.toml [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate alternate 0.0.0 [INFO] finished tweaking crates.io crate alternate 0.0.0 [INFO] tweaked toml for crates.io crate alternate 0.0.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate alternate 0.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8f72219f85359456761afeb8585893c7aba8529920c6a8e9b704e687fc8894da [INFO] running `Command { std: "docker" "start" "-a" "8f72219f85359456761afeb8585893c7aba8529920c6a8e9b704e687fc8894da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8f72219f85359456761afeb8585893c7aba8529920c6a8e9b704e687fc8894da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f72219f85359456761afeb8585893c7aba8529920c6a8e9b704e687fc8894da", kill_on_drop: false }` [INFO] [stdout] 8f72219f85359456761afeb8585893c7aba8529920c6a8e9b704e687fc8894da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4d9375e41dab5ef018991b860398e4173488aa47e0ec68e78cd31bab1df6cfcf [INFO] running `Command { std: "docker" "start" "-a" "4d9375e41dab5ef018991b860398e4173488aa47e0ec68e78cd31bab1df6cfcf", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling rustversion v1.0.15 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking castaway v0.2.2 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.1 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking vt100 v0.15.2 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Compiling stability v0.2.0 [INFO] [stderr] Compiling serde_derive v1.0.198 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking filedescriptor v0.8.2 [INFO] [stderr] Checking portable-pty v0.8.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking ratatui v0.26.2 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking tui-term v0.1.10 [INFO] [stderr] Checking callee v0.1.4 [INFO] [stderr] Checking alternate v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Backend` [INFO] [stdout] --> src/tui.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 11 | backend::{Backend, CrosstermBackend}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Backend` [INFO] [stdout] --> src/tui.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 11 | backend::{Backend, CrosstermBackend}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Cmd` is never constructed [INFO] [stdout] --> src/cmd.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Cmd { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/cmd.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | Render(usize), [INFO] [stdout] | ------ ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CmdMsg` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 28 | Render(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/cmd.rs:30:10 [INFO] [stdout] | [INFO] [stdout] 30 | Kill(usize), [INFO] [stdout] | ---- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CmdMsg` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 30 | Kill(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Input` and `Output` are never constructed [INFO] [stdout] --> src/cmd.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub enum CmdMsg { [INFO] [stdout] | ------ variants in this enum [INFO] [stdout] 27 | Input(Vec), [INFO] [stdout] | ^^^^^ [INFO] [stdout] 28 | Render(usize), [INFO] [stdout] 29 | Output(Vec), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CmdMsg` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `spawn`, `init`, and `tx` are never used [INFO] [stdout] --> src/cmd.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 33 | impl Cmd { [INFO] [stdout] | -------- associated items in this implementation [INFO] [stdout] 34 | pub fn spawn( [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 86 | pub fn init(initial_buffer: Vec) -> Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 164 | pub fn tx(&self) -> flume::Sender { [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `MasterPtyWriter` is never used [INFO] [stdout] --> src/cmd.rs:185:7 [INFO] [stdout] | [INFO] [stdout] 185 | trait MasterPtyWriter: MasterPty + std::io::Write {} [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `pid` is never read [INFO] [stdout] --> src/cmd.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 190 | pub struct PtyCmd { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 191 | pub vte_parser: Arc>, [INFO] [stdout] 192 | pid: u32, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Provider` is never used [INFO] [stdout] --> src/provider.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | pub enum Provider { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Provider` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 37 | _tx: flume::Sender, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let vte_parser = vt100::Parser::new(size.height, size.width, 1000); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let vte_parser = Arc::new(RwLock::new(vte_parser)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let mut cmd = std::process::Command::new("bat") [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let (tx, rx) = flume::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | // let (cmd_tx, cmd_rx) = flume::unbounded(); [INFO] [stdout] 51 | let stdout = cmd.stdout.take().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let stdin = cmd.stdin.take().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let _writer = std::io::BufWriter::new(stdin); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | vte_parser, [INFO] [stdout] 81 | | tx, [INFO] [stdout] 82 | | rx, [INFO] [stdout] 83 | | // writer, [INFO] [stdout] 84 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 88 | let vte_parser = vt100::Parser::new(0, 0, 1000); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let vte_parser = Arc::new(RwLock::new(vte_parser)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | [INFO] [stdout] 91 | let mut cmd = Command::new("bat") [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let (tx, rx) = flume::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let (cmd_tx, cmd_rx) = flume::unbounded(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let stdout = cmd.stdout.take().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let mut reader = BufReader::new(stdout); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 159 | | tx, [INFO] [stdout] 160 | | rx: cmd_rx, [INFO] [stdout] 161 | | vte_parser, [INFO] [stdout] 162 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:181:8 [INFO] [stdout] | [INFO] [stdout] 175 | let mut handle = stdin.lock(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Ok(bytes::Bytes::from(init_stdin_buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:278:12 [INFO] [stdout] | [INFO] [stdout] 216 | tx: flume::Sender, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | let vte_parser = vt100::Parser::new(size.height, size.width, 1000); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | let vte_parser = Arc::new(RwLock::new(vte_parser)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | [INFO] [stdout] 223 | let pty_system = portable_pty::native_pty_system(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let pair = pty_system.openpty(portable_pty::PtySize { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let mut child = pair.slave.spawn_command(cmd)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | let pid = child.process_id().unwrap_or(0); [INFO] [stdout] 233 | let killer = child.clone_killer(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | [INFO] [stdout] 235 | let mut reader = pair.master.try_clone_reader().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 279 | | vte_parser, [INFO] [stdout] 280 | | pid, [INFO] [stdout] 281 | | master: pair.master, [INFO] [stdout] 282 | | killer, [INFO] [stdout] 283 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 59 | let initial_buffer = opts.inputs().is_none().then(init_stdin_bytes).transpose()?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | tracing::debug!("Initialized Buffer"); [INFO] [stdout] 61 | Ok(Self::new(initial_buffer, callee)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 34 | let terminal = Terminal::new(backend)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(Self::new(terminal)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Cmd` is never constructed [INFO] [stdout] --> src/cmd.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Cmd { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/cmd.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | Render(usize), [INFO] [stdout] | ------ ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CmdMsg` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 28 | Render(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/cmd.rs:30:10 [INFO] [stdout] | [INFO] [stdout] 30 | Kill(usize), [INFO] [stdout] | ---- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CmdMsg` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 30 | Kill(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Input` and `Output` are never constructed [INFO] [stdout] --> src/cmd.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub enum CmdMsg { [INFO] [stdout] | ------ variants in this enum [INFO] [stdout] 27 | Input(Vec), [INFO] [stdout] | ^^^^^ [INFO] [stdout] 28 | Render(usize), [INFO] [stdout] 29 | Output(Vec), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CmdMsg` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `spawn`, `init`, and `tx` are never used [INFO] [stdout] --> src/cmd.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 33 | impl Cmd { [INFO] [stdout] | -------- associated items in this implementation [INFO] [stdout] 34 | pub fn spawn( [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 86 | pub fn init(initial_buffer: Vec) -> Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 164 | pub fn tx(&self) -> flume::Sender { [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `MasterPtyWriter` is never used [INFO] [stdout] --> src/cmd.rs:185:7 [INFO] [stdout] | [INFO] [stdout] 185 | trait MasterPtyWriter: MasterPty + std::io::Write {} [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `pid` is never read [INFO] [stdout] --> src/cmd.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 190 | pub struct PtyCmd { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 191 | pub vte_parser: Arc>, [INFO] [stdout] 192 | pid: u32, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Provider` is never used [INFO] [stdout] --> src/provider.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | pub enum Provider { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Provider` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 37 | _tx: flume::Sender, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let vte_parser = vt100::Parser::new(size.height, size.width, 1000); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let vte_parser = Arc::new(RwLock::new(vte_parser)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let mut cmd = std::process::Command::new("bat") [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let (tx, rx) = flume::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | // let (cmd_tx, cmd_rx) = flume::unbounded(); [INFO] [stdout] 51 | let stdout = cmd.stdout.take().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let stdin = cmd.stdin.take().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let _writer = std::io::BufWriter::new(stdin); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | vte_parser, [INFO] [stdout] 81 | | tx, [INFO] [stdout] 82 | | rx, [INFO] [stdout] 83 | | // writer, [INFO] [stdout] 84 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 88 | let vte_parser = vt100::Parser::new(0, 0, 1000); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let vte_parser = Arc::new(RwLock::new(vte_parser)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | [INFO] [stdout] 91 | let mut cmd = Command::new("bat") [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let (tx, rx) = flume::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let (cmd_tx, cmd_rx) = flume::unbounded(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let stdout = cmd.stdout.take().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let mut reader = BufReader::new(stdout); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 159 | | tx, [INFO] [stdout] 160 | | rx: cmd_rx, [INFO] [stdout] 161 | | vte_parser, [INFO] [stdout] 162 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:181:8 [INFO] [stdout] | [INFO] [stdout] 175 | let mut handle = stdin.lock(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Ok(bytes::Bytes::from(init_stdin_buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:278:12 [INFO] [stdout] | [INFO] [stdout] 216 | tx: flume::Sender, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | let vte_parser = vt100::Parser::new(size.height, size.width, 1000); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | let vte_parser = Arc::new(RwLock::new(vte_parser)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | [INFO] [stdout] 223 | let pty_system = portable_pty::native_pty_system(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let pair = pty_system.openpty(portable_pty::PtySize { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let mut child = pair.slave.spawn_command(cmd)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | let pid = child.process_id().unwrap_or(0); [INFO] [stdout] 233 | let killer = child.clone_killer(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | [INFO] [stdout] 235 | let mut reader = pair.master.try_clone_reader().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 279 | | vte_parser, [INFO] [stdout] 280 | | pid, [INFO] [stdout] 281 | | master: pair.master, [INFO] [stdout] 282 | | killer, [INFO] [stdout] 283 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 59 | let initial_buffer = opts.inputs().is_none().then(init_stdin_bytes).transpose()?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | tracing::debug!("Initialized Buffer"); [INFO] [stdout] 61 | Ok(Self::new(initial_buffer, callee)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 34 | let terminal = Terminal::new(backend)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(Self::new(terminal)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `alternate` (bin "alternate" test) due to 7 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `alternate` (bin "alternate") due to 7 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4d9375e41dab5ef018991b860398e4173488aa47e0ec68e78cd31bab1df6cfcf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d9375e41dab5ef018991b860398e4173488aa47e0ec68e78cd31bab1df6cfcf", kill_on_drop: false }` [INFO] [stdout] 4d9375e41dab5ef018991b860398e4173488aa47e0ec68e78cd31bab1df6cfcf