[INFO] fetching crate alopecosa 0.1.3... [INFO] checking alopecosa-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate alopecosa 0.1.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate alopecosa 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate alopecosa 0.1.3 [INFO] finished tweaking crates.io crate alopecosa 0.1.3 [INFO] tweaked toml for crates.io crate alopecosa 0.1.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate alopecosa 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 04c44e8318a36099d7e0d6dc2d3aea4c18610fc9b887428527024b27843fb197 [INFO] running `Command { std: "docker" "start" "-a" "04c44e8318a36099d7e0d6dc2d3aea4c18610fc9b887428527024b27843fb197", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "04c44e8318a36099d7e0d6dc2d3aea4c18610fc9b887428527024b27843fb197", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04c44e8318a36099d7e0d6dc2d3aea4c18610fc9b887428527024b27843fb197", kill_on_drop: false }` [INFO] [stdout] 04c44e8318a36099d7e0d6dc2d3aea4c18610fc9b887428527024b27843fb197 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2a8c82f0fa7579896f0b88e0fefdab4836c94b0de75e3a1953b6c45d86c4e8e5 [INFO] running `Command { std: "docker" "start" "-a" "2a8c82f0fa7579896f0b88e0fefdab4836c94b0de75e3a1953b6c45d86c4e8e5", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.28 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.74 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Checking instant v0.1.10 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Checking cpufeatures v0.1.5 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling tokio v1.9.0 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking dashmap v4.0.2 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking rmp v0.8.10 [INFO] [stderr] Checking sha-1 v0.9.7 [INFO] [stderr] Checking rmpv v0.4.7 [INFO] [stderr] Compiling tokio-macros v1.3.0 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking rmp-serde v0.15.5 [INFO] [stderr] Checking alopecosa v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iproto/types.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 43 | fn from(err: io::Error) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Error::ParseError(rmp_serde::decode::Error::InvalidDataRead(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iproto/types.rs:50:27 [INFO] [stdout] | [INFO] [stdout] 49 | fn from(err: NumValueReadError) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Error::ParseError(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iproto/types.rs:56:25 [INFO] [stdout] | [INFO] [stdout] 55 | fn from(err: ValueReadError) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Error::ParseError(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iproto/response.rs:151:42 [INFO] [stdout] | [INFO] [stdout] 151 | String::from_utf8(buf).map_err(|_| io::Error::new( [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 152 | | io::ErrorKind::InvalidInput, [INFO] [stdout] 153 | | "invalid ut8 string", [INFO] [stdout] 154 | | ).into()) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iproto/request.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn new(request: RequestType, body: B) -> Request { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | body: Box::new(body), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iproto/request.rs:218:16 [INFO] [stdout] | [INFO] [stdout] 218 | .map(|v| v.clone().into()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iproto/request.rs:256:25 [INFO] [stdout] | [INFO] [stdout] 256 | self.iter().map(|v| v.clone().into()).collect() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `alopecosa` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iproto/types.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 43 | fn from(err: io::Error) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Error::ParseError(rmp_serde::decode::Error::InvalidDataRead(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iproto/types.rs:50:27 [INFO] [stdout] | [INFO] [stdout] 49 | fn from(err: NumValueReadError) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Error::ParseError(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iproto/types.rs:56:25 [INFO] [stdout] | [INFO] [stdout] 55 | fn from(err: ValueReadError) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Error::ParseError(err.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iproto/response.rs:151:42 [INFO] [stdout] | [INFO] [stdout] 151 | String::from_utf8(buf).map_err(|_| io::Error::new( [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 152 | | io::ErrorKind::InvalidInput, [INFO] [stdout] 153 | | "invalid ut8 string", [INFO] [stdout] 154 | | ).into()) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iproto/request.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn new(request: RequestType, body: B) -> Request { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | body: Box::new(body), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iproto/request.rs:218:16 [INFO] [stdout] | [INFO] [stdout] 218 | .map(|v| v.clone().into()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iproto/request.rs:256:25 [INFO] [stdout] | [INFO] [stdout] 256 | self.iter().map(|v| v.clone().into()).collect() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `alopecosa` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "2a8c82f0fa7579896f0b88e0fefdab4836c94b0de75e3a1953b6c45d86c4e8e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a8c82f0fa7579896f0b88e0fefdab4836c94b0de75e3a1953b6c45d86c4e8e5", kill_on_drop: false }` [INFO] [stdout] 2a8c82f0fa7579896f0b88e0fefdab4836c94b0de75e3a1953b6c45d86c4e8e5