[INFO] fetching crate alice 0.1.0-alpha.1... [INFO] checking alice-0.1.0-alpha.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate alice 0.1.0-alpha.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate alice 0.1.0-alpha.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate alice 0.1.0-alpha.1 [INFO] finished tweaking crates.io crate alice 0.1.0-alpha.1 [INFO] tweaked toml for crates.io crate alice 0.1.0-alpha.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate alice 0.1.0-alpha.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f6a70537d174aca54585724435ae0f99f57e5d8c382e5be9524fc2a350d7ba25 [INFO] running `Command { std: "docker" "start" "-a" "f6a70537d174aca54585724435ae0f99f57e5d8c382e5be9524fc2a350d7ba25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f6a70537d174aca54585724435ae0f99f57e5d8c382e5be9524fc2a350d7ba25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f6a70537d174aca54585724435ae0f99f57e5d8c382e5be9524fc2a350d7ba25", kill_on_drop: false }` [INFO] [stdout] f6a70537d174aca54585724435ae0f99f57e5d8c382e5be9524fc2a350d7ba25 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1115d8f851df91f14ba4c37f75ccaf97adb59e4c3e63cc7e1ae60160fcf5eea5 [INFO] running `Command { std: "docker" "start" "-a" "1115d8f851df91f14ba4c37f75ccaf97adb59e4c3e63cc7e1ae60160fcf5eea5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.94 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling gmp-mpfr-sys v1.4.5 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling const_fn v0.4.7 [INFO] [stderr] Compiling az v1.1.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling standback v0.2.17 [INFO] [stderr] Compiling time v0.2.26 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling rug v1.12.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking predicates-core v1.0.2 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking predicates v1.0.8 [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking predicates-tree v1.0.2 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking array-init v0.1.1 [INFO] [stderr] Checking assert_cmd v1.0.3 [INFO] [stderr] Compiling time-macros-impl v0.1.1 [INFO] [stderr] Checking time-macros v0.1.1 [INFO] [stderr] Checking alice v0.1.0-alpha.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated associated function `time::OffsetDateTime::now_local`: UTC is returned if the local offset cannot be determined [INFO] [stdout] --> src/main.rs:1467:53 [INFO] [stdout] | [INFO] [stdout] 1467 | let now = time::OffsetDateTime::now_local(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `time::OffsetDateTime::now_local`: UTC is returned if the local offset cannot be determined [INFO] [stdout] --> src/main.rs:1467:53 [INFO] [stdout] | [INFO] [stdout] 1467 | let now = time::OffsetDateTime::now_local(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/main.rs:305:36 [INFO] [stdout] | [INFO] [stdout] 305 | (b'W', _, None) => drop(returns.pop()), [INFO] [stdout] | ^^^^^-------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `Option<(isize, isize)>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 305 - (b'W', _, None) => drop(returns.pop()), [INFO] [stdout] 305 + (b'W', _, None) => let _ = returns.pop(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:420:73 [INFO] [stdout] | [INFO] [stdout] 420 | ... let filler_factory = || StackItem::Cardinal(Int::from(0)); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1762:27 [INFO] [stdout] | [INFO] [stdout] 1761 | pub(crate) fn new(item: T, count: usize) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1762 | RepeatFor { item: Some(item), count } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:255:25 [INFO] [stdout] | [INFO] [stdout] 254 | pub fn push(&mut self, value: impl Into) { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 255 | self.inner.push(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:265:19 [INFO] [stdout] | [INFO] [stdout] 264 | pub fn push_cardinal(&mut self, value: impl Into) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | self.push(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/types.rs:285:37 [INFO] [stdout] | [INFO] [stdout] 285 | ... drop(chars.next()); [INFO] [stdout] | ^^^^^------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `Option` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 285 - drop(chars.next()); [INFO] [stdout] 285 + let _ = chars.next(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:339:24 [INFO] [stdout] | [INFO] [stdout] 338 | fn from_iter>(iterable: I) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | Stack { inner: iterable.into_iter().map(T::into).collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:345:27 [INFO] [stdout] | [INFO] [stdout] 344 | fn extend>(&mut self, iterable: I) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | self.inner.extend(iterable.into_iter().map(T::into)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/main.rs:305:36 [INFO] [stdout] | [INFO] [stdout] 305 | (b'W', _, None) => drop(returns.pop()), [INFO] [stdout] | ^^^^^-------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `Option<(isize, isize)>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 305 - (b'W', _, None) => drop(returns.pop()), [INFO] [stdout] 305 + (b'W', _, None) => let _ = returns.pop(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:420:73 [INFO] [stdout] | [INFO] [stdout] 420 | ... let filler_factory = || StackItem::Cardinal(Int::from(0)); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1762:27 [INFO] [stdout] | [INFO] [stdout] 1761 | pub(crate) fn new(item: T, count: usize) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1762 | RepeatFor { item: Some(item), count } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:255:25 [INFO] [stdout] | [INFO] [stdout] 254 | pub fn push(&mut self, value: impl Into) { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 255 | self.inner.push(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `alice` (bin "alice") due to 7 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:265:19 [INFO] [stdout] | [INFO] [stdout] 264 | pub fn push_cardinal(&mut self, value: impl Into) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | self.push(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/types.rs:285:37 [INFO] [stdout] | [INFO] [stdout] 285 | ... drop(chars.next()); [INFO] [stdout] | ^^^^^------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `Option` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 285 - drop(chars.next()); [INFO] [stdout] 285 + let _ = chars.next(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:339:24 [INFO] [stdout] | [INFO] [stdout] 338 | fn from_iter>(iterable: I) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | Stack { inner: iterable.into_iter().map(T::into).collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:345:27 [INFO] [stdout] | [INFO] [stdout] 344 | fn extend>(&mut self, iterable: I) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | self.inner.extend(iterable.into_iter().map(T::into)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `alice` (bin "alice" test) due to 7 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1115d8f851df91f14ba4c37f75ccaf97adb59e4c3e63cc7e1ae60160fcf5eea5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1115d8f851df91f14ba4c37f75ccaf97adb59e4c3e63cc7e1ae60160fcf5eea5", kill_on_drop: false }` [INFO] [stdout] 1115d8f851df91f14ba4c37f75ccaf97adb59e4c3e63cc7e1ae60160fcf5eea5