[INFO] fetching crate algonaut_abi 0.4.2... [INFO] checking algonaut_abi-0.4.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate algonaut_abi 0.4.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate algonaut_abi 0.4.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate algonaut_abi 0.4.2 [INFO] finished tweaking crates.io crate algonaut_abi 0.4.2 [INFO] tweaked toml for crates.io crate algonaut_abi 0.4.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 73 packages to latest compatible versions [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1912645dfda923c216c998e5fbb283c239602bff4a64fbe6f2d82c5e061f4d45 [INFO] running `Command { std: "docker" "start" "-a" "1912645dfda923c216c998e5fbb283c239602bff4a64fbe6f2d82c5e061f4d45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1912645dfda923c216c998e5fbb283c239602bff4a64fbe6f2d82c5e061f4d45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1912645dfda923c216c998e5fbb283c239602bff4a64fbe6f2d82c5e061f4d45", kill_on_drop: false }` [INFO] [stdout] 1912645dfda923c216c998e5fbb283c239602bff4a64fbe6f2d82c5e061f4d45 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ab05cdfef98deab7d337bdf03c48cd575e4ed92caa5e243cc427db5e66a27d04 [INFO] running `Command { std: "docker" "start" "-a" "ab05cdfef98deab7d337bdf03c48cd575e4ed92caa5e243cc427db5e66a27d04", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking algonaut_encoding v0.4.2 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking algonaut_crypto v0.4.2 [INFO] [stderr] Checking algonaut_core v0.4.2 [INFO] [stderr] Checking algonaut_abi v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi_interactions.rs:294:12 [INFO] [stdout] | [INFO] [stdout] 264 | let mut return_type = AbiReturn { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | let mut args: Vec = Vec::with_capacity(arg_types.len()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | Ok(AbiMethod { [INFO] [stdout] | ____________^ [INFO] [stdout] 295 | | name: name.to_owned(), [INFO] [stdout] 296 | | args, [INFO] [stdout] 297 | | returns: return_type, [INFO] [stdout] 298 | | description: None, [INFO] [stdout] 299 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi_type.rs:99:25 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn dynamic_array(arg_type: AbiType) -> AbiType { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | AbiType::DynamicArray { [INFO] [stdout] 99 | child_type: Box::new(arg_type), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi_type.rs:106:25 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn static_array(arg_type: AbiType, array_len: u16) -> AbiType { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | child_type: Box::new(arg_type), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi_type.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 162 | pub fn tuple(argument_types: Vec) -> Result { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Ok(AbiType::Tuple { [INFO] [stdout] | ____________^ [INFO] [stdout] 170 | | len: argument_types.len() as u16, // cast: safe bounds checked in this fn [INFO] [stdout] 171 | | child_types: argument_types, [INFO] [stdout] 172 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `algonaut_abi` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi_interaction_tests.rs:276:33 [INFO] [stdout] | [INFO] [stdout] 276 | parsed: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `algonaut_abi` (lib test) due to 9 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi_interactions.rs:294:12 [INFO] [stdout] | [INFO] [stdout] 264 | let mut return_type = AbiReturn { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | let mut args: Vec = Vec::with_capacity(arg_types.len()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | Ok(AbiMethod { [INFO] [stdout] | ____________^ [INFO] [stdout] 295 | | name: name.to_owned(), [INFO] [stdout] 296 | | args, [INFO] [stdout] 297 | | returns: return_type, [INFO] [stdout] 298 | | description: None, [INFO] [stdout] 299 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi_json_tests.rs:309:13 [INFO] [stdout] | [INFO] [stdout] 256 | let contract: AbiContract = serde_json::from_str(json).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | [INFO] [stdout] 258 | let methods = vec![ [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | / AbiContract { [INFO] [stdout] 310 | | name: "Calculator".to_owned(), [INFO] [stdout] 311 | | description: Some("example description".to_owned()), [INFO] [stdout] 312 | | networks: [].into(), [INFO] [stdout] 313 | | methods [INFO] [stdout] 314 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi_json_tests.rs:374:13 [INFO] [stdout] | [INFO] [stdout] 321 | let contract: AbiContract = serde_json::from_str(json).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | [INFO] [stdout] 323 | let methods = vec![ [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 374 | / AbiContract { [INFO] [stdout] 375 | | name: "Calculator".to_owned(), [INFO] [stdout] 376 | | description: Some("example description".to_owned()), [INFO] [stdout] 377 | | networks: [( [INFO] [stdout] ... | [INFO] [stdout] 382 | | methods [INFO] [stdout] 383 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi_type.rs:99:25 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn dynamic_array(arg_type: AbiType) -> AbiType { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | AbiType::DynamicArray { [INFO] [stdout] 99 | child_type: Box::new(arg_type), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi_type.rs:106:25 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn static_array(arg_type: AbiType, array_len: u16) -> AbiType { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | child_type: Box::new(arg_type), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi_type.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 162 | pub fn tuple(argument_types: Vec) -> Result { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Ok(AbiType::Tuple { [INFO] [stdout] | ____________^ [INFO] [stdout] 170 | | len: argument_types.len() as u16, // cast: safe bounds checked in this fn [INFO] [stdout] 171 | | child_types: argument_types, [INFO] [stdout] 172 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi_type_test.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 18 | let mut tuple_elems = vec![]; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | AbiType::tuple(tuple_elems).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/abi_type_test.rs:456:43 [INFO] [stdout] | [INFO] [stdout] 456 | let ct_list = t.children().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[AbiType]` does not implement `Clone`, so calling `clone` on `&[AbiType]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "ab05cdfef98deab7d337bdf03c48cd575e4ed92caa5e243cc427db5e66a27d04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab05cdfef98deab7d337bdf03c48cd575e4ed92caa5e243cc427db5e66a27d04", kill_on_drop: false }` [INFO] [stdout] ab05cdfef98deab7d337bdf03c48cd575e4ed92caa5e243cc427db5e66a27d04