[INFO] fetching crate algeo 0.1.0... [INFO] checking algeo-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate algeo 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate algeo 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate algeo 0.1.0 [INFO] finished tweaking crates.io crate algeo 0.1.0 [INFO] tweaked toml for crates.io crate algeo 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate algeo 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d0e671beffe9ebd4cdf77c2aaeada8d4dca7c8681497367813b0a1da9b60606c [INFO] running `Command { std: "docker" "start" "-a" "d0e671beffe9ebd4cdf77c2aaeada8d4dca7c8681497367813b0a1da9b60606c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d0e671beffe9ebd4cdf77c2aaeada8d4dca7c8681497367813b0a1da9b60606c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d0e671beffe9ebd4cdf77c2aaeada8d4dca7c8681497367813b0a1da9b60606c", kill_on_drop: false }` [INFO] [stdout] d0e671beffe9ebd4cdf77c2aaeada8d4dca7c8681497367813b0a1da9b60606c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 48ddde4cb488e299bc51065fe50610dab05d9b4c20420b2794ca4fb164625996 [INFO] running `Command { std: "docker" "start" "-a" "48ddde4cb488e299bc51065fe50610dab05d9b4c20420b2794ca4fb164625996", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.75 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling darling_core v0.13.0 [INFO] [stderr] Compiling darling_macro v0.13.0 [INFO] [stderr] Compiling darling v0.13.0 [INFO] [stderr] Compiling xops_core v0.1.0 [INFO] [stderr] Compiling xops_macros v0.1.0 [INFO] [stderr] Checking xops v0.1.0 [INFO] [stderr] Checking algeo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/linalg/util.rs:26:64 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn num_to_seq(n: usize, base: usize) -> impl Iterator { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 26 - pub fn num_to_seq(n: usize, base: usize) -> impl Iterator { [INFO] [stdout] 26 + pub fn num_to_seq(n: usize, base: usize) -> impl Iterator { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/linalg/util.rs:26:64 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn num_to_seq(n: usize, base: usize) -> impl Iterator { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 26 - pub fn num_to_seq(n: usize, base: usize) -> impl Iterator { [INFO] [stdout] 26 + pub fn num_to_seq(n: usize, base: usize) -> impl Iterator { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/linalg/cone.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | let mut subset_kernel = subset_rref.compute_kernel(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `generators`, `facets`, `orth_comp_basis`, `ambient_dim`, and `dim` are never read [INFO] [stdout] --> src/linalg/cone.rs:10:2 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Cone { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 10 | generators: Vec>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 11 | facets: Vec>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 12 | orth_comp_basis: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 13 | [INFO] [stdout] 14 | ambient_dim: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 15 | dim: usize, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `normal` and `generators` are never read [INFO] [stdout] --> src/linalg/cone.rs:19:2 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Face { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 19 | normal: Mat, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 20 | generators: Vec> [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linalg/mat.rs:330:6 [INFO] [stdout] | [INFO] [stdout] 330 | self.get_row_iter(r).zip(other.get_col_iter(c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linalg/util.rs:19:2 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn get_max_index(slice: I, le: C) -> usize where [INFO] [stdout] | -------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | / slice [INFO] [stdout] 20 | | .enumerate() [INFO] [stdout] 21 | | .max_by(|(_n, x), (_m, y)| le(x, y).unwrap()) [INFO] [stdout] 22 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linalg/algorithm.rs:343:3 [INFO] [stdout] | [INFO] [stdout] 337 | let bound_variables : HashSet = [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | bound_variables.into_iter().map(|c| self.original.get_col(c)).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `algeo` (lib) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/linalg/cone.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | let mut subset_kernel = subset_rref.compute_kernel(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `generators`, `facets`, `orth_comp_basis`, `ambient_dim`, and `dim` are never read [INFO] [stdout] --> src/linalg/cone.rs:10:2 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Cone { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 10 | generators: Vec>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 11 | facets: Vec>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 12 | orth_comp_basis: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 13 | [INFO] [stdout] 14 | ambient_dim: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 15 | dim: usize, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `normal` and `generators` are never read [INFO] [stdout] --> src/linalg/cone.rs:19:2 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Face { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 19 | normal: Mat, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 20 | generators: Vec> [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linalg/mat.rs:330:6 [INFO] [stdout] | [INFO] [stdout] 330 | self.get_row_iter(r).zip(other.get_col_iter(c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linalg/util.rs:19:2 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn get_max_index(slice: I, le: C) -> usize where [INFO] [stdout] | -------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | / slice [INFO] [stdout] 20 | | .enumerate() [INFO] [stdout] 21 | | .max_by(|(_n, x), (_m, y)| le(x, y).unwrap()) [INFO] [stdout] 22 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linalg/algorithm.rs:343:3 [INFO] [stdout] | [INFO] [stdout] 337 | let bound_variables : HashSet = [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | bound_variables.into_iter().map(|c| self.original.get_col(c)).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `algeo` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "48ddde4cb488e299bc51065fe50610dab05d9b4c20420b2794ca4fb164625996", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48ddde4cb488e299bc51065fe50610dab05d9b4c20420b2794ca4fb164625996", kill_on_drop: false }` [INFO] [stdout] 48ddde4cb488e299bc51065fe50610dab05d9b4c20420b2794ca4fb164625996