[INFO] fetching crate alass-core 2.0.0... [INFO] checking alass-core-2.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate alass-core 2.0.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate alass-core 2.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate alass-core 2.0.0 [INFO] finished tweaking crates.io crate alass-core 2.0.0 [INFO] tweaked toml for crates.io crate alass-core 2.0.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b9da06edf9cc411febda4c3d538aa4649a99fdeec22be64edbc56746985880e [INFO] running `Command { std: "docker" "start" "-a" "8b9da06edf9cc411febda4c3d538aa4649a99fdeec22be64edbc56746985880e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b9da06edf9cc411febda4c3d538aa4649a99fdeec22be64edbc56746985880e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b9da06edf9cc411febda4c3d538aa4649a99fdeec22be64edbc56746985880e", kill_on_drop: false }` [INFO] [stdout] 8b9da06edf9cc411febda4c3d538aa4649a99fdeec22be64edbc56746985880e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a3603e286a5edba02202cada246967cf04e21e73b0ea3cce264f1c6957b6284 [INFO] running `Command { std: "docker" "start" "-a" "5a3603e286a5edba02202cada246967cf04e21e73b0ea3cce264f1c6957b6284", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking alass-core v2.0.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stdout] warning: unexpected `cfg` condition value: `statistics` [INFO] [stdout] --> src/alass.rs:354:11 [INFO] [stdout] | [INFO] [stdout] 354 | #[cfg(feature = "statistics")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default` and `nosplit-heap-sort` [INFO] [stdout] = help: consider adding `statistics` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/alass.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 92 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/rating_type.rs:144:35 [INFO] [stdout] | [INFO] [stdout] 144 | const RATING_PRECISION: i64 = (1 << 32); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 144 - const RATING_PRECISION: i64 = (1 << 32); [INFO] [stdout] 144 + const RATING_PRECISION: i64 = 1 << 32; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[inline]` is ignored on function prototypes [INFO] [stdout] --> src/rating_type.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | #[inline] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[inline]` is ignored on function prototypes [INFO] [stdout] --> src/rating_type.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | #[inline] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[inline]` is ignored on function prototypes [INFO] [stdout] --> src/rating_type.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 192 | #[inline] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[inline]` is ignored on function prototypes [INFO] [stdout] --> src/segments.rs:1691:5 [INFO] [stdout] | [INFO] [stdout] 1691 | #[inline] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[inline]` is ignored on function prototypes [INFO] [stdout] --> src/segments.rs:1694:5 [INFO] [stdout] | [INFO] [stdout] 1694 | #[inline] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `div_by_i64_to_delta` and `as_readable_f32` are never used [INFO] [stdout] --> src/rating_type.rs:185:12 [INFO] [stdout] | [INFO] [stdout] 146 | pub trait RatingExt { [INFO] [stdout] | --------- associated items in this trait [INFO] [stdout] ... [INFO] [stdout] 185 | fn div_by_i64_to_delta(r: Rating, other: i64) -> RatingDelta { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 190 | fn as_readable_f32(self) -> f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:415:19 [INFO] [stdout] | [INFO] [stdout] 412 | pub fn annotate_with_segment_start_points(self) -> FullSegmentIterator>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 415 | iter: self.iter.scan( [INFO] [stdout] | ___________________^ [INFO] [stdout] 416 | | self.start, [INFO] [stdout] 417 | | #[inline] [INFO] [stdout] 418 | | |last_segment_end: &mut Point, segment: Segment| { [INFO] [stdout] ... | [INFO] [stdout] 435 | | }, [INFO] [stdout] 436 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:449:19 [INFO] [stdout] | [INFO] [stdout] 446 | pub fn shift(self, t: TimeDelta) -> SegmentIterator> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 449 | iter: self.iter.map( [INFO] [stdout] | ___________________^ [INFO] [stdout] 450 | | #[inline] [INFO] [stdout] 451 | | move |mut segment: Segment| { [INFO] [stdout] 452 | | segment.end_point += t; [INFO] [stdout] 453 | | segment [INFO] [stdout] 454 | | }, [INFO] [stdout] 455 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:463:19 [INFO] [stdout] | [INFO] [stdout] 460 | pub fn shift_simple(self, t: TimeDelta) -> SegmentIterator> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 463 | iter: self.iter.map( [INFO] [stdout] | ___________________^ [INFO] [stdout] 464 | | #[inline] [INFO] [stdout] 465 | | move |mut segment: Segment| { [INFO] [stdout] 466 | | segment.end_point += t; [INFO] [stdout] 467 | | segment [INFO] [stdout] 468 | | }, [INFO] [stdout] 469 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:477:19 [INFO] [stdout] | [INFO] [stdout] 474 | pub fn append(self, end_point: Point, data: D) -> SegmentIterator> { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 477 | iter: self.iter.chain(once(Segment:: { [INFO] [stdout] | ___________________^ [INFO] [stdout] 478 | | end_point: end_point, [INFO] [stdout] 479 | | data: data, [INFO] [stdout] 480 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:490:19 [INFO] [stdout] | [INFO] [stdout] 487 | pub fn discard_start_times(self) -> SegmentIterator> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 490 | iter: self.iter.map(|segment: FullSegment| Segment:: { [INFO] [stdout] | ___________________^ [INFO] [stdout] 491 | | end_point: segment.span.end, [INFO] [stdout] 492 | | data: segment.data, [INFO] [stdout] 493 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:667:19 [INFO] [stdout] | [INFO] [stdout] 650 | pub fn add_ratings_from(mut self, mut iter2: RatingIterator) -> DualFullSegmentIterator { [INFO] [stdout] | -------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 667 | iter: RatingAdderIterator2::<_, _> { [INFO] [stdout] | ___________________^ [INFO] [stdout] 668 | | segment_start: start, [INFO] [stdout] 669 | | dual_seg1: dual_seg1, [INFO] [stdout] 670 | | dual_seg2: dual_seg2, [INFO] [stdout] ... | [INFO] [stdout] 673 | | finished: false, [INFO] [stdout] 674 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:722:19 [INFO] [stdout] | [INFO] [stdout] 719 | pub fn only_offsets(self) -> OffsetIterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 722 | iter: self.iter.map(|dual_segment| dual_segment.as_offset_segment()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:730:19 [INFO] [stdout] | [INFO] [stdout] 727 | pub fn only_ratings(self) -> RatingIterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 730 | iter: self.iter.map(|dual_segment| dual_segment.as_rating_segment()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:738:19 [INFO] [stdout] | [INFO] [stdout] 735 | pub fn simplify(mut self) -> DualFullSegmentIterator { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 738 | iter: DualSimplifyIterator { [INFO] [stdout] | ___________________^ [INFO] [stdout] 739 | | current_segment: self.iter.next().map(|seg| seg.with_start_point(self.start)), [INFO] [stdout] 740 | | iter: self.iter, [INFO] [stdout] 741 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:772:17 [INFO] [stdout] | [INFO] [stdout] 767 | pub fn save_simplified(self) -> RatingBuffer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 772 | simplifiy_ratings_push_iter(self.start, discard_start_times_push_iter(collect_to_vec_push_iter())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:780:19 [INFO] [stdout] | [INFO] [stdout] 777 | pub fn extend_to(self, end_point: Point) -> RatingIterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 780 | iter: ExtendToIterator { [INFO] [stdout] | ___________________^ [INFO] [stdout] 781 | | input_iter: self.iter, [INFO] [stdout] 782 | | data_to_extend: Some(RatingInfo { [INFO] [stdout] 783 | | rating: Rating::zero(), [INFO] [stdout] ... | [INFO] [stdout] 786 | | end_point: end_point, [INFO] [stdout] 787 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:797:17 [INFO] [stdout] | [INFO] [stdout] 792 | pub fn save_aggressively_simplified(self, epsilon: RatingDelta) -> RatingBuffer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 797 | / aggressive_simplifiy_ratings_push_iter( [INFO] [stdout] 798 | | self.start, [INFO] [stdout] 799 | | epsilon, [INFO] [stdout] 800 | | discard_start_times_push_iter(collect_to_vec_push_iter()), [INFO] [stdout] 801 | | ), [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:810:19 [INFO] [stdout] | [INFO] [stdout] 807 | pub fn add_rating(self, rating_delta: RatingDelta) -> RatingIterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 810 | iter: self.iter.map(move |rating_segment| RatingSegment { [INFO] [stdout] | ___________________^ [INFO] [stdout] 811 | | end_point: rating_segment.end_point, [INFO] [stdout] 812 | | data: RatingInfo { [INFO] [stdout] 813 | | rating: rating_segment.data.rating + rating_delta, [INFO] [stdout] 814 | | delta: rating_segment.data.delta, [INFO] [stdout] 815 | | }, [INFO] [stdout] 816 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:825:19 [INFO] [stdout] | [INFO] [stdout] 821 | pub fn clamp_end(self, clamp: Point) -> RatingIterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 825 | iter: self.iter.map(move |rating_segment| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 826 | | /*if rating_segment.end_point >= clamp { [INFO] [stdout] 827 | | println!("CLAMPED {} to {} {:#?}", rating_segment.end_point, clamp, rating_segment.data); [INFO] [stdout] 828 | | }*/ [INFO] [stdout] ... | [INFO] [stdout] 832 | | } [INFO] [stdout] 833 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:1150:19 [INFO] [stdout] | [INFO] [stdout] 1147 | pub fn left_to_right_maximum(self) -> DualFullSegmentIterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1150 | iter: LeftToRightMaximumIterator::<_>::new(self.iter, self.start), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:1350:15 [INFO] [stdout] | [INFO] [stdout] 1333 | mut iter1: DualIterator, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1334 | mut iter2: DualIterator, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1350 | iter: CombinedMaximumDualIterator::<_, _> { [INFO] [stdout] | _______________^ [INFO] [stdout] 1351 | | stored_segment: None, [INFO] [stdout] 1352 | | segment_start: start, [INFO] [stdout] 1353 | | dual_seg1: dual_seg1, [INFO] [stdout] ... | [INFO] [stdout] 1357 | | finished: false, [INFO] [stdout] 1358 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:1371:19 [INFO] [stdout] | [INFO] [stdout] 1366 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1367 | offset_generate: impl Fn(/* segment_start */ Point) -> Offset, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1371 | iter: self.iter.map( [INFO] [stdout] | ___________________^ [INFO] [stdout] 1372 | | #[inline] [INFO] [stdout] 1373 | | move |rating_full_segment| DualFullSegment { [INFO] [stdout] 1374 | | span: rating_full_segment.span, [INFO] [stdout] ... | [INFO] [stdout] 1382 | | }, [INFO] [stdout] 1383 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:2049:10 [INFO] [stdout] | [INFO] [stdout] 2048 | fn finish(self) -> (I1::Output, I2::Output) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2049 | (self.iter1.finish(), self.iter2.finish()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segments.rs:2049:31 [INFO] [stdout] | [INFO] [stdout] 2048 | fn finish(self) -> (I1::Output, I2::Output) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2049 | (self.iter1.finish(), self.iter2.finish()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time_types.rs:77:19 [INFO] [stdout] | [INFO] [stdout] 76 | fn sum>(iter: I) -> TimeDelta { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | TimeDelta(iter.map(|d| d.0).sum()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `alass-core` (lib) due to 21 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5a3603e286a5edba02202cada246967cf04e21e73b0ea3cce264f1c6957b6284", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a3603e286a5edba02202cada246967cf04e21e73b0ea3cce264f1c6957b6284", kill_on_drop: false }` [INFO] [stdout] 5a3603e286a5edba02202cada246967cf04e21e73b0ea3cce264f1c6957b6284