[INFO] fetching crate airone 0.8.1... [INFO] checking airone-0.8.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate airone 0.8.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate airone 0.8.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate airone 0.8.1 [INFO] finished tweaking crates.io crate airone 0.8.1 [INFO] tweaked toml for crates.io crate airone 0.8.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate airone 0.8.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 42b2a9c5f2a2b8ec7f5d6d29f26f2cdd996b4d62636a3942372a2a0c5669d873 [INFO] running `Command { std: "docker" "start" "-a" "42b2a9c5f2a2b8ec7f5d6d29f26f2cdd996b4d62636a3942372a2a0c5669d873", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "42b2a9c5f2a2b8ec7f5d6d29f26f2cdd996b4d62636a3942372a2a0c5669d873", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42b2a9c5f2a2b8ec7f5d6d29f26f2cdd996b4d62636a3942372a2a0c5669d873", kill_on_drop: false }` [INFO] [stdout] 42b2a9c5f2a2b8ec7f5d6d29f26f2cdd996b4d62636a3942372a2a0c5669d873 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 499a6e30615573aea0b2b3b27c72c442405629aa82564769eb0b49c6c5d73200 [INFO] running `Command { std: "docker" "start" "-a" "499a6e30615573aea0b2b3b27c72c442405629aa82564769eb0b49c6c5d73200", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.84 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling airone_derive v0.8.1 [INFO] [stderr] Checking airone v0.8.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/mod.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 62 | let (filewriter, data) = loading::full_load(custom_name)?; [INFO] [stdout] | ---------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | buf_writer: filewriter, [INFO] [stdout] 65 | | elements: data, [INFO] [stdout] 66 | | pending_changes: Vec::new(), [INFO] [stdout] 67 | | mode: PhantomData, [INFO] [stdout] 68 | | write_mode: BufferMode::Buffered [INFO] [stdout] 69 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/mod.rs:136:12 [INFO] [stdout] | [INFO] [stdout] 131 | mut self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(AironeDb:: { [INFO] [stdout] | ____________^ [INFO] [stdout] 137 | | buf_writer: self.buf_writer, [INFO] [stdout] 138 | | elements: self.elements, [INFO] [stdout] 139 | | pending_changes: self.pending_changes, [INFO] [stdout] 140 | | mode: PhantomData, [INFO] [stdout] 141 | | write_mode: self.write_mode [INFO] [stdout] 142 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/loading.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 47 | let mut elements: Vec = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let file = std::fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let filewriter = BufWriter::new(file); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | Ok((filewriter, elements)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `airone` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/mod.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 62 | let (filewriter, data) = loading::full_load(custom_name)?; [INFO] [stdout] | ---------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | buf_writer: filewriter, [INFO] [stdout] 65 | | elements: data, [INFO] [stdout] 66 | | pending_changes: Vec::new(), [INFO] [stdout] 67 | | mode: PhantomData, [INFO] [stdout] 68 | | write_mode: BufferMode::Buffered [INFO] [stdout] 69 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/mod.rs:136:12 [INFO] [stdout] | [INFO] [stdout] 131 | mut self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(AironeDb:: { [INFO] [stdout] | ____________^ [INFO] [stdout] 137 | | buf_writer: self.buf_writer, [INFO] [stdout] 138 | | elements: self.elements, [INFO] [stdout] 139 | | pending_changes: self.pending_changes, [INFO] [stdout] 140 | | mode: PhantomData, [INFO] [stdout] 141 | | write_mode: self.write_mode [INFO] [stdout] 142 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/loading.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 47 | let mut elements: Vec = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let file = std::fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let filewriter = BufWriter::new(file); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | Ok((filewriter, elements)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused implementer of `Iterator` that must be used [INFO] [stdout] --> src/tests/tests.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | db.drain(0..2).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: iterators are lazy and do nothing unless consumed [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused implementer of `Iterator` that must be used [INFO] [stdout] --> src/tests/tests.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | db.drain(1..2).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: iterators are lazy and do nothing unless consumed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused implementer of `Iterator` that must be used [INFO] [stdout] --> src/tests/tests.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 213 | db.drain(1..1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: iterators are lazy and do nothing unless consumed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused implementer of `Iterator` that must be used [INFO] [stdout] --> src/tests/tests.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | db.drain(0..=2).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: iterators are lazy and do nothing unless consumed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tests/tests.rs:331:5 [INFO] [stdout] | [INFO] [stdout] 331 | db.retain(|e| e.get_a().clone() != 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 331 | let _ = db.retain(|e| e.get_a().clone() != 1); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tests/tests.rs:353:5 [INFO] [stdout] | [INFO] [stdout] 353 | remove_file("rollback_test.csv"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 353 | let _ = remove_file("rollback_test.csv"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tests/tests.rs:354:5 [INFO] [stdout] | [INFO] [stdout] 354 | remove_file("rollback_test.changes.csv"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 354 | let _ = remove_file("rollback_test.changes.csv"); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused implementer of `Iterator` that must be used [INFO] [stdout] --> src/tests/tests.rs:409:5 [INFO] [stdout] | [INFO] [stdout] 409 | db.drain(3..=4); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: iterators are lazy and do nothing unless consumed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `airone` (lib test) due to 4 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "499a6e30615573aea0b2b3b27c72c442405629aa82564769eb0b49c6c5d73200", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "499a6e30615573aea0b2b3b27c72c442405629aa82564769eb0b49c6c5d73200", kill_on_drop: false }` [INFO] [stdout] 499a6e30615573aea0b2b3b27c72c442405629aa82564769eb0b49c6c5d73200