[INFO] fetching crate air-interpreter-value 0.1.0... [INFO] checking air-interpreter-value-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate air-interpreter-value 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate air-interpreter-value 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate air-interpreter-value 0.1.0 [INFO] finished tweaking crates.io crate air-interpreter-value 0.1.0 [INFO] tweaked toml for crates.io crate air-interpreter-value 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d660af7540a6c5d368d7bf2213acace902378c814ea5a07cc4681fe7f18a3533 [INFO] running `Command { std: "docker" "start" "-a" "d660af7540a6c5d368d7bf2213acace902378c814ea5a07cc4681fe7f18a3533", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d660af7540a6c5d368d7bf2213acace902378c814ea5a07cc4681fe7f18a3533", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d660af7540a6c5d368d7bf2213acace902378c814ea5a07cc4681fe7f18a3533", kill_on_drop: false }` [INFO] [stdout] d660af7540a6c5d368d7bf2213acace902378c814ea5a07cc4681fe7f18a3533 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cdb8da97f0840faa88eff400271a64db4ac6fef4c042b0d9efc430aa2af0dd92 [INFO] running `Command { std: "docker" "start" "-a" "cdb8da97f0840faa88eff400271a64db4ac6fef4c042b0d9efc430aa2af0dd92", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking air-interpreter-value v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `serde::ser::Serializer` [INFO] [stdout] --> src/value/mod.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub use serde::ser::Serializer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::ser::Serializer` [INFO] [stdout] --> src/value/mod.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub use serde::ser::Serializer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Type` is never constructed [INFO] [stdout] --> src/value/index.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 89 | struct Type<'a>(&'a JValue); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/mod.rs:148:21 [INFO] [stdout] | [INFO] [stdout] 147 | pub fn array_from_iter(into_iter: impl IntoIterator>) -> Self { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | Self::Array(into_iter.into_iter().map(Into::into).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/mod.rs:159:13 [INFO] [stdout] | [INFO] [stdout] 156 | into_iter: impl IntoIterator, impl Into)>, [INFO] [stdout] | ------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | / into_iter [INFO] [stdout] 160 | | .into_iter() [INFO] [stdout] 161 | | .map(|(k, v)| (k.into(), v.into())) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:107:28 [INFO] [stdout] | [INFO] [stdout] 103 | fn visit_map(self, mut visitor: V) -> Result [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | match tri!(visitor.next_key_seed(KeyClassifier)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/from.rs:235:23 [INFO] [stdout] | [INFO] [stdout] 234 | fn from(f: Vec) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | JValue::Array(f.into_iter().map(Into::into).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/from.rs:281:23 [INFO] [stdout] | [INFO] [stdout] 280 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | JValue::Array(iter.into_iter().map(Into::into).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/from.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 296 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | JValue::Object(Rc::new( [INFO] [stdout] 298 | / iter.into_iter() [INFO] [stdout] 299 | | .map(|(k, v)| (k.into(), v.into())) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `air-interpreter-value` (lib) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `Type` is never constructed [INFO] [stdout] --> src/value/index.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 89 | struct Type<'a>(&'a JValue); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/mod.rs:148:21 [INFO] [stdout] | [INFO] [stdout] 147 | pub fn array_from_iter(into_iter: impl IntoIterator>) -> Self { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | Self::Array(into_iter.into_iter().map(Into::into).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/mod.rs:159:13 [INFO] [stdout] | [INFO] [stdout] 156 | into_iter: impl IntoIterator, impl Into)>, [INFO] [stdout] | ------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | / into_iter [INFO] [stdout] 160 | | .into_iter() [INFO] [stdout] 161 | | .map(|(k, v)| (k.into(), v.into())) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:107:28 [INFO] [stdout] | [INFO] [stdout] 103 | fn visit_map(self, mut visitor: V) -> Result [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | match tri!(visitor.next_key_seed(KeyClassifier)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/from.rs:235:23 [INFO] [stdout] | [INFO] [stdout] 234 | fn from(f: Vec) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | JValue::Array(f.into_iter().map(Into::into).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/from.rs:281:23 [INFO] [stdout] | [INFO] [stdout] 280 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | JValue::Array(iter.into_iter().map(Into::into).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/from.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 296 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | JValue::Object(Rc::new( [INFO] [stdout] 298 | / iter.into_iter() [INFO] [stdout] 299 | | .map(|(k, v)| (k.into(), v.into())) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `air-interpreter-value` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "cdb8da97f0840faa88eff400271a64db4ac6fef4c042b0d9efc430aa2af0dd92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cdb8da97f0840faa88eff400271a64db4ac6fef4c042b0d9efc430aa2af0dd92", kill_on_drop: false }` [INFO] [stdout] cdb8da97f0840faa88eff400271a64db4ac6fef4c042b0d9efc430aa2af0dd92