[INFO] fetching crate aifc 0.5.3... [INFO] checking aifc-0.5.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate aifc 0.5.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate aifc 0.5.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate aifc 0.5.3 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate aifc 0.5.3 [INFO] tweaked toml for crates.io crate aifc 0.5.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate aifc 0.5.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2c7f08cc315f8f152ba84c2303a5325f21e5ac013e517811d09756113e7fe1bf [INFO] running `Command { std: "docker" "start" "-a" "2c7f08cc315f8f152ba84c2303a5325f21e5ac013e517811d09756113e7fe1bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2c7f08cc315f8f152ba84c2303a5325f21e5ac013e517811d09756113e7fe1bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c7f08cc315f8f152ba84c2303a5325f21e5ac013e517811d09756113e7fe1bf", kill_on_drop: false }` [INFO] [stdout] 2c7f08cc315f8f152ba84c2303a5325f21e5ac013e517811d09756113e7fe1bf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 156f011fd84e9f18bb4ea58f1a6a872cb1055df75404b4d5b5ab7b6a98e304cd [INFO] running `Command { std: "docker" "start" "-a" "156f011fd84e9f18bb4ea58f1a6a872cb1055df75404b4d5b5ab7b6a98e304cd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking audio-codec-algorithms v0.6.0 [INFO] [stderr] Checking aifc v0.5.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking clap_builder v4.5.11 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aifcreader.rs:374:12 [INFO] [stdout] | [INFO] [stdout] 345 | pub fn new_single_pass(stream: R) -> AifcResult> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | // SeekableRead which can only be seeked forward [INFO] [stdout] 347 | let sread = SeekableRead { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 374 | Ok(AifcReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 375 | | is_single_pass: true, [INFO] [stdout] 376 | | stream: sread, [INFO] [stdout] 377 | | info: None, [INFO] [stdout] ... | [INFO] [stdout] 390 | | ima4_state: [ AdpcmImaState::new(), AdpcmImaState::new() ] [INFO] [stdout] 391 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aifcreader.rs:756:12 [INFO] [stdout] | [INFO] [stdout] 725 | pub fn new(mut stream: R) -> AifcResult> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 728 | let sread = SeekableRead { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 756 | Ok(AifcReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 757 | | is_single_pass: false, [INFO] [stdout] 758 | | stream: sread, [INFO] [stdout] 759 | | info: None, [INFO] [stdout] ... | [INFO] [stdout] 772 | | ima4_state: [ AdpcmImaState::new(), AdpcmImaState::new() ] [INFO] [stdout] 773 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aifcwriter.rs:136:12 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn new(mut stream: W, info: &AifcWriteInfo) -> AifcResult> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | let initial_stream_pos = stream.stream_position()?; [INFO] [stdout] 133 | let mut write = CountingWrite::new(stream); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(AifcWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 137 | | handle: write, [INFO] [stdout] 138 | | [INFO] [stdout] 139 | | info: info.clone(), [INFO] [stdout] ... | [INFO] [stdout] 151 | | ima4_state: [ AdpcmImaState::new(), AdpcmImaState::new() ], [INFO] [stdout] 152 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunks.rs:161:14 [INFO] [stdout] | [INFO] [stdout] 151 | Err(e) => { return Some(Err(e)); } [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | Err(e) => { return Some(Err(e)); } [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | Err(e) => { return Some(Err(e)); } [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | }; [INFO] [stdout] 161 | Some(Ok(Marker { id, position, name })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunks.rs:309:14 [INFO] [stdout] | [INFO] [stdout] 280 | Err(e) => { return Some(Err(e)); } [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 284 | Err(e) => { return Some(Err(e)); } [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | Err(e) => { return Some(Err(e)); } [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | Some(Ok(Comment { timestamp, marker_id, text })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cast.rs:34:34 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn usize_to_u64(value: usize, err: crate::AifcError) -> crate::AifcResult { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | // this should always succeed, unless usize is extended to be 128 bits long [INFO] [stdout] 34 | u64::try_from(value).map_err(|_| err) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aifc` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "156f011fd84e9f18bb4ea58f1a6a872cb1055df75404b4d5b5ab7b6a98e304cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "156f011fd84e9f18bb4ea58f1a6a872cb1055df75404b4d5b5ab7b6a98e304cd", kill_on_drop: false }` [INFO] [stdout] 156f011fd84e9f18bb4ea58f1a6a872cb1055df75404b4d5b5ab7b6a98e304cd