[INFO] fetching crate aeruginous-io 0.8.1... [INFO] checking aeruginous-io-0.8.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate aeruginous-io 0.8.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate aeruginous-io 0.8.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate aeruginous-io 0.8.1 [INFO] finished tweaking crates.io crate aeruginous-io 0.8.1 [INFO] tweaked toml for crates.io crate aeruginous-io 0.8.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b1217a51802bdd7fb3ef533fdc93d97befd6110ba3a8fb3b9aff334ad17ad818 [INFO] running `Command { std: "docker" "start" "-a" "b1217a51802bdd7fb3ef533fdc93d97befd6110ba3a8fb3b9aff334ad17ad818", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b1217a51802bdd7fb3ef533fdc93d97befd6110ba3a8fb3b9aff334ad17ad818", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b1217a51802bdd7fb3ef533fdc93d97befd6110ba3a8fb3b9aff334ad17ad818", kill_on_drop: false }` [INFO] [stdout] b1217a51802bdd7fb3ef533fdc93d97befd6110ba3a8fb3b9aff334ad17ad818 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae65428838ff26a2289c8b27f54dfda5fa488bed38d4a431c0a6ef6920bfa248 [INFO] running `Command { std: "docker" "start" "-a" "ae65428838ff26a2289c8b27f54dfda5fa488bed38d4a431c0a6ef6920bfa248", kill_on_drop: false }` [INFO] [stderr] Checking sysexits v0.8.1 [INFO] [stderr] Checking aeruginous-io v0.8.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reading.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 127 | fn read_loudly(&self, alternative: B) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | self.as_ref().map_or_else( [INFO] [stdout] 129 | || alternative.read_loudly(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reading.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 134 | fn read_silently(&self, alternative: B) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | self.as_ref().map_or_else( [INFO] [stdout] 136 | || alternative.read_silently(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writing.rs:65:15 [INFO] [stdout] | [INFO] [stdout] 64 | fn append_loudly(self, destination: P) -> Result<()> { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | match std::fs::File::options() [INFO] [stdout] | _______________^ [INFO] [stdout] 66 | | .append(true) [INFO] [stdout] 67 | | .create(true) [INFO] [stdout] 68 | | .truncate(false) [INFO] [stdout] 69 | | .open(PathBuf::from(destination)) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writing.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 98 | fn append_silently(self, destination: P) -> Result<()> { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | match std::fs::File::options() [INFO] [stdout] | _______________^ [INFO] [stdout] 100 | | .append(true) [INFO] [stdout] 101 | | .create(true) [INFO] [stdout] 102 | | .truncate(false) [INFO] [stdout] 103 | | .open(PathBuf::from(destination)) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writing.rs:163:15 [INFO] [stdout] | [INFO] [stdout] 162 | fn truncate_loudly(self, destination: P) -> Result<()> { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | match std::fs::File::options() [INFO] [stdout] | _______________^ [INFO] [stdout] 164 | | .append(false) [INFO] [stdout] 165 | | .create(true) [INFO] [stdout] 166 | | .truncate(true) [INFO] [stdout] 167 | | .write(true) [INFO] [stdout] 168 | | .open(PathBuf::from(destination)) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writing.rs:198:15 [INFO] [stdout] | [INFO] [stdout] 197 | fn truncate_silently(self, destination: P) -> Result<()> { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | match std::fs::File::options() [INFO] [stdout] | _______________^ [INFO] [stdout] 199 | | .append(false) [INFO] [stdout] 200 | | .create(true) [INFO] [stdout] 201 | | .truncate(true) [INFO] [stdout] 202 | | .write(true) [INFO] [stdout] 203 | | .open(PathBuf::from(destination)) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writing.rs:334:15 [INFO] [stdout] | [INFO] [stdout] 331 | fn write_loudly(self, mut destination: W) -> Result<()> { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | match destination.write(&bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writing.rs:353:15 [INFO] [stdout] | [INFO] [stdout] 350 | fn write_silently(self, mut destination: W) -> Result<()> { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | match destination.write(&bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reading.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 127 | fn read_loudly(&self, alternative: B) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | self.as_ref().map_or_else( [INFO] [stdout] 129 | || alternative.read_loudly(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reading.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 134 | fn read_silently(&self, alternative: B) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | self.as_ref().map_or_else( [INFO] [stdout] 136 | || alternative.read_silently(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writing.rs:65:15 [INFO] [stdout] | [INFO] [stdout] 64 | fn append_loudly(self, destination: P) -> Result<()> { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | match std::fs::File::options() [INFO] [stdout] | _______________^ [INFO] [stdout] 66 | | .append(true) [INFO] [stdout] 67 | | .create(true) [INFO] [stdout] 68 | | .truncate(false) [INFO] [stdout] 69 | | .open(PathBuf::from(destination)) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writing.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 98 | fn append_silently(self, destination: P) -> Result<()> { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | match std::fs::File::options() [INFO] [stdout] | _______________^ [INFO] [stdout] 100 | | .append(true) [INFO] [stdout] 101 | | .create(true) [INFO] [stdout] 102 | | .truncate(false) [INFO] [stdout] 103 | | .open(PathBuf::from(destination)) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writing.rs:163:15 [INFO] [stdout] | [INFO] [stdout] 162 | fn truncate_loudly(self, destination: P) -> Result<()> { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | match std::fs::File::options() [INFO] [stdout] | _______________^ [INFO] [stdout] 164 | | .append(false) [INFO] [stdout] 165 | | .create(true) [INFO] [stdout] 166 | | .truncate(true) [INFO] [stdout] 167 | | .write(true) [INFO] [stdout] 168 | | .open(PathBuf::from(destination)) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writing.rs:198:15 [INFO] [stdout] | [INFO] [stdout] 197 | fn truncate_silently(self, destination: P) -> Result<()> { [INFO] [stdout] | ---- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | match std::fs::File::options() [INFO] [stdout] | _______________^ [INFO] [stdout] 199 | | .append(false) [INFO] [stdout] 200 | | .create(true) [INFO] [stdout] 201 | | .truncate(true) [INFO] [stdout] 202 | | .write(true) [INFO] [stdout] 203 | | .open(PathBuf::from(destination)) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writing.rs:334:15 [INFO] [stdout] | [INFO] [stdout] 331 | fn write_loudly(self, mut destination: W) -> Result<()> { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | match destination.write(&bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writing.rs:353:15 [INFO] [stdout] | [INFO] [stdout] 350 | fn write_silently(self, mut destination: W) -> Result<()> { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | match destination.write(&bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aeruginous-io` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `aeruginous-io` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "ae65428838ff26a2289c8b27f54dfda5fa488bed38d4a431c0a6ef6920bfa248", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae65428838ff26a2289c8b27f54dfda5fa488bed38d4a431c0a6ef6920bfa248", kill_on_drop: false }` [INFO] [stdout] ae65428838ff26a2289c8b27f54dfda5fa488bed38d4a431c0a6ef6920bfa248