[INFO] fetching crate aeruginous 3.7.17... [INFO] checking aeruginous-3.7.17 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate aeruginous 3.7.17 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate aeruginous 3.7.17 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate aeruginous 3.7.17 [INFO] finished tweaking crates.io crate aeruginous 3.7.17 [INFO] tweaked toml for crates.io crate aeruginous 3.7.17 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate aeruginous 3.7.17 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4eca803dd5153b047e2fc1efde196d1d91601888b2e9754992f20e3da8f775ab [INFO] running `Command { std: "docker" "start" "-a" "4eca803dd5153b047e2fc1efde196d1d91601888b2e9754992f20e3da8f775ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4eca803dd5153b047e2fc1efde196d1d91601888b2e9754992f20e3da8f775ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4eca803dd5153b047e2fc1efde196d1d91601888b2e9754992f20e3da8f775ab", kill_on_drop: false }` [INFO] [stdout] 4eca803dd5153b047e2fc1efde196d1d91601888b2e9754992f20e3da8f775ab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f005adb0f77a6e6373b59e2719184085a2c0c13ea14f183b98f22d56d0625a77 [INFO] running `Command { std: "docker" "start" "-a" "f005adb0f77a6e6373b59e2719184085a2c0c13ea14f183b98f22d56d0625a77", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling cc v1.1.6 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking winnow v0.6.16 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking clap_builder v4.5.11 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking sysexits v0.8.1 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking aeruginous-io v0.8.1 [INFO] [stderr] Compiling libz-sys v1.1.18 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling clap_derive v4.5.11 [INFO] [stderr] Checking clap v4.5.11 [INFO] [stderr] Checking toml_datetime v0.6.7 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking quick-xml v0.36.1 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking toml_edit v0.22.17 [INFO] [stderr] Checking toml v0.8.16 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking cargo-lock v9.0.0 [INFO] [stderr] Checking aeruginous v3.7.17 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/changelog/comment_changes.rs:242:29 [INFO] [stdout] | [INFO] [stdout] 241 | |config| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | config.get_string("user.name").map_or_else( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/changelog/ronlog.rs:83:23 [INFO] [stdout] | [INFO] [stdout] 79 | const fn new(introduction: Option, references: References) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | sections: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/changelog/ronlog.rs:385:12 [INFO] [stdout] | [INFO] [stdout] 371 | mut changes: Fragment, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 374 | references: Option, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 375 | ) -> sysexits::Result { [INFO] [stdout] 376 | let mut references = references.unwrap_or_default(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 385 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 386 | | references, [INFO] [stdout] 387 | | version: Version::from_str(version)?, [INFO] [stdout] 388 | | released: Local::now(), [INFO] [stdout] 389 | | introduction, [INFO] [stdout] 390 | | changes, [INFO] [stdout] 391 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern/io_processor.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 161 | input: impl ReadFile, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | output: impl PatternWriter, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Box::new(self(input.read()?)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern/writer.rs:175:15 [INFO] [stdout] | [INFO] [stdout] 170 | buffer: Box, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | match File::options() [INFO] [stdout] | _______________^ [INFO] [stdout] 176 | | .append(append) [INFO] [stdout] 177 | | .create(true) [INFO] [stdout] 178 | | .write(true) [INFO] [stdout] 179 | | .truncate(truncate) [INFO] [stdout] 180 | | .open(self) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits/prefer.rs:46:59 [INFO] [stdout] | [INFO] [stdout] 46 | .map_or_else(|| (*self).clone(), |value| Some(value.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aeruginous` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/changelog/comment_changes.rs:242:29 [INFO] [stdout] | [INFO] [stdout] 241 | |config| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | config.get_string("user.name").map_or_else( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/changelog/ronlog.rs:83:23 [INFO] [stdout] | [INFO] [stdout] 79 | const fn new(introduction: Option, references: References) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | sections: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/changelog/ronlog.rs:385:12 [INFO] [stdout] | [INFO] [stdout] 371 | mut changes: Fragment, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 374 | references: Option, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 375 | ) -> sysexits::Result { [INFO] [stdout] 376 | let mut references = references.unwrap_or_default(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 385 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 386 | | references, [INFO] [stdout] 387 | | version: Version::from_str(version)?, [INFO] [stdout] 388 | | released: Local::now(), [INFO] [stdout] 389 | | introduction, [INFO] [stdout] 390 | | changes, [INFO] [stdout] 391 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern/io_processor.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 161 | input: impl ReadFile, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | output: impl PatternWriter, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Box::new(self(input.read()?)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern/writer.rs:175:15 [INFO] [stdout] | [INFO] [stdout] 170 | buffer: Box, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | match File::options() [INFO] [stdout] | _______________^ [INFO] [stdout] 176 | | .append(append) [INFO] [stdout] 177 | | .create(true) [INFO] [stdout] 178 | | .write(true) [INFO] [stdout] 179 | | .truncate(truncate) [INFO] [stdout] 180 | | .open(self) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits/prefer.rs:46:59 [INFO] [stdout] | [INFO] [stdout] 46 | .map_or_else(|| (*self).clone(), |value| Some(value.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aeruginous` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "f005adb0f77a6e6373b59e2719184085a2c0c13ea14f183b98f22d56d0625a77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f005adb0f77a6e6373b59e2719184085a2c0c13ea14f183b98f22d56d0625a77", kill_on_drop: false }` [INFO] [stdout] f005adb0f77a6e6373b59e2719184085a2c0c13ea14f183b98f22d56d0625a77