[INFO] fetching crate aeronet_proto 0.7.0-alpha.2... [INFO] checking aeronet_proto-0.7.0-alpha.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate aeronet_proto 0.7.0-alpha.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate aeronet_proto 0.7.0-alpha.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate aeronet_proto 0.7.0-alpha.2 [INFO] finished tweaking crates.io crate aeronet_proto 0.7.0-alpha.2 [INFO] tweaked toml for crates.io crate aeronet_proto 0.7.0-alpha.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 144 packages to latest compatible versions [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding generic-array v0.12.4 (latest: v1.1.0) [INFO] [stderr] Adding num v0.2.1 (latest: v0.4.3) [INFO] [stderr] Adding num-complex v0.2.4 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.2.4 (latest: v0.4.2) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e3151f3b7f9e335d53a875aaac993afaa0c48dd9cc31a673297691eb1cbc664d [INFO] running `Command { std: "docker" "start" "-a" "e3151f3b7f9e335d53a875aaac993afaa0c48dd9cc31a673297691eb1cbc664d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e3151f3b7f9e335d53a875aaac993afaa0c48dd9cc31a673297691eb1cbc664d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3151f3b7f9e335d53a875aaac993afaa0c48dd9cc31a673297691eb1cbc664d", kill_on_drop: false }` [INFO] [stdout] e3151f3b7f9e335d53a875aaac993afaa0c48dd9cc31a673297691eb1cbc664d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1eeb3b381018f6fda34fc4bba123add81760567d6d06e31ce30d99be11368425 [INFO] running `Command { std: "docker" "start" "-a" "1eeb3b381018f6fda34fc4bba123add81760567d6d06e31ce30d99be11368425", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking octs v0.4.2 [INFO] [stderr] Checking terrors v0.3.0 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking ringbuf v0.4.4 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling datasize_derive v0.2.15 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling derive_arbitrary v1.3.2 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking datasize v0.2.15 [INFO] [stderr] Checking arbitrary v1.3.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking aeronet v0.7.0-alpha.2 [INFO] [stderr] Checking aeronet_proto v0.7.0-alpha.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/limit.rs:354:12 [INFO] [stdout] | [INFO] [stdout] 352 | let consume_a = self.a.try_consume(n)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | let consume_b = self.b.try_consume(n)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | Ok(ConsumeMinOf { [INFO] [stdout] | ____________^ [INFO] [stdout] 355 | | consume_a, [INFO] [stdout] 356 | | consume_b, [INFO] [stdout] 357 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/msg/mod.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 103 | fn decode(mut src: impl Read) -> Result> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let payload = src.read_next(payload_len)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | Ok(Self { header, payload }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/msg/send.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 80 | msg: impl Into, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let msg = msg.into(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let iter = msg.byte_chunks(self.max_payload_len); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(iter.enumerate().rev().map(move |(index, payload)| { [INFO] [stdout] | ____________^ [INFO] [stdout] 100 | | // do this inside the iterator, since we now know [INFO] [stdout] 101 | | // that we have at least at least 1 item in this iterator [INFO] [stdout] 102 | | // and otherwise, `iter_len` would be 0, so `iter_len - 1` [INFO] [stdout] ... | [INFO] [stdout] 113 | | (marker, payload) [INFO] [stdout] 114 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seq/buf.rs:62:22 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn new_from_fn(cb: impl FnMut(usize) -> T) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | indices: Box::new([EMPTY; N]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seq/buf.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn new_from_fn(cb: impl FnMut(usize) -> T) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | data: Box::new(array::from_fn(cb)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/mod.rs:252:32 [INFO] [stdout] | [INFO] [stdout] 252 | sent_msgs: AHashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/mod.rs:277:27 [INFO] [stdout] | [INFO] [stdout] 277 | kind: match kind { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 278 | | LaneKind::UnreliableUnordered => RecvLaneKind::UnreliableUnordered, [INFO] [stdout] 279 | | LaneKind::UnreliableSequenced => RecvLaneKind::UnreliableSequenced { [INFO] [stdout] 280 | | pending_seq: MessageSeq::ZERO, [INFO] [stdout] ... | [INFO] [stdout] 289 | | }, [INFO] [stdout] 290 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/recv.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 84 | packet: impl Into, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let mut packet: Bytes = packet.into(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let span = trace_span!("recv", packet = header.seq.0 .0); [INFO] [stdout] | ---- --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let _span = span.enter(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let acks = Self::recv_acks( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 117 | | acks, [INFO] [stdout] 118 | | RecvMessages { [INFO] [stdout] 119 | | recv_lanes: &mut self.recv_lanes, [INFO] [stdout] ... | [INFO] [stdout] 122 | | }, [INFO] [stdout] 123 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/recv.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 132 | acked_seqs: impl Iterator + 'session, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | ) -> impl Iterator + 'session { [INFO] [stdout] 134 | / acked_seqs [INFO] [stdout] 135 | | // we now know that our packet with sequence `seq` was acked by the peer [INFO] [stdout] 136 | | // let's find what fragments that packet contained when we flushed it out [INFO] [stdout] 137 | | .filter_map(move |seq| { [INFO] [stdout] ... | [INFO] [stdout] 155 | | Box::into_iter(packet.frags) [INFO] [stdout] 156 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/recv.rs:221:12 [INFO] [stdout] | [INFO] [stdout] 210 | let frag = self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | Ok(lane [INFO] [stdout] | ____________^ [INFO] [stdout] 222 | | .frags [INFO] [stdout] 223 | | .reassemble( [INFO] [stdout] 224 | | self.now, [INFO] [stdout] ... | [INFO] [stdout] 233 | | .into_iter() [INFO] [stdout] 234 | | .flatten()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/recv.rs:231:17 [INFO] [stdout] | [INFO] [stdout] 230 | .map(|msg| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | Self::recv_on_lane(lane, msg, frag.header.msg_seq).map(move |msg| (msg, lane_index)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/recv.rs:242:9 [INFO] [stdout] | [INFO] [stdout] 239 | msg: Bytes, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | / match &mut lane.kind { [INFO] [stdout] 243 | | RecvLaneKind::UnreliableUnordered => { [INFO] [stdout] 244 | | // always just return the message [INFO] [stdout] 245 | | Either::Left(Some(msg)) [INFO] [stdout] ... | [INFO] [stdout] 295 | | } [INFO] [stdout] 296 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/send.rs:135:28 [INFO] [stdout] | [INFO] [stdout] 135 | .map_err(|err| OneOf::from(err).broaden())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/send.rs:155:30 [INFO] [stdout] | [INFO] [stdout] 154 | .map(|(marker, payload)| { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | Some(SentFragment { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 156 | | marker, [INFO] [stdout] 157 | | payload, [INFO] [stdout] 158 | | sent_at: now, [INFO] [stdout] 159 | | next_flush_at: now, [INFO] [stdout] 160 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/send.rs:171:32 [INFO] [stdout] | [INFO] [stdout] 171 | .map_err(|err| OneOf::from(err).broaden()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/send.rs:173:31 [INFO] [stdout] | [INFO] [stdout] 173 | res.map_err(|err| OneOf::from(err).broaden()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aeronet_proto` (lib) due to 17 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/limit.rs:354:12 [INFO] [stdout] | [INFO] [stdout] 352 | let consume_a = self.a.try_consume(n)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | let consume_b = self.b.try_consume(n)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | Ok(ConsumeMinOf { [INFO] [stdout] | ____________^ [INFO] [stdout] 355 | | consume_a, [INFO] [stdout] 356 | | consume_b, [INFO] [stdout] 357 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/msg/mod.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 103 | fn decode(mut src: impl Read) -> Result> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let payload = src.read_next(payload_len)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | Ok(Self { header, payload }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/msg/send.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 80 | msg: impl Into, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let msg = msg.into(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let iter = msg.byte_chunks(self.max_payload_len); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(iter.enumerate().rev().map(move |(index, payload)| { [INFO] [stdout] | ____________^ [INFO] [stdout] 100 | | // do this inside the iterator, since we now know [INFO] [stdout] 101 | | // that we have at least at least 1 item in this iterator [INFO] [stdout] 102 | | // and otherwise, `iter_len` would be 0, so `iter_len - 1` [INFO] [stdout] ... | [INFO] [stdout] 113 | | (marker, payload) [INFO] [stdout] 114 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seq/buf.rs:62:22 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn new_from_fn(cb: impl FnMut(usize) -> T) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | indices: Box::new([EMPTY; N]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seq/buf.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn new_from_fn(cb: impl FnMut(usize) -> T) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | data: Box::new(array::from_fn(cb)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/mod.rs:252:32 [INFO] [stdout] | [INFO] [stdout] 252 | sent_msgs: AHashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/mod.rs:277:27 [INFO] [stdout] | [INFO] [stdout] 277 | kind: match kind { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 278 | | LaneKind::UnreliableUnordered => RecvLaneKind::UnreliableUnordered, [INFO] [stdout] 279 | | LaneKind::UnreliableSequenced => RecvLaneKind::UnreliableSequenced { [INFO] [stdout] 280 | | pending_seq: MessageSeq::ZERO, [INFO] [stdout] ... | [INFO] [stdout] 289 | | }, [INFO] [stdout] 290 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/recv.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 84 | packet: impl Into, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let mut packet: Bytes = packet.into(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let span = trace_span!("recv", packet = header.seq.0 .0); [INFO] [stdout] | ---- --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let _span = span.enter(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let acks = Self::recv_acks( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 117 | | acks, [INFO] [stdout] 118 | | RecvMessages { [INFO] [stdout] 119 | | recv_lanes: &mut self.recv_lanes, [INFO] [stdout] ... | [INFO] [stdout] 122 | | }, [INFO] [stdout] 123 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/recv.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 132 | acked_seqs: impl Iterator + 'session, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | ) -> impl Iterator + 'session { [INFO] [stdout] 134 | / acked_seqs [INFO] [stdout] 135 | | // we now know that our packet with sequence `seq` was acked by the peer [INFO] [stdout] 136 | | // let's find what fragments that packet contained when we flushed it out [INFO] [stdout] 137 | | .filter_map(move |seq| { [INFO] [stdout] ... | [INFO] [stdout] 155 | | Box::into_iter(packet.frags) [INFO] [stdout] 156 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/recv.rs:221:12 [INFO] [stdout] | [INFO] [stdout] 210 | let frag = self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | Ok(lane [INFO] [stdout] | ____________^ [INFO] [stdout] 222 | | .frags [INFO] [stdout] 223 | | .reassemble( [INFO] [stdout] 224 | | self.now, [INFO] [stdout] ... | [INFO] [stdout] 233 | | .into_iter() [INFO] [stdout] 234 | | .flatten()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/recv.rs:231:17 [INFO] [stdout] | [INFO] [stdout] 230 | .map(|msg| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | Self::recv_on_lane(lane, msg, frag.header.msg_seq).map(move |msg| (msg, lane_index)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/recv.rs:242:9 [INFO] [stdout] | [INFO] [stdout] 239 | msg: Bytes, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | / match &mut lane.kind { [INFO] [stdout] 243 | | RecvLaneKind::UnreliableUnordered => { [INFO] [stdout] 244 | | // always just return the message [INFO] [stdout] 245 | | Either::Left(Some(msg)) [INFO] [stdout] ... | [INFO] [stdout] 295 | | } [INFO] [stdout] 296 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/send.rs:135:28 [INFO] [stdout] | [INFO] [stdout] 135 | .map_err(|err| OneOf::from(err).broaden())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/send.rs:155:30 [INFO] [stdout] | [INFO] [stdout] 154 | .map(|(marker, payload)| { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | Some(SentFragment { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 156 | | marker, [INFO] [stdout] 157 | | payload, [INFO] [stdout] 158 | | sent_at: now, [INFO] [stdout] 159 | | next_flush_at: now, [INFO] [stdout] 160 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/send.rs:171:32 [INFO] [stdout] | [INFO] [stdout] 171 | .map_err(|err| OneOf::from(err).broaden()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session/send.rs:173:31 [INFO] [stdout] | [INFO] [stdout] 173 | res.map_err(|err| OneOf::from(err).broaden()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `aeronet_proto` (lib test) due to 17 previous errors [INFO] running `Command { std: "docker" "inspect" "1eeb3b381018f6fda34fc4bba123add81760567d6d06e31ce30d99be11368425", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1eeb3b381018f6fda34fc4bba123add81760567d6d06e31ce30d99be11368425", kill_on_drop: false }` [INFO] [stdout] 1eeb3b381018f6fda34fc4bba123add81760567d6d06e31ce30d99be11368425