[INFO] fetching crate advocat 3.0.0... [INFO] checking advocat-3.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate advocat 3.0.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate advocat 3.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate advocat 3.0.0 [INFO] finished tweaking crates.io crate advocat 3.0.0 [INFO] tweaked toml for crates.io crate advocat 3.0.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate advocat 3.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bb9130646daf276614e2fe1a29a443608603fefe75dad56622d0db13acebf643 [INFO] running `Command { std: "docker" "start" "-a" "bb9130646daf276614e2fe1a29a443608603fefe75dad56622d0db13acebf643", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bb9130646daf276614e2fe1a29a443608603fefe75dad56622d0db13acebf643", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb9130646daf276614e2fe1a29a443608603fefe75dad56622d0db13acebf643", kill_on_drop: false }` [INFO] [stdout] bb9130646daf276614e2fe1a29a443608603fefe75dad56622d0db13acebf643 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 763ec260f45c7ec7dbaa17e03f0952d3a0d4c416439c806e6c64623446413e3f [INFO] running `Command { std: "docker" "start" "-a" "763ec260f45c7ec7dbaa17e03f0952d3a0d4c416439c806e6c64623446413e3f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.116 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling crc32fast v1.3.1 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling curl v0.4.42 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking diff v0.1.12 [INFO] [stderr] Checking exitcode v1.1.2 [INFO] [stderr] Checking configparser v3.0.0 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling libz-sys v1.1.3 [INFO] [stderr] Compiling openssl-sys v0.9.72 [INFO] [stderr] Compiling curl-sys v0.4.52+curl-7.81.0 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking termion v1.5.6 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking zip v0.5.13 [INFO] [stderr] Checking advocat v3.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/problem.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Problem { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 11 | pub id: String, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `Problem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fetch/connection_manager.rs:73:41 [INFO] [stdout] | [INFO] [stdout] 69 | let mut file = fs::File::create(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | .write_function(move |data| file.write(data).or(Ok(0)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing/test.rs:90:20 [INFO] [stdout] | [INFO] [stdout] 35 | let process = process::Command::new(binary) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let mut process = match process { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Ok(p) => p, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | error: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advocat` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/test_utils.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 12 | impl SelfCleaningTmp { [INFO] [stdout] | -------------------- associated function in this implementation [INFO] [stdout] 13 | pub fn new(module: &str, test_name: &str) -> SelfCleaningTmp { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fetch/connection_manager.rs:73:41 [INFO] [stdout] | [INFO] [stdout] 69 | let mut file = fs::File::create(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | .write_function(move |data| file.write(data).or(Ok(0)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing/test.rs:90:20 [INFO] [stdout] | [INFO] [stdout] 35 | let process = process::Command::new(binary) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let mut process = match process { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Ok(p) => p, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | error: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advocat` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "763ec260f45c7ec7dbaa17e03f0952d3a0d4c416439c806e6c64623446413e3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "763ec260f45c7ec7dbaa17e03f0952d3a0d4c416439c806e6c64623446413e3f", kill_on_drop: false }` [INFO] [stdout] 763ec260f45c7ec7dbaa17e03f0952d3a0d4c416439c806e6c64623446413e3f