[INFO] fetching crate ads_client 1.4.1... [INFO] checking ads_client-1.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ads_client 1.4.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ads_client 1.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ads_client 1.4.1 [INFO] finished tweaking crates.io crate ads_client 1.4.1 [INFO] tweaked toml for crates.io crate ads_client 1.4.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate ads_client 1.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 129976e62883763f1fe61ba1130d58b83d55b742fcebe829e7f5ccc2eb26bb06 [INFO] running `Command { std: "docker" "start" "-a" "129976e62883763f1fe61ba1130d58b83d55b742fcebe829e7f5ccc2eb26bb06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "129976e62883763f1fe61ba1130d58b83d55b742fcebe829e7f5ccc2eb26bb06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "129976e62883763f1fe61ba1130d58b83d55b742fcebe829e7f5ccc2eb26bb06", kill_on_drop: false }` [INFO] [stdout] 129976e62883763f1fe61ba1130d58b83d55b742fcebe829e7f5ccc2eb26bb06 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9dea1ee86f582fec41d1b778e25d5d9edeebdcb241d190ee5cf2d2c1408363fd [INFO] running `Command { std: "docker" "start" "-a" "9dea1ee86f582fec41d1b778e25d5d9edeebdcb241d190ee5cf2d2c1408363fd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking destructure_traitobject v0.2.0 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking smallvec v1.12.0 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking unsafe-any-ors v1.0.0 [INFO] [stderr] Checking once_cell v1.14.0 [INFO] [stderr] Checking iana-time-zone v0.1.59 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking typemap-ors v1.0.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking arc-swap v1.6.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling tokio v1.21.0 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking thread-id v4.2.1 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Compiling num_enum_derive v0.7.2 [INFO] [stderr] Checking num_enum v0.7.2 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking log4rs v1.2.0 [INFO] [stderr] Checking ads_client v1.4.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:403:61 [INFO] [stdout] | [INFO] [stdout] 403 | user_data : user_data.and_then(|arc_bytes| Some(Arc::clone(arc_bytes)) ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:403:61 [INFO] [stdout] | [INFO] [stdout] 403 | user_data : user_data.and_then(|arc_bytes| Some(Arc::clone(arc_bytes)) ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ads_client` (lib) due to 5 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:598:70 [INFO] [stdout] | [INFO] [stdout] 598 | ... .and_then(| hdl : &mut NotHandle | Some( (hdl.callback, hdl.user_data.clone()) ) ); // Return callback and user data [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:607:29 [INFO] [stdout] | [INFO] [stdout] 602 | _cb_and_data.and_then(|(callback, user_data)| { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 603 | let payload = Bytes::from(data.slice(stamp_header_offset..stamp_header_offset + not_sample.sample_size as usize)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 607 | / rt.spawn(async move { [INFO] [stdout] 608 | | callback(not_sample.not_hdl, stamp_header.timestamp, payload, user_data); [INFO] [stdout] 609 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command_cleaner.rs:20:35 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(interval : u64, timeout : u64, handle_register : Arc>>) -> CommandCleaner { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | CommandCleaner { [INFO] [stdout] 20 | waker : None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:598:70 [INFO] [stdout] | [INFO] [stdout] 598 | ... .and_then(| hdl : &mut NotHandle | Some( (hdl.callback, hdl.user_data.clone()) ) ); // Return callback and user data [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:607:29 [INFO] [stdout] | [INFO] [stdout] 602 | _cb_and_data.and_then(|(callback, user_data)| { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 603 | let payload = Bytes::from(data.slice(stamp_header_offset..stamp_header_offset + not_sample.sample_size as usize)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 607 | / rt.spawn(async move { [INFO] [stdout] 608 | | callback(not_sample.not_hdl, stamp_header.timestamp, payload, user_data); [INFO] [stdout] 609 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ads_client` (lib test) due to 5 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command_cleaner.rs:20:35 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(interval : u64, timeout : u64, handle_register : Arc>>) -> CommandCleaner { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | CommandCleaner { [INFO] [stdout] 20 | waker : None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "9dea1ee86f582fec41d1b778e25d5d9edeebdcb241d190ee5cf2d2c1408363fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9dea1ee86f582fec41d1b778e25d5d9edeebdcb241d190ee5cf2d2c1408363fd", kill_on_drop: false }` [INFO] [stdout] 9dea1ee86f582fec41d1b778e25d5d9edeebdcb241d190ee5cf2d2c1408363fd