[INFO] fetching crate ads1x1x 0.2.2... [INFO] checking ads1x1x-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ads1x1x 0.2.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ads1x1x 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ads1x1x 0.2.2 [INFO] finished tweaking crates.io crate ads1x1x 0.2.2 [INFO] tweaked toml for crates.io crate ads1x1x 0.2.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate ads1x1x 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a37936e62ebb3b151324bc466f859d85e6e57b761f573e205ab803181fbd1851 [INFO] running `Command { std: "docker" "start" "-a" "a37936e62ebb3b151324bc466f859d85e6e57b761f573e205ab803181fbd1851", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a37936e62ebb3b151324bc466f859d85e6e57b761f573e205ab803181fbd1851", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a37936e62ebb3b151324bc466f859d85e6e57b761f573e205ab803181fbd1851", kill_on_drop: false }` [INFO] [stdout] a37936e62ebb3b151324bc466f859d85e6e57b761f573e205ab803181fbd1851 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3c10994e6a192f5bdd90f47caa2565763d0fba1e9b27ea9d7d9b04dbeade7429 [INFO] running `Command { std: "docker" "start" "-a" "3c10994e6a192f5bdd90f47caa2565763d0fba1e9b27ea9d7d9b04dbeade7429", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling semver v1.0.3 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking nb v1.0.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking nb v0.1.3 [INFO] [stderr] Checking embedded-hal v0.2.5 [INFO] [stderr] Checking embedded-hal-mock v0.7.2 [INFO] [stderr] Checking ads1x1x v0.2.2 (/opt/rustwide/workdir) [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/construction.rs:19:28 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn $create(i2c: I2C, address: SlaveAddr) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Ads1x1x { [INFO] [stdout] 19 | iface: I2cInterface { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 20 | | i2c, [INFO] [stdout] 21 | | address: address.addr(DEVICE_BASE_ADDRESS), [INFO] [stdout] 22 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] ... [INFO] [stdout] 41 | impl_new_destroy!(Ads1013, new_ads1013, destroy_ads1013, ic::Resolution12Bit); [INFO] [stdout] | ----------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `impl_new_destroy` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/construction.rs:19:28 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn $create(i2c: I2C, address: SlaveAddr) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Ads1x1x { [INFO] [stdout] 19 | iface: I2cInterface { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 20 | | i2c, [INFO] [stdout] 21 | | address: address.addr(DEVICE_BASE_ADDRESS), [INFO] [stdout] 22 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] ... [INFO] [stdout] 42 | impl_new_destroy!(Ads1113, new_ads1113, destroy_ads1113, ic::Resolution16Bit); [INFO] [stdout] | ----------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_new_destroy` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/construction.rs:19:28 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn $create(i2c: I2C, address: SlaveAddr) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Ads1x1x { [INFO] [stdout] 19 | iface: I2cInterface { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 20 | | i2c, [INFO] [stdout] 21 | | address: address.addr(DEVICE_BASE_ADDRESS), [INFO] [stdout] 22 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] ... [INFO] [stdout] 43 | impl_new_destroy!(Ads1014, new_ads1014, destroy_ads1014, ic::Resolution12Bit); [INFO] [stdout] | ----------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_new_destroy` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/construction.rs:19:28 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn $create(i2c: I2C, address: SlaveAddr) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Ads1x1x { [INFO] [stdout] 19 | iface: I2cInterface { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 20 | | i2c, [INFO] [stdout] 21 | | address: address.addr(DEVICE_BASE_ADDRESS), [INFO] [stdout] 22 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] ... [INFO] [stdout] 44 | impl_new_destroy!(Ads1114, new_ads1114, destroy_ads1114, ic::Resolution16Bit); [INFO] [stdout] | ----------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_new_destroy` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/construction.rs:19:28 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn $create(i2c: I2C, address: SlaveAddr) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Ads1x1x { [INFO] [stdout] 19 | iface: I2cInterface { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 20 | | i2c, [INFO] [stdout] 21 | | address: address.addr(DEVICE_BASE_ADDRESS), [INFO] [stdout] 22 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] ... [INFO] [stdout] 45 | impl_new_destroy!(Ads1015, new_ads1015, destroy_ads1015, ic::Resolution12Bit); [INFO] [stdout] | ----------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_new_destroy` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/construction.rs:19:28 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn $create(i2c: I2C, address: SlaveAddr) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Ads1x1x { [INFO] [stdout] 19 | iface: I2cInterface { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 20 | | i2c, [INFO] [stdout] 21 | | address: address.addr(DEVICE_BASE_ADDRESS), [INFO] [stdout] 22 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] ... [INFO] [stdout] 46 | impl_new_destroy!(Ads1115, new_ads1115, destroy_ads1115, ic::Resolution16Bit); [INFO] [stdout] | ----------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_new_destroy` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/devices/mode/continuous.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 17 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | Ok(Ads1x1x { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | iface: self.iface, [INFO] [stdout] 24 | | config: self.config, [INFO] [stdout] 25 | | fsr: self.fsr, [INFO] [stdout] ... | [INFO] [stdout] 29 | | _mode: PhantomData, [INFO] [stdout] 30 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/devices/mode/oneshot.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 16 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Ok(Ads1x1x { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | iface: self.iface, [INFO] [stdout] 23 | | config: self.config, [INFO] [stdout] 24 | | fsr: self.fsr, [INFO] [stdout] ... | [INFO] [stdout] 28 | | _mode: PhantomData, [INFO] [stdout] 29 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ads1x1x` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "3c10994e6a192f5bdd90f47caa2565763d0fba1e9b27ea9d7d9b04dbeade7429", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c10994e6a192f5bdd90f47caa2565763d0fba1e9b27ea9d7d9b04dbeade7429", kill_on_drop: false }` [INFO] [stdout] 3c10994e6a192f5bdd90f47caa2565763d0fba1e9b27ea9d7d9b04dbeade7429