[INFO] fetching crate adder-codec-core 0.3.4... [INFO] checking adder-codec-core-0.3.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate adder-codec-core 0.3.4 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate adder-codec-core 0.3.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate adder-codec-core 0.3.4 [INFO] finished tweaking crates.io crate adder-codec-core 0.3.4 [INFO] tweaked toml for crates.io crate adder-codec-core 0.3.4 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 59 packages to latest compatible versions [INFO] [stderr] Adding bitstream-io v1.10.0 (latest: v2.5.3) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hashbrown v0.13.2 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding ndarray v0.15.6 (latest: v0.16.1) [INFO] [stderr] Adding priority-queue v1.4.0 (latest: v2.1.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c705fe886d00a34b1d44ab3b56c3f44c66d3ad9dd82276da158a5b125cb3868a [INFO] running `Command { std: "docker" "start" "-a" "c705fe886d00a34b1d44ab3b56c3f44c66d3ad9dd82276da158a5b125cb3868a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c705fe886d00a34b1d44ab3b56c3f44c66d3ad9dd82276da158a5b125cb3868a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c705fe886d00a34b1d44ab3b56c3f44c66d3ad9dd82276da158a5b125cb3868a", kill_on_drop: false }` [INFO] [stdout] c705fe886d00a34b1d44ab3b56c3f44c66d3ad9dd82276da158a5b125cb3868a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e734696e537557f67432ae6abb544c1fb4efefd333737a6a837d05c8166fccb2 [INFO] running `Command { std: "docker" "start" "-a" "e734696e537557f67432ae6abb544c1fb4efefd333737a6a837d05c8166fccb2", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling rustfft v6.2.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Compiling priority-queue v1.4.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking bitstream-io v1.10.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking fenwick v2.0.1 [INFO] [stderr] Compiling seq-macro v0.3.5 [INFO] [stderr] Checking numquant v0.2.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking primal-check v0.3.4 [INFO] [stderr] Checking transpose v0.2.3 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Compiling nestify v0.3.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking arithmetic-coding-core-adder-dep v0.3.0 [INFO] [stderr] Checking arithmetic-coding-adder-dep v0.3.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rustdct v0.7.1 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking adder-codec-core v0.3.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `AddAssign` and `Add` [INFO] [stdout] --> src/codec/compressed/stream.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | use std::ops::{Add, AddAssign}; [INFO] [stdout] | ^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::codec::rate_controller::CrfParameters` [INFO] [stdout] --> src/codec/compressed/stream.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use crate::codec::rate_controller::CrfParameters; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AddAssign` and `Add` [INFO] [stdout] --> src/codec/compressed/stream.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | use std::ops::{Add, AddAssign}; [INFO] [stdout] | ^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::codec::rate_controller::CrfParameters` [INFO] [stdout] --> src/codec/compressed/stream.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use crate::codec::rate_controller::CrfParameters; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/codec/compressed/stream.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | mut stream: Arc>>, [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `written_bytes_rx` [INFO] [stdout] --> src/codec/encoder.rs:455:32 [INFO] [stdout] | [INFO] [stdout] 455 | let (written_bytes_tx, written_bytes_rx) = std::sync::mpsc::channel(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_written_bytes_rx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Compressed` is never constructed [INFO] [stdout] --> src/codec/compressed/source_model/event_structure/event_adu.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 37 | pub enum AduState { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] 38 | Compressed, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AduState` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `setup_encoded_raw_interleaved` is never used [INFO] [stdout] --> src/codec/decoder.rs:330:8 [INFO] [stdout] | [INFO] [stdout] 330 | fn setup_encoded_raw_interleaved(codec_version: u8) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `HeaderExtension` is never used [INFO] [stdout] --> src/codec/header.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | pub(crate) trait HeaderExtension {} [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:494:8 [INFO] [stdout] | [INFO] [stdout] 470 | let mut bufreader = BufReader::new(File::open(file_path)?); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 471 | let compression = RawInput::new(); [INFO] [stdout] 472 | let mut bitreader = BitReader::endian(bufreader, BigEndian); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 475 | let stream = match Decoder::new_raw(compression, &mut bitreader) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 476 | Ok(reader) => reader, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 482 | let compression = CompressedInput::new(0, 0, 0); // TODO: temporary args. Need to refactor. [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 490 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 494 | Ok((stream, bitreader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/compressed/stream.rs:132:21 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(meta: CodecMetadata, writer: W) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let adu = EventAdu::new(meta.plane, 0, meta.ref_interval, meta.adu_interval as usize); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let (written_bytes_tx, written_bytes_rx) = std::sync::mpsc::channel(); [INFO] [stdout] | ---------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | [INFO] [stdout] 111 | let stream_lock = RwLock::new(BitWriter::endian(writer, BigEndian)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let stream_lock_arc = Arc::new(stream_lock); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let stream_lock_arc_clone = stream_lock_arc.clone(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | [INFO] [stdout] 115 | let last_message_written = Arc::new(RwLock::new(0)); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let last_message_written_clone = last_message_written.clone(); [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | stream: Some(stream_lock_arc), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/compressed/stream.rs:135:31 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(meta: CodecMetadata, writer: W) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let adu = EventAdu::new(meta.plane, 0, meta.ref_interval, meta.adu_interval as usize); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let (written_bytes_tx, written_bytes_rx) = std::sync::mpsc::channel(); [INFO] [stdout] | ---------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | [INFO] [stdout] 111 | let stream_lock = RwLock::new(BitWriter::endian(writer, BigEndian)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let stream_lock_arc = Arc::new(stream_lock); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let stream_lock_arc_clone = stream_lock_arc.clone(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | [INFO] [stdout] 115 | let last_message_written = Arc::new(RwLock::new(0)); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let last_message_written_clone = last_message_written.clone(); [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | written_bytes_tx: Some(written_bytes_tx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/compressed/stream.rs:251:14 [INFO] [stdout] | [INFO] [stdout] 244 | let arc = self.stream.take()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | [INFO] [stdout] 246 | let lock = Arc::into_inner(arc).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | // let mut guard = tmp.write().unwrap(); [INFO] [stdout] 248 | let consumed_data = lock.into_inner().unwrap(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | Some(consumed_data.into_writer()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/decoder.rs:202:13 [INFO] [stdout] | [INFO] [stdout] 202 | Err(CodecError::UnsupportedVersion(codec_version)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/decoder.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 296 | let bufwriter = BufWriter::new(output); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | let compression = RawOutput::new( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | let mut encoder: Encoder>> = Encoder::new_raw( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | let mut writer = encoder.close_writer().unwrap().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 327 | writer.into_inner().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/decoder.rs:371:9 [INFO] [stdout] | [INFO] [stdout] 333 | let bufwriter = BufWriter::new(output); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 334 | let compression = RawOutput::new( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | let mut encoder: Encoder>> = Encoder::new_raw( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 367 | let mut writer = encoder.close_writer().unwrap().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 371 | writer.into_inner().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/decoder.rs:411:9 [INFO] [stdout] | [INFO] [stdout] 380 | let bufwriter = BufWriter::new(output); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 381 | let compression = CompressedOutput::new( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | let encoder: Encoder>> = Encoder::new_compressed( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | let mut writer = encoder.close_writer().unwrap().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 411 | writer.into_inner().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/encoder.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn close_writer(mut self) -> Result, CodecError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | Ok(self.output.into_writer()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/raw/stream.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(mut meta: CodecMetadata, writer: W) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | stream: Some(writer), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `adder-codec-core` (lib test) due to 11 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/codec/compressed/stream.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | mut stream: Arc>>, [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Compressed` is never constructed [INFO] [stdout] --> src/codec/compressed/source_model/event_structure/event_adu.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 37 | pub enum AduState { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] 38 | Compressed, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AduState` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `HeaderExtension` is never used [INFO] [stdout] --> src/codec/header.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | pub(crate) trait HeaderExtension {} [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for an enum [INFO] [stdout] --> src/lib.rs:196:1 [INFO] [stdout] | [INFO] [stdout] 196 | pub enum Mode { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | #![warn(missing_docs)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for an enum [INFO] [stdout] --> src/lib.rs:208:1 [INFO] [stdout] | [INFO] [stdout] 208 | pub enum PixelMultiMode { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a variant [INFO] [stdout] --> src/lib.rs:209:5 [INFO] [stdout] | [INFO] [stdout] 209 | Normal, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a variant [INFO] [stdout] --> src/lib.rs:212:5 [INFO] [stdout] | [INFO] [stdout] 212 | Collapse, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:494:8 [INFO] [stdout] | [INFO] [stdout] 470 | let mut bufreader = BufReader::new(File::open(file_path)?); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 471 | let compression = RawInput::new(); [INFO] [stdout] 472 | let mut bitreader = BitReader::endian(bufreader, BigEndian); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 475 | let stream = match Decoder::new_raw(compression, &mut bitreader) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 476 | Ok(reader) => reader, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 482 | let compression = CompressedInput::new(0, 0, 0); // TODO: temporary args. Need to refactor. [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 490 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 494 | Ok((stream, bitreader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a struct field [INFO] [stdout] --> src/codec/mod.rs:272:5 [INFO] [stdout] | [INFO] [stdout] 272 | pub crf: Crf, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/codec/mod.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | #![warn(missing_docs)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for an associated function [INFO] [stdout] --> src/codec/mod.rs:276:5 [INFO] [stdout] | [INFO] [stdout] 276 | pub fn default(plane: PlaneSize) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a struct field [INFO] [stdout] --> src/codec/mod.rs:294:9 [INFO] [stdout] | [INFO] [stdout] 294 | target_event_rate: f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a constant [INFO] [stdout] --> src/codec/compressed/mod.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | pub const BLOCK_SIZE_BIG: usize = 64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a constant [INFO] [stdout] --> src/codec/compressed/mod.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | pub const BLOCK_SIZE_BIG_AREA: usize = BLOCK_SIZE_BIG * BLOCK_SIZE_BIG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a type alias [INFO] [stdout] --> src/codec/compressed/mod.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | pub type DResidual = i16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a constant [INFO] [stdout] --> src/codec/compressed/mod.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | pub const DRESIDUAL_NO_EVENT: DResidual = 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a constant [INFO] [stdout] --> src/codec/compressed/mod.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | pub const DRESIDUAL_SKIP_CUBE: DResidual = 257; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a type alias [INFO] [stdout] --> src/codec/compressed/mod.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | pub type TResidual = i16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for an associated function [INFO] [stdout] --> src/codec/compressed/fenwick/mod.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(n: usize) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/codec/compressed/fenwick/mod.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a struct [INFO] [stdout] --> src/codec/compressed/fenwick/mod.rs:112:1 [INFO] [stdout] | [INFO] [stdout] 112 | pub struct ValueError(pub usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a struct [INFO] [stdout] --> src/codec/compressed/fenwick/context_switching.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct FenwickModel { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/codec/compressed/fenwick/context_switching.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn set_context(&mut self, context: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/compressed/stream.rs:132:21 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(meta: CodecMetadata, writer: W) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let adu = EventAdu::new(meta.plane, 0, meta.ref_interval, meta.adu_interval as usize); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let (written_bytes_tx, written_bytes_rx) = std::sync::mpsc::channel(); [INFO] [stdout] | ---------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | [INFO] [stdout] 111 | let stream_lock = RwLock::new(BitWriter::endian(writer, BigEndian)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let stream_lock_arc = Arc::new(stream_lock); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let stream_lock_arc_clone = stream_lock_arc.clone(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | [INFO] [stdout] 115 | let last_message_written = Arc::new(RwLock::new(0)); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let last_message_written_clone = last_message_written.clone(); [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | stream: Some(stream_lock_arc), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/compressed/stream.rs:135:31 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(meta: CodecMetadata, writer: W) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let adu = EventAdu::new(meta.plane, 0, meta.ref_interval, meta.adu_interval as usize); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let (written_bytes_tx, written_bytes_rx) = std::sync::mpsc::channel(); [INFO] [stdout] | ---------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | [INFO] [stdout] 111 | let stream_lock = RwLock::new(BitWriter::endian(writer, BigEndian)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let stream_lock_arc = Arc::new(stream_lock); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let stream_lock_arc_clone = stream_lock_arc.clone(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | [INFO] [stdout] 115 | let last_message_written = Arc::new(RwLock::new(0)); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let last_message_written_clone = last_message_written.clone(); [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | written_bytes_tx: Some(written_bytes_tx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/compressed/stream.rs:251:14 [INFO] [stdout] | [INFO] [stdout] 244 | let arc = self.stream.take()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | [INFO] [stdout] 246 | let lock = Arc::into_inner(arc).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | // let mut guard = tmp.write().unwrap(); [INFO] [stdout] 248 | let consumed_data = lock.into_inner().unwrap(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | Some(consumed_data.into_writer()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/decoder.rs:202:13 [INFO] [stdout] | [INFO] [stdout] 202 | Err(CodecError::UnsupportedVersion(codec_version)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/codec/decoder.rs:260:5 [INFO] [stdout] | [INFO] [stdout] 260 | pub fn get_compression_type(&self) -> EncoderType { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a struct field [INFO] [stdout] --> src/codec/encoder.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub options: EncoderOptions, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/encoder.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn close_writer(mut self) -> Result, CodecError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | Ok(self.output.into_writer()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/codec/encoder.rs:298:5 [INFO] [stdout] | [INFO] [stdout] 298 | pub fn get_options(&self) -> EncoderOptions { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a struct [INFO] [stdout] --> src/codec/rate_controller.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct Crf { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a struct field [INFO] [stdout] --> src/codec/rate_controller.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub plane: PlaneSize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a struct [INFO] [stdout] --> src/codec/rate_controller.rs:40:1 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct CrfParameters { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for an associated function [INFO] [stdout] --> src/codec/rate_controller.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn new(crf: Option, plane: PlaneSize) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/codec/rate_controller.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn update_quality(&mut self, crf: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/codec/rate_controller.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn override_c_thresh_baseline(&mut self, baseline: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/codec/rate_controller.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn override_c_thresh_max(&mut self, max: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/codec/rate_controller.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn override_c_increase_velocity(&mut self, velocity: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/codec/rate_controller.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn override_feature_c_radius(&mut self, radius: u16) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/codec/rate_controller.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn get_parameters(&self) -> &CrfParameters { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/codec/rate_controller.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn get_parameters_mut(&mut self) -> &mut CrfParameters { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/codec/rate_controller.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn get_quality(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/raw/stream.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(mut meta: CodecMetadata, writer: W) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | stream: Some(writer), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 38 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `adder-codec-core` (lib) due to 8 previous errors; 38 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e734696e537557f67432ae6abb544c1fb4efefd333737a6a837d05c8166fccb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e734696e537557f67432ae6abb544c1fb4efefd333737a6a837d05c8166fccb2", kill_on_drop: false }` [INFO] [stdout] e734696e537557f67432ae6abb544c1fb4efefd333737a6a837d05c8166fccb2