[INFO] fetching crate add-determinism 0.3.6... [INFO] checking add-determinism-0.3.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate add-determinism 0.3.6 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate add-determinism 0.3.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate add-determinism 0.3.6 [INFO] finished tweaking crates.io crate add-determinism 0.3.6 [INFO] tweaked toml for crates.io crate add-determinism 0.3.6 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate add-determinism 0.3.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 766af14464078ab56424a0596f567b7564774fc7f32d69614506b19886ef8cee [INFO] running `Command { std: "docker" "start" "-a" "766af14464078ab56424a0596f567b7564774fc7f32d69614506b19886ef8cee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "766af14464078ab56424a0596f567b7564774fc7f32d69614506b19886ef8cee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "766af14464078ab56424a0596f567b7564774fc7f32d69614506b19886ef8cee", kill_on_drop: false }` [INFO] [stdout] 766af14464078ab56424a0596f567b7564774fc7f32d69614506b19886ef8cee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c00d9825e85e1f740085df6909886cb4a3a5a38407899c7593f69935d85babd [INFO] running `Command { std: "docker" "start" "-a" "4c00d9825e85e1f740085df6909886cb4a3a5a38407899c7593f69935d85babd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Compiling libz-sys v1.1.16 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking time v0.3.34 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling add-determinism v0.3.6 (/opt/rustwide/workdir) [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking chrono v0.4.35 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling indoc v2.0.4 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling clap_derive v4.5.3 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking clap v4.5.3 [INFO] [stderr] Compiling ctor v0.1.26 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/mod.rs:421:12 [INFO] [stdout] | [INFO] [stdout] 406 | let input = File::open(input_path) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 410 | let input = BufReader::new(input); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 411 | [INFO] [stdout] 412 | let io = InputOutputHelper { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 421 | Ok((io, input)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/pyc.rs:604:12 [INFO] [stdout] | [INFO] [stdout] 598 | let mut result = 0_i32.to_bigint().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 604 | Ok(Object::Long(result * n.signum())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/pyc.rs:617:12 [INFO] [stdout] | [INFO] [stdout] 617 | Ok(Object::String(self.data[offset .. offset + size].to_vec())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/pyc.rs:629:12 [INFO] [stdout] | [INFO] [stdout] 624 | let mut ans = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 629 | Ok(Object::Tuple(ans)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/pyc.rs:659:12 [INFO] [stdout] | [INFO] [stdout] 659 | Ok(Object::Ref(desc)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/pyc.rs:690:12 [INFO] [stdout] | [INFO] [stdout] 678 | let mut dict = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 690 | Ok(Object::Dict(dict)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `add-determinism` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/mod.rs:421:12 [INFO] [stdout] | [INFO] [stdout] 406 | let input = File::open(input_path) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 410 | let input = BufReader::new(input); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 411 | [INFO] [stdout] 412 | let io = InputOutputHelper { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 421 | Ok((io, input)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/javadoc.rs:167:23 [INFO] [stdout] | [INFO] [stdout] 167 | let plu = |s| h.process_line(s).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/pyc.rs:604:12 [INFO] [stdout] | [INFO] [stdout] 598 | let mut result = 0_i32.to_bigint().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 604 | Ok(Object::Long(result * n.signum())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/pyc.rs:617:12 [INFO] [stdout] | [INFO] [stdout] 617 | Ok(Object::String(self.data[offset .. offset + size].to_vec())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/pyc.rs:629:12 [INFO] [stdout] | [INFO] [stdout] 624 | let mut ans = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 629 | Ok(Object::Tuple(ans)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/pyc.rs:659:12 [INFO] [stdout] | [INFO] [stdout] 659 | Ok(Object::Ref(desc)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/pyc.rs:690:12 [INFO] [stdout] | [INFO] [stdout] 678 | let mut dict = Vec::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 690 | Ok(Object::Dict(dict)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `add-determinism` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "4c00d9825e85e1f740085df6909886cb4a3a5a38407899c7593f69935d85babd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c00d9825e85e1f740085df6909886cb4a3a5a38407899c7593f69935d85babd", kill_on_drop: false }` [INFO] [stdout] 4c00d9825e85e1f740085df6909886cb4a3a5a38407899c7593f69935d85babd