[INFO] fetching crate adbium 0.1.3... [INFO] checking adbium-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate adbium 0.1.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate adbium 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate adbium 0.1.3 [INFO] finished tweaking crates.io crate adbium 0.1.3 [INFO] tweaked toml for crates.io crate adbium 0.1.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de38a46a994ecd4455df3527d90a579a62cd0cd98d137996563411cb2e4cac59 [INFO] running `Command { std: "docker" "start" "-a" "de38a46a994ecd4455df3527d90a579a62cd0cd98d137996563411cb2e4cac59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de38a46a994ecd4455df3527d90a579a62cd0cd98d137996563411cb2e4cac59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de38a46a994ecd4455df3527d90a579a62cd0cd98d137996563411cb2e4cac59", kill_on_drop: false }` [INFO] [stdout] de38a46a994ecd4455df3527d90a579a62cd0cd98d137996563411cb2e4cac59 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d71d142094ea7419558fb209aa0d2167f9385fc1862fc4426eb9b2711a693d9b [INFO] running `Command { std: "docker" "start" "-a" "d71d142094ea7419558fb209aa0d2167f9385fc1862fc4426eb9b2711a693d9b", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Checking adbium v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `error::Error` and `io::Read` [INFO] [stdout] --> src/adb.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{io::Read, error::Error}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TcpStream` [INFO] [stdout] --> src/tests.rs:1:50 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::BTreeMap, net::{Ipv4Addr, TcpStream}, time::Duration}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AdbServerError` [INFO] [stdout] --> src/tests.rs:3:49 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{device_info::*, server::{AdbServer, AdbServerError}}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `error::Error` and `io::Read` [INFO] [stdout] --> src/adb.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{io::Read, error::Error}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/server.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | fn from(value: Utf8Error) -> Self { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/server.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | fn from(value: Utf8Error) -> Self { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `uuid_check` [INFO] [stdout] --> src/device.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | let uuid_check = |uid: String| uid.contains("uid=0"); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_uuid_check` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/device.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | let mut dev = AdbDevice { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `conn` [INFO] [stdout] --> src/tests.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | let conn = serv.connect().expect("Failed to estabilish connection"); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_conn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dev` [INFO] [stdout] --> src/tests.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | let dev = serv.get_active_device().expect("Couldn't find device"); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_dev` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `serial_number`, `adb_root`, `rooted`, `su_0_cmd`, `su_c_cmd`, and `run_as_pkg` are never read [INFO] [stdout] --> src/device.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct AdbDevice { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 7 | serial_number: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 11 | adb_root: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 12 | rooted: bool, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 13 | [INFO] [stdout] 14 | su_0_cmd: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 15 | su_c_cmd: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 16 | [INFO] [stdout] 17 | run_as_pkg: Option, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AdbDevice` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:50:38 [INFO] [stdout] | [INFO] [stdout] 49 | fn from(value: std::io::Error) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | AdbServerError::UnknownError(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `uuid_check` [INFO] [stdout] --> src/device.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | let uuid_check = |uid: String| uid.contains("uid=0"); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_uuid_check` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/device.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | let mut dev = AdbDevice { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `serial_number`, `adb_root`, `rooted`, `su_0_cmd`, `su_c_cmd`, and `run_as_pkg` are never read [INFO] [stdout] --> src/device.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct AdbDevice { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 7 | serial_number: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 11 | adb_root: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 12 | rooted: bool, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 13 | [INFO] [stdout] 14 | su_0_cmd: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 15 | su_c_cmd: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 16 | [INFO] [stdout] 17 | run_as_pkg: Option, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AdbDevice` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `adbium` (lib test) due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:50:38 [INFO] [stdout] | [INFO] [stdout] 49 | fn from(value: std::io::Error) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | AdbServerError::UnknownError(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `adbium` (lib) due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d71d142094ea7419558fb209aa0d2167f9385fc1862fc4426eb9b2711a693d9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d71d142094ea7419558fb209aa0d2167f9385fc1862fc4426eb9b2711a693d9b", kill_on_drop: false }` [INFO] [stdout] d71d142094ea7419558fb209aa0d2167f9385fc1862fc4426eb9b2711a693d9b