[INFO] fetching crate adb-rs 0.1.3... [INFO] checking adb-rs-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate adb-rs 0.1.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate adb-rs 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate adb-rs 0.1.3 [INFO] finished tweaking crates.io crate adb-rs 0.1.3 [INFO] tweaked toml for crates.io crate adb-rs 0.1.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 37 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding crossbeam-channel v0.3.9 (latest: v0.5.13) [INFO] [stderr] Adding crossbeam-utils v0.6.6 (latest: v0.8.20) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding num-derive v0.2.5 (latest: v0.4.2) [INFO] [stderr] Adding pretty-hex v0.1.1 (latest: v0.4.1) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a0fbef94f4f324e219b92028fc5bb4f1a5f5833f7f6c64b892522824665443c6 [INFO] running `Command { std: "docker" "start" "-a" "a0fbef94f4f324e219b92028fc5bb4f1a5f5833f7f6c64b892522824665443c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a0fbef94f4f324e219b92028fc5bb4f1a5f5833f7f6c64b892522824665443c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0fbef94f4f324e219b92028fc5bb4f1a5f5833f7f6c64b892522824665443c6", kill_on_drop: false }` [INFO] [stdout] a0fbef94f4f324e219b92028fc5bb4f1a5f5833f7f6c64b892522824665443c6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 88f55bf2b48c921e00fa7715a7a3a3a5fbb68cb9e533bd350c1465ed9f480cff [INFO] running `Command { std: "docker" "start" "-a" "88f55bf2b48c921e00fa7715a7a3a3a5fbb68cb9e533bd350c1465ed9f480cff", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Checking pretty-hex v0.1.1 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking adb-rs v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `magic` is never read [INFO] [stdout] --> src/message/mod.rs:32:7 [INFO] [stdout] | [INFO] [stdout] 26 | pub struct Header { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 32 | pub magic: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `local_id` and `remote_id` are never read [INFO] [stdout] --> src/client.rs:272:3 [INFO] [stdout] | [INFO] [stdout] 271 | struct StreamContext { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 272 | local_id: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 273 | remote_id: u32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StreamContext` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `system_identity`, `device_system_identity`, and `device_version` are never read [INFO] [stdout] --> src/client.rs:280:3 [INFO] [stdout] | [INFO] [stdout] 279 | pub struct AdbConnection { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 280 | system_identity: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 281 | device_system_identity: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 282 | device_version: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AdbConnection` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `magic` is never read [INFO] [stdout] --> src/message/mod.rs:32:7 [INFO] [stdout] | [INFO] [stdout] 26 | pub struct Header { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 32 | pub magic: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `local_id` and `remote_id` are never read [INFO] [stdout] --> src/client.rs:272:3 [INFO] [stdout] | [INFO] [stdout] 271 | struct StreamContext { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 272 | local_id: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 273 | remote_id: u32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StreamContext` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `system_identity`, `device_system_identity`, and `device_version` are never read [INFO] [stdout] --> src/client.rs:280:3 [INFO] [stdout] | [INFO] [stdout] 279 | pub struct AdbConnection { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 280 | system_identity: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 281 | device_system_identity: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 282 | device_version: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AdbConnection` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:227:8 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn connect(self, addr: T) -> AdbResult [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let mut stream = TcpStream::connect(&addrs as &[SocketAddr])?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let streams = Arc::new(RwLock::new(HashMap::::new())); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | [INFO] [stdout] 61 | let (conn_reader_s, conn_reader_r) = bounded::(0); [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let (conn_writer_s, conn_writer_r) = bounded::(0); [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let (conn_error_s, conn_error_r) = unbounded(); [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | [INFO] [stdout] 65 | let reader_worker = thread::spawn({ [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let mut stream = stream.try_clone()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let error_s = conn_error_s.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let writer_worker = thread::spawn({ [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let mut stream = stream.try_clone()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let streams = streams.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let error_s = conn_error_s.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let dispatch_worker = thread::spawn({ [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let streams = streams.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Ok(AdbConnection { [INFO] [stdout] | ________^ [INFO] [stdout] 228 | | system_identity: self.system_identity, [INFO] [stdout] 229 | | device_system_identity: device_id.to_string(), [INFO] [stdout] 230 | | device_version: resp.arg0, [INFO] [stdout] ... | [INFO] [stdout] 236 | | conn_writer_s, [INFO] [stdout] 237 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:78:28 [INFO] [stdout] | [INFO] [stdout] 71 | let mut payload = BytesMut::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | payload: payload.freeze(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 88 | .and_then(|packet| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | / conn_reader_s [INFO] [stdout] 90 | | .send(packet) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:119:33 [INFO] [stdout] | [INFO] [stdout] 119 | .and_then(|_| stream.write_all(&packet.payload).map_err(Into::into)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:227:8 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn connect(self, addr: T) -> AdbResult [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let mut stream = TcpStream::connect(&addrs as &[SocketAddr])?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let streams = Arc::new(RwLock::new(HashMap::::new())); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | [INFO] [stdout] 61 | let (conn_reader_s, conn_reader_r) = bounded::(0); [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let (conn_writer_s, conn_writer_r) = bounded::(0); [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let (conn_error_s, conn_error_r) = unbounded(); [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | [INFO] [stdout] 65 | let reader_worker = thread::spawn({ [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let mut stream = stream.try_clone()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let error_s = conn_error_s.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let writer_worker = thread::spawn({ [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let mut stream = stream.try_clone()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let streams = streams.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let error_s = conn_error_s.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let dispatch_worker = thread::spawn({ [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let streams = streams.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Ok(AdbConnection { [INFO] [stdout] | ________^ [INFO] [stdout] 228 | | system_identity: self.system_identity, [INFO] [stdout] 229 | | device_system_identity: device_id.to_string(), [INFO] [stdout] 230 | | device_version: resp.arg0, [INFO] [stdout] ... | [INFO] [stdout] 236 | | conn_writer_s, [INFO] [stdout] 237 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:78:28 [INFO] [stdout] | [INFO] [stdout] 71 | let mut payload = BytesMut::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | payload: payload.freeze(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:257:16 [INFO] [stdout] | [INFO] [stdout] 253 | pub fn new_write>(payload: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | payload: Bytes::from_buf(bytes), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 88 | .and_then(|packet| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | / conn_reader_s [INFO] [stdout] 90 | | .send(packet) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:119:33 [INFO] [stdout] | [INFO] [stdout] 119 | .and_then(|_| stream.write_all(&packet.payload).map_err(Into::into)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:257:16 [INFO] [stdout] | [INFO] [stdout] 253 | pub fn new_write>(payload: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | payload: Bytes::from_buf(bytes), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/client.rs:296:5 [INFO] [stdout] | [INFO] [stdout] 296 | ::std::mem::replace(&mut self.conn_writer_s, conn_writer_s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 296 | let _ = ::std::mem::replace(&mut self.conn_writer_s, conn_writer_s); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:362:8 [INFO] [stdout] | [INFO] [stdout] 318 | let (write_result_s, write_result_r) = bounded::>(1); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | let (stream_reader_s, stream_reader_r) = bounded::(1); [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | [INFO] [stdout] 321 | let ctx = StreamContext { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | let mut dst_bytes = BytesMut::with_capacity(destination.as_bytes().len() + 1); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | let dst_bytes = dst_bytes.freeze(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 335 | [INFO] [stdout] 336 | let open_packet = ConnectionPacket { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | let open_packet = stream_reader_r.recv().map_err(|_| AdbError::Disconnected)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | Ok(AdbStream { [INFO] [stdout] | ________^ [INFO] [stdout] 363 | | local_id, [INFO] [stdout] 364 | | remote_id, [INFO] [stdout] 365 | | stream_reader: stream_reader_r, [INFO] [stdout] 366 | | writer: self.conn_writer_s.clone(), [INFO] [stdout] 367 | | write_result_r, [INFO] [stdout] 368 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/client.rs:296:5 [INFO] [stdout] | [INFO] [stdout] 296 | ::std::mem::replace(&mut self.conn_writer_s, conn_writer_s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 296 | let _ = ::std::mem::replace(&mut self.conn_writer_s, conn_writer_s); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:383:5 [INFO] [stdout] | [INFO] [stdout] 382 | pub fn send(&self, packet: AdbStreamPacket) -> AdbResult<()> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | / self [INFO] [stdout] 384 | | .writer [INFO] [stdout] 385 | | .send(ConnectionPacket { [INFO] [stdout] 386 | | header: Header::new(packet.command) [INFO] [stdout] ... | [INFO] [stdout] 392 | | }) [INFO] [stdout] 393 | | .map_err(|_| AdbError::Disconnected) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:362:8 [INFO] [stdout] | [INFO] [stdout] 318 | let (write_result_s, write_result_r) = bounded::>(1); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | let (stream_reader_s, stream_reader_r) = bounded::(1); [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | [INFO] [stdout] 321 | let ctx = StreamContext { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | let mut dst_bytes = BytesMut::with_capacity(destination.as_bytes().len() + 1); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | let dst_bytes = dst_bytes.freeze(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 335 | [INFO] [stdout] 336 | let open_packet = ConnectionPacket { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | let open_packet = stream_reader_r.recv().map_err(|_| AdbError::Disconnected)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | Ok(AdbStream { [INFO] [stdout] | ________^ [INFO] [stdout] 363 | | local_id, [INFO] [stdout] 364 | | remote_id, [INFO] [stdout] 365 | | stream_reader: stream_reader_r, [INFO] [stdout] 366 | | writer: self.conn_writer_s.clone(), [INFO] [stdout] 367 | | write_result_r, [INFO] [stdout] 368 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:383:5 [INFO] [stdout] | [INFO] [stdout] 382 | pub fn send(&self, packet: AdbStreamPacket) -> AdbResult<()> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | / self [INFO] [stdout] 384 | | .writer [INFO] [stdout] 385 | | .send(ConnectionPacket { [INFO] [stdout] 386 | | header: Header::new(packet.command) [INFO] [stdout] ... | [INFO] [stdout] 392 | | }) [INFO] [stdout] 393 | | .map_err(|_| AdbError::Disconnected) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:409:8 [INFO] [stdout] | [INFO] [stdout] 404 | let packet = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 409 | Ok(AdbStreamPacket { [INFO] [stdout] | ________^ [INFO] [stdout] 410 | | command: packet [INFO] [stdout] 411 | | .header [INFO] [stdout] 412 | | .get_command() [INFO] [stdout] 413 | | .ok_or_else(|| AdbError::UnknownCommand(packet.header.command))?, [INFO] [stdout] 414 | | payload: packet.payload, [INFO] [stdout] 415 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:409:8 [INFO] [stdout] | [INFO] [stdout] 404 | let packet = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 409 | Ok(AdbStreamPacket { [INFO] [stdout] | ________^ [INFO] [stdout] 410 | | command: packet [INFO] [stdout] 411 | | .header [INFO] [stdout] 412 | | .get_command() [INFO] [stdout] 413 | | .ok_or_else(|| AdbError::UnknownCommand(packet.header.command))?, [INFO] [stdout] 414 | | payload: packet.payload, [INFO] [stdout] 415 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `adb-rs` (lib test) due to 9 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `adb-rs` (lib) due to 9 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "88f55bf2b48c921e00fa7715a7a3a3a5fbb68cb9e533bd350c1465ed9f480cff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88f55bf2b48c921e00fa7715a7a3a3a5fbb68cb9e533bd350c1465ed9f480cff", kill_on_drop: false }` [INFO] [stdout] 88f55bf2b48c921e00fa7715a7a3a3a5fbb68cb9e533bd350c1465ed9f480cff