[INFO] fetching crate ad9850 0.1.2... [INFO] checking ad9850-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ad9850 0.1.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate ad9850 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate ad9850 0.1.2 [INFO] finished tweaking crates.io crate ad9850 0.1.2 [INFO] tweaked toml for crates.io crate ad9850 0.1.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding embedded-hal v0.2.7 (latest: v1.0.0) [INFO] [stderr] Adding nb v0.1.3 (latest: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1fde199c69810682962ac7eb168cfa6a96a48b3bdea60d61c9d83bd4d2bb2d58 [INFO] running `Command { std: "docker" "start" "-a" "1fde199c69810682962ac7eb168cfa6a96a48b3bdea60d61c9d83bd4d2bb2d58", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1fde199c69810682962ac7eb168cfa6a96a48b3bdea60d61c9d83bd4d2bb2d58", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1fde199c69810682962ac7eb168cfa6a96a48b3bdea60d61c9d83bd4d2bb2d58", kill_on_drop: false }` [INFO] [stdout] 1fde199c69810682962ac7eb168cfa6a96a48b3bdea60d61c9d83bd4d2bb2d58 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe4f62df2497d557ff07e9cdff313bf00986f4b1b10f27a1de38ed0aacb6d161 [INFO] running `Command { std: "docker" "start" "-a" "fe4f62df2497d557ff07e9cdff313bf00986f4b1b10f27a1de38ed0aacb6d161", kill_on_drop: false }` [INFO] [stderr] Checking nb v1.1.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking nb v0.1.3 [INFO] [stderr] Checking embedded-hal v0.2.7 [INFO] [stderr] Checking ad9850 v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn into_serial_mode(mut self) -> Result, E> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | Ok(Ad9850 { [INFO] [stdout] | ____________^ [INFO] [stdout] 165 | | reset: self.reset, [INFO] [stdout] 166 | | data: self.data, [INFO] [stdout] 167 | | fq_ud: self.fq_ud, [INFO] [stdout] ... | [INFO] [stdout] 170 | | marker: PhantomData, [INFO] [stdout] 171 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ad9850` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn into_serial_mode(mut self) -> Result, E> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | Ok(Ad9850 { [INFO] [stdout] | ____________^ [INFO] [stdout] 165 | | reset: self.reset, [INFO] [stdout] 166 | | data: self.data, [INFO] [stdout] 167 | | fq_ud: self.fq_ud, [INFO] [stdout] ... | [INFO] [stdout] 170 | | marker: PhantomData, [INFO] [stdout] 171 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ad9850` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "fe4f62df2497d557ff07e9cdff313bf00986f4b1b10f27a1de38ed0aacb6d161", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe4f62df2497d557ff07e9cdff313bf00986f4b1b10f27a1de38ed0aacb6d161", kill_on_drop: false }` [INFO] [stdout] fe4f62df2497d557ff07e9cdff313bf00986f4b1b10f27a1de38ed0aacb6d161