[INFO] fetching crate actix-sqlx-tx 0.1.0... [INFO] checking actix-sqlx-tx-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate actix-sqlx-tx 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate actix-sqlx-tx 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate actix-sqlx-tx 0.1.0 [INFO] finished tweaking crates.io crate actix-sqlx-tx 0.1.0 [INFO] tweaked toml for crates.io crate actix-sqlx-tx 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 238 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding atoi v1.0.0 (latest: v2.0.0) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding const-oid v0.7.1 (latest: v0.9.6) [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding crypto-bigint v0.3.2 (latest: v0.5.5) [INFO] [stderr] Adding der v0.5.1 (latest: v0.7.9) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding dirs v4.0.0 (latest: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (latest: v0.4.1) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding flume v0.10.14 (latest: v0.11.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding futures-intrusive v0.4.2 (latest: v0.5.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hashlink v0.8.4 (latest: v0.9.1) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding libsqlite3-sys v0.24.2 (latest: v0.30.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding pem-rfc7468 v0.3.1 (latest: v0.7.0) [INFO] [stderr] Adding pkcs1 v0.3.3 (latest: v0.7.5) [INFO] [stderr] Adding pkcs8 v0.8.0 (latest: v0.10.2) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding redox_syscall v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rsa v0.6.1 (latest: v0.9.6) [INFO] [stderr] Adding rustls v0.20.9 (latest: v0.23.12) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding spki v0.5.4 (latest: v0.7.3) [INFO] [stderr] Adding sqlx v0.6.3 (latest: v0.8.1) [INFO] [stderr] Adding sqlx-core v0.6.3 (latest: v0.8.1) [INFO] [stderr] Adding sqlx-macros v0.6.3 (latest: v0.8.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio-rustls v0.23.4 (latest: v0.26.0) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki-roots v0.22.6 (latest: v0.26.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6b7f79b718107606a489eb92e18e85c59ff699a875d4703d0224efdf459aa24f [INFO] running `Command { std: "docker" "start" "-a" "6b7f79b718107606a489eb92e18e85c59ff699a875d4703d0224efdf459aa24f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6b7f79b718107606a489eb92e18e85c59ff699a875d4703d0224efdf459aa24f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b7f79b718107606a489eb92e18e85c59ff699a875d4703d0224efdf459aa24f", kill_on_drop: false }` [INFO] [stdout] 6b7f79b718107606a489eb92e18e85c59ff699a875d4703d0224efdf459aa24f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a6c70c9f99f6a753b212e7c827c4bc62d247d022fed182e8bf97fd0d7420b9c1 [INFO] running `Command { std: "docker" "start" "-a" "a6c70c9f99f6a753b212e7c827c4bc62d247d022fed182e8bf97fd0d7420b9c1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling rustls v0.20.9 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling untrusted v0.9.0 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling tinyvec v1.8.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling untrusted v0.7.1 [INFO] [stderr] Compiling spin v0.5.2 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling instant v0.1.13 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling allocator-api2 v0.2.18 [INFO] [stderr] Checking webpki v0.22.4 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling parking_lot v0.11.2 [INFO] [stderr] Compiling idna v0.5.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling tokio-rustls v0.23.4 [INFO] [stderr] Compiling base64 v0.21.7 [INFO] [stderr] Compiling unicode_categories v0.1.1 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Compiling unicode-properties v0.1.2 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Compiling rustls-pemfile v1.0.4 [INFO] [stderr] Compiling sqlformat v0.2.4 [INFO] [stderr] Compiling sqlx-rt v0.6.3 [INFO] [stderr] Compiling atoi v1.0.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.11 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling tokio-stream v0.1.15 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling futures-intrusive v0.4.2 [INFO] [stderr] Compiling hashlink v0.8.4 [INFO] [stderr] Compiling webpki-roots v0.22.6 [INFO] [stderr] Compiling futures-channel v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking actix-rt v2.10.0 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Checking actix-service v2.0.2 [INFO] [stderr] Checking bytestring v1.3.1 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling event-listener v2.5.3 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Checking regex-lite v0.1.6 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking actix-router v0.5.3 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking actix-server v2.5.0 [INFO] [stderr] Checking impl-more v0.1.6 [INFO] [stderr] Compiling sqlx-core v0.6.3 [INFO] [stderr] Checking actix-http v3.9.0 [INFO] [stderr] Compiling sqlx-macros v0.6.3 [INFO] [stderr] Checking actix-web v4.9.0 [INFO] [stderr] Checking sqlx v0.6.3 [INFO] [stderr] Checking actix-sqlx-tx v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:37:19 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new_with_error(pool: sqlx::Pool) -> TransactionMiddleware { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | TransactionMiddleware { [INFO] [stdout] 37 | pool: Rc::new(pool), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:62:15 [INFO] [stdout] | [INFO] [stdout] 61 | fn new_transform(&self, service: S) -> Self::Future { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | ready(Ok(InnerTransactionMiddleware { [INFO] [stdout] | _______________^ [INFO] [stdout] 63 | | service: Rc::new(service), [INFO] [stdout] 64 | | pool: Rc::clone(&self.pool), [INFO] [stdout] 65 | | _error: self._error, [INFO] [stdout] 66 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:107:18 [INFO] [stdout] | [INFO] [stdout] 102 | fn call(&self, req: ServiceRequest) -> Self::Future { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let transaction = TxSlot::bind(&mut req.extensions_mut(), &self.pool); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let srv = Rc::clone(&self.service); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let res = srv.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | [INFO] [stdout] 107 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 108 | | let res = res.await?; [INFO] [stdout] 109 | | [INFO] [stdout] 110 | | if res.status().is_success() { [INFO] [stdout] ... | [INFO] [stdout] 115 | | Ok(res) [INFO] [stdout] 116 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slot.rs:25:14 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Self(Arc::new(Mutex::new(Some(value)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slot.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub(crate) fn into_inner(self) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | self.0.try_lock().and_then(|mut slot| slot.take()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slot.rs:66:14 [INFO] [stdout] | [INFO] [stdout] 65 | fn new(value: T, slot: Weak>>) -> Self { [INFO] [stdout] | -------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Self(lease::State::new(value, slot)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slot.rs:127:18 [INFO] [stdout] | [INFO] [stdout] 126 | pub(super) fn new(value: T, slot: Weak>>) -> Self { [INFO] [stdout] | -------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | Self(Inner::Live { value, slot }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tx.rs:135:18 [INFO] [stdout] | [INFO] [stdout] 134 | let req = req.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 136 | | // drop ext, or it will drop after request finish [INFO] [stdout] 137 | | let mut ext = req [INFO] [stdout] 138 | | .extensions_mut() [INFO] [stdout] ... | [INFO] [stdout] 144 | | Ok(Self(tx, PhantomData)) [INFO] [stdout] 145 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tx.rs:144:16 [INFO] [stdout] | [INFO] [stdout] 134 | let req = req.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let mut ext = req [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | let tx = ext.get_or_begin().await?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | [INFO] [stdout] 144 | Ok(Self(tx, PhantomData)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `actix-sqlx-tx` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:37:19 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new_with_error(pool: sqlx::Pool) -> TransactionMiddleware { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | TransactionMiddleware { [INFO] [stdout] 37 | pool: Rc::new(pool), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:62:15 [INFO] [stdout] | [INFO] [stdout] 61 | fn new_transform(&self, service: S) -> Self::Future { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | ready(Ok(InnerTransactionMiddleware { [INFO] [stdout] | _______________^ [INFO] [stdout] 63 | | service: Rc::new(service), [INFO] [stdout] 64 | | pool: Rc::clone(&self.pool), [INFO] [stdout] 65 | | _error: self._error, [INFO] [stdout] 66 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:107:18 [INFO] [stdout] | [INFO] [stdout] 102 | fn call(&self, req: ServiceRequest) -> Self::Future { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let transaction = TxSlot::bind(&mut req.extensions_mut(), &self.pool); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let srv = Rc::clone(&self.service); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let res = srv.call(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | [INFO] [stdout] 107 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 108 | | let res = res.await?; [INFO] [stdout] 109 | | [INFO] [stdout] 110 | | if res.status().is_success() { [INFO] [stdout] ... | [INFO] [stdout] 115 | | Ok(res) [INFO] [stdout] 116 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slot.rs:25:14 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Self(Arc::new(Mutex::new(Some(value)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slot.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub(crate) fn into_inner(self) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | self.0.try_lock().and_then(|mut slot| slot.take()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slot.rs:66:14 [INFO] [stdout] | [INFO] [stdout] 65 | fn new(value: T, slot: Weak>>) -> Self { [INFO] [stdout] | -------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Self(lease::State::new(value, slot)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slot.rs:127:18 [INFO] [stdout] | [INFO] [stdout] 126 | pub(super) fn new(value: T, slot: Weak>>) -> Self { [INFO] [stdout] | -------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | Self(Inner::Live { value, slot }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tx.rs:135:18 [INFO] [stdout] | [INFO] [stdout] 134 | let req = req.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 136 | | // drop ext, or it will drop after request finish [INFO] [stdout] 137 | | let mut ext = req [INFO] [stdout] 138 | | .extensions_mut() [INFO] [stdout] ... | [INFO] [stdout] 144 | | Ok(Self(tx, PhantomData)) [INFO] [stdout] 145 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tx.rs:144:16 [INFO] [stdout] | [INFO] [stdout] 134 | let req = req.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let mut ext = req [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | let tx = ext.get_or_begin().await?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | [INFO] [stdout] 144 | Ok(Self(tx, PhantomData)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `actix-sqlx-tx` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "a6c70c9f99f6a753b212e7c827c4bc62d247d022fed182e8bf97fd0d7420b9c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a6c70c9f99f6a753b212e7c827c4bc62d247d022fed182e8bf97fd0d7420b9c1", kill_on_drop: false }` [INFO] [stdout] a6c70c9f99f6a753b212e7c827c4bc62d247d022fed182e8bf97fd0d7420b9c1