[INFO] fetching crate accounting-allocator 0.2.0... [INFO] checking accounting-allocator-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate accounting-allocator 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate accounting-allocator 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate accounting-allocator 0.2.0 [INFO] finished tweaking crates.io crate accounting-allocator 0.2.0 [INFO] tweaked toml for crates.io crate accounting-allocator 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 48cc5cbcb51081fb70281a52bf3fc7962cc1afbf4457ed569f667a10f50d6e79 [INFO] running `Command { std: "docker" "start" "-a" "48cc5cbcb51081fb70281a52bf3fc7962cc1afbf4457ed569f667a10f50d6e79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "48cc5cbcb51081fb70281a52bf3fc7962cc1afbf4457ed569f667a10f50d6e79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48cc5cbcb51081fb70281a52bf3fc7962cc1afbf4457ed569f667a10f50d6e79", kill_on_drop: false }` [INFO] [stdout] 48cc5cbcb51081fb70281a52bf3fc7962cc1afbf4457ed569f667a10f50d6e79 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d4df0b2cd199067e7c90aad217260434f72091aa01c400b03687c39ec68555b7 [INFO] running `Command { std: "docker" "start" "-a" "d4df0b2cd199067e7c90aad217260434f72091aa01c400b03687c39ec68555b7", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking accounting-allocator v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:112:33 [INFO] [stdout] | [INFO] [stdout] 111 | pub const fn with_allocator(allocator: A) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | Self { thread_counters: OnceBox::new(), allocator } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:240:21 [INFO] [stdout] | [INFO] [stdout] 237 | let (tx, rx) = unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | shared: Mutex::new(ThreadCountersShared { [INFO] [stdout] | _____________________^ [INFO] [stdout] 241 | | rx, [INFO] [stdout] 242 | | counters: Vec::with_capacity(64), [INFO] [stdout] 243 | | dead_alloc: Default::default(), [INFO] [stdout] 244 | | dead_dealloc: Default::default(), [INFO] [stdout] 245 | | all_time: Default::default(), [INFO] [stdout] 246 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `accounting-allocator` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:112:33 [INFO] [stdout] | [INFO] [stdout] 111 | pub const fn with_allocator(allocator: A) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | Self { thread_counters: OnceBox::new(), allocator } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:240:21 [INFO] [stdout] | [INFO] [stdout] 237 | let (tx, rx) = unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | shared: Mutex::new(ThreadCountersShared { [INFO] [stdout] | _____________________^ [INFO] [stdout] 241 | | rx, [INFO] [stdout] 242 | | counters: Vec::with_capacity(64), [INFO] [stdout] 243 | | dead_alloc: Default::default(), [INFO] [stdout] 244 | | dead_dealloc: Default::default(), [INFO] [stdout] 245 | | all_time: Default::default(), [INFO] [stdout] 246 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 346 | callback: impl FnOnce(Vec>) -> T, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | let (allocations_tx, allocations_rx) = unbounded(); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 350 | / scope(|scope| { [INFO] [stdout] 351 | | for layout in layouts.clone() { [INFO] [stdout] 352 | | let allocations_tx = allocations_tx.clone(); [INFO] [stdout] 353 | | scope.spawn(move |_scope| allocations_tx.send(allocate(allocator, layout)).unwrap()); [INFO] [stdout] ... | [INFO] [stdout] 356 | | callback(allocations_rx.into_iter().collect()) [INFO] [stdout] 357 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:356:22 [INFO] [stdout] | [INFO] [stdout] 346 | callback: impl FnOnce(Vec>) -> T, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | let (allocations_tx, allocations_rx) = unbounded(); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | callback(allocations_rx.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:353:43 [INFO] [stdout] | [INFO] [stdout] 352 | let allocations_tx = allocations_tx.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | scope.spawn(move |_scope| allocations_tx.send(allocate(allocator, layout)).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `accounting-allocator` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "d4df0b2cd199067e7c90aad217260434f72091aa01c400b03687c39ec68555b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4df0b2cd199067e7c90aad217260434f72091aa01c400b03687c39ec68555b7", kill_on_drop: false }` [INFO] [stdout] d4df0b2cd199067e7c90aad217260434f72091aa01c400b03687c39ec68555b7