[INFO] fetching crate a4-core 0.0.4... [INFO] checking a4-core-0.0.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate a4-core 0.0.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate a4-core 0.0.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate a4-core 0.0.4 [INFO] finished tweaking crates.io crate a4-core 0.0.4 [INFO] tweaked toml for crates.io crate a4-core 0.0.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 21 packages to latest compatible versions [INFO] [stderr] Adding hash32 v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding heapless v0.7.17 (latest: v0.8.0) [INFO] [stderr] Adding postcard v0.7.3 (latest: v1.0.10) [INFO] [stderr] Adding postcard-cobs v0.1.5-pre (latest: v0.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0c9f90a72242e687dac3f4a0d3397a3ac30054eac17f312d05962824751eae1e [INFO] running `Command { std: "docker" "start" "-a" "0c9f90a72242e687dac3f4a0d3397a3ac30054eac17f312d05962824751eae1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0c9f90a72242e687dac3f4a0d3397a3ac30054eac17f312d05962824751eae1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c9f90a72242e687dac3f4a0d3397a3ac30054eac17f312d05962824751eae1e", kill_on_drop: false }` [INFO] [stdout] 0c9f90a72242e687dac3f4a0d3397a3ac30054eac17f312d05962824751eae1e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 99a80873c127f6cbafd7194dba7122ef5890a434b8d66031bf7838b168efc3c5 [INFO] running `Command { std: "docker" "start" "-a" "99a80873c127f6cbafd7194dba7122ef5890a434b8d66031bf7838b168efc3c5", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking postcard-cobs v0.1.5-pre [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking postcard v0.7.3 [INFO] [stderr] Checking a4-core v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `err` is never read [INFO] [stdout] --> src/nostd_rt.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct HVecStack { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 16 | data: Vec, [INFO] [stdout] 17 | err: Error, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HVecStack` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:291:12 [INFO] [stdout] | [INFO] [stdout] 210 | let ret = 'oloop: loop { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | let to_push = match cur { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let ret = Some(WhichToken::Ref(seq.clone())); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | Some(WhichToken::Single(ft)) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | Some(WhichToken::Ref(rf)) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | Ok(StepResult::Working(ret)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nostd_rt.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 32 | fn push(&mut self, data: T) -> Result<(), Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | self.data.push(data).map_err(|_| Error::StackOverflow).map(drop) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nostd_rt.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 84 | fn push(&mut self, data: RuntimeWord) { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | // TODO [INFO] [stdout] 86 | self.data.push(data).map_err(drop).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nostd_rt.rs:247:21 [INFO] [stdout] | [INFO] [stdout] 235 | let ds = HVecStack::new(Error::DataStackEmpty); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let rs = HVecStack::new(Error::RetStackEmpty); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | let fs = HVecStack::new(Error::FlowStackEmpty); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | cur_output: String::new(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `a4-core` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `err` is never read [INFO] [stdout] --> src/std_rt.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct StdVecStack { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 12 | data: Vec, [INFO] [stdout] 13 | err: Error, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StdVecStack` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `contents` is never read [INFO] [stdout] --> src/compiler.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 247 | Comment { [INFO] [stdout] | ------- field in this variant [INFO] [stdout] 248 | contents: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Chunk` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `err` is never read [INFO] [stdout] --> src/nostd_rt.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct HVecStack { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 16 | data: Vec, [INFO] [stdout] 17 | err: Error, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HVecStack` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:291:12 [INFO] [stdout] | [INFO] [stdout] 210 | let ret = 'oloop: loop { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | let to_push = match cur { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | let ret = Some(WhichToken::Ref(seq.clone())); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | Some(WhichToken::Single(ft)) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | Some(WhichToken::Ref(rf)) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | Ok(StepResult::Working(ret)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nostd_rt.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 32 | fn push(&mut self, data: T) -> Result<(), Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | self.data.push(data).map_err(|_| Error::StackOverflow).map(drop) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nostd_rt.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 84 | fn push(&mut self, data: RuntimeWord) { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | // TODO [INFO] [stdout] 86 | self.data.push(data).map_err(drop).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nostd_rt.rs:247:21 [INFO] [stdout] | [INFO] [stdout] 235 | let ds = HVecStack::new(Error::DataStackEmpty); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let rs = HVecStack::new(Error::RetStackEmpty); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | let fs = HVecStack::new(Error::FlowStackEmpty); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | cur_output: String::new(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `a4-core` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "99a80873c127f6cbafd7194dba7122ef5890a434b8d66031bf7838b168efc3c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "99a80873c127f6cbafd7194dba7122ef5890a434b8d66031bf7838b168efc3c5", kill_on_drop: false }` [INFO] [stdout] 99a80873c127f6cbafd7194dba7122ef5890a434b8d66031bf7838b168efc3c5