[INFO] fetching crate a-mutex 0.1.2... [INFO] checking a-mutex-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate a-mutex 0.1.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate a-mutex 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate a-mutex 0.1.2 [INFO] finished tweaking crates.io crate a-mutex 0.1.2 [INFO] tweaked toml for crates.io crate a-mutex 0.1.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 127 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bb8-redis v0.11.0 (latest: v0.16.0) [INFO] [stderr] Adding darling v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding redis v0.21.7 (latest: v0.26.1) [INFO] [stderr] Adding serde_with v1.14.0 (latest: v3.9.0) [INFO] [stderr] Adding serde_with_macros v1.5.2 (latest: v3.9.0) [INFO] [stderr] Adding sha1 v0.6.1 (latest: v0.10.6) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding testcontainers v0.14.0 (latest: v0.22.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1c7d7d62d88ef5a00cd74de67a3b8a34f58644b94908c048ec585c0f685015f5 [INFO] running `Command { std: "docker" "start" "-a" "1c7d7d62d88ef5a00cd74de67a3b8a34f58644b94908c048ec585c0f685015f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1c7d7d62d88ef5a00cd74de67a3b8a34f58644b94908c048ec585c0f685015f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c7d7d62d88ef5a00cd74de67a3b8a34f58644b94908c048ec585c0f685015f5", kill_on_drop: false }` [INFO] [stdout] 1c7d7d62d88ef5a00cd74de67a3b8a34f58644b94908c048ec585c0f685015f5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cb93a32c8afa36699c95a867b0c65085d2240df2622b23be0020ef4bd1e964a6 [INFO] running `Command { std: "docker" "start" "-a" "cb93a32c8afa36699c95a867b0c65085d2240df2622b23be0020ef4bd1e964a6", kill_on_drop: false }` [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking sha1 v0.6.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling auto_impl v1.2.0 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling serde_with_macros v1.5.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking bb8 v0.8.5 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking serde_with v1.14.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking bollard-stubs v1.41.0 [INFO] [stderr] Checking redis v0.21.7 [INFO] [stderr] Checking bb8-redis v0.11.0 [INFO] [stderr] Checking a-mutex v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/redis.rs:271:1 [INFO] [stdout] | [INFO] [stdout] 271 | #[async_trait] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/redis.rs:279:13 [INFO] [stdout] | [INFO] [stdout] 279 | con.set(format_data_key(&self.mutex.key), &data).await?; [INFO] [stdout] | ^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/redis.rs:271:1 [INFO] [stdout] | [INFO] [stdout] 271 | #[async_trait] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/redis.rs:297:13 [INFO] [stdout] | [INFO] [stdout] 297 | con.del(format_data_key(&self.mutex.key)).await?; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local.rs:67:54 [INFO] [stdout] | [INFO] [stdout] 67 | async fn store(&mut self, data: T) -> Result<()> { [INFO] [stdout] | _______________________________-------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | | *self.guard = Some(data); [INFO] [stdout] 69 | | Ok(()) [INFO] [stdout] 70 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local.rs:89:56 [INFO] [stdout] | [INFO] [stdout] 89 | async fn get(&self, key: K) -> Result { [INFO] [stdout] | _________________________------_________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | | let mutex = { [INFO] [stdout] 91 | | let map_readguard = self.map.read().await; [INFO] [stdout] 92 | | if let Some(lock) = map_readguard.get(&key) { [INFO] [stdout] ... | [INFO] [stdout] 102 | | Ok(LocalMutex { mutex }) [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis.rs:242:22 [INFO] [stdout] | [INFO] [stdout] 185 | let (drop_tx, mut drop_rx) = tokio::sync::oneshot::channel(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | let mutex_clone = mutex.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | drop_tx: Some(drop_tx), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis.rs:243:19 [INFO] [stdout] | [INFO] [stdout] 185 | let (drop_tx, mut drop_rx) = tokio::sync::oneshot::channel(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | let mutex_clone = mutex.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | data: RwLock::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis.rs:227:19 [INFO] [stdout] | [INFO] [stdout] 185 | let (drop_tx, mut drop_rx) = tokio::sync::oneshot::channel(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | let mutex_clone = mutex.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let _ = tokio::spawn(async move { [INFO] [stdout] 188 | let mutex = mutex_clone; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let mut renewal_interval = tokio::time::interval(core::time::Duration::from_millis( [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let panic_timeout = tokio::time::sleep( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | tokio::pin!(panic_timeout); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | match mutex.drop_lock().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis.rs:277:54 [INFO] [stdout] | [INFO] [stdout] 277 | async fn store(&mut self, data: T) -> Result<()> { [INFO] [stdout] | _______________________________-------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | | let mut con = self.mutex.pool.get().await?; [INFO] [stdout] 279 | | con.set(format_data_key(&self.mutex.key), &data).await?; [INFO] [stdout] 280 | | let mut guard = self.data.write().await; [INFO] [stdout] ... | [INFO] [stdout] 283 | | Ok(()) [INFO] [stdout] 284 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis.rs:315:5 [INFO] [stdout] | [INFO] [stdout] 312 | async fn get(&self, key: K) -> Result [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 315 | / { [INFO] [stdout] 316 | | let key = format!("amutex_{}_{}", self.provider_id, key.as_ref()); [INFO] [stdout] 317 | | let mutex_id = thread_rng().gen::(); [INFO] [stdout] 318 | | Ok(RedisMutex { [INFO] [stdout] ... | [INFO] [stdout] 322 | | }) [INFO] [stdout] 323 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `a-mutex` (lib) due to 8 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "cb93a32c8afa36699c95a867b0c65085d2240df2622b23be0020ef4bd1e964a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb93a32c8afa36699c95a867b0c65085d2240df2622b23be0020ef4bd1e964a6", kill_on_drop: false }` [INFO] [stdout] cb93a32c8afa36699c95a867b0c65085d2240df2622b23be0020ef4bd1e964a6