[INFO] fetching crate RustMqtt 0.1.1... [INFO] checking RustMqtt-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate RustMqtt 0.1.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate RustMqtt 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate RustMqtt 0.1.1 [INFO] finished tweaking crates.io crate RustMqtt 0.1.1 [INFO] tweaked toml for crates.io crate RustMqtt 0.1.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7d60acb7a2993fba5073a2576d21d7738bd734c23162c6ee1643cefb70f1dd26 [INFO] running `Command { std: "docker" "start" "-a" "7d60acb7a2993fba5073a2576d21d7738bd734c23162c6ee1643cefb70f1dd26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7d60acb7a2993fba5073a2576d21d7738bd734c23162c6ee1643cefb70f1dd26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d60acb7a2993fba5073a2576d21d7738bd734c23162c6ee1643cefb70f1dd26", kill_on_drop: false }` [INFO] [stdout] 7d60acb7a2993fba5073a2576d21d7738bd734c23162c6ee1643cefb70f1dd26 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ef841b006352945d124c96557c5f8b1fecf0d3baa594cc7021eb83ce8d3ce207 [INFO] running `Command { std: "docker" "start" "-a" "ef841b006352945d124c96557c5f8b1fecf0d3baa594cc7021eb83ce8d3ce207", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking RustMqtt v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/error.rs:76:32 [INFO] [stdout] | [INFO] [stdout] 76 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 76 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:72:39 [INFO] [stdout] | [INFO] [stdout] 72 | Error::Io(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/error.rs:76:32 [INFO] [stdout] | [INFO] [stdout] 76 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 76 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:72:39 [INFO] [stdout] | [INFO] [stdout] 72 | Error::Io(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `RustMqtt` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `rust_mqtt` [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/msg.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn from_pub(publish: Box) -> Result> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Ok(Box::new(Message { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | topic: topic, [INFO] [stdout] 23 | | qos: publish.qos, [INFO] [stdout] 24 | | retain: publish.retain, [INFO] [stdout] 25 | | pid: publish.pid, [INFO] [stdout] 26 | | payload: publish.payload.clone(), [INFO] [stdout] 27 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 118 | Ok(Box::new(Connect { [INFO] [stdout] | ____________^ [INFO] [stdout] 119 | | protocol: protocol, [INFO] [stdout] 120 | | keep_alive: keep_alive, [INFO] [stdout] 121 | | client_id: client_id, [INFO] [stdout] ... | [INFO] [stdout] 125 | | password: password, [INFO] [stdout] 126 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 142 | let topic_name = self.read_mqtt_string(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Ok(Box::new(Publish { [INFO] [stdout] | ____________^ [INFO] [stdout] 153 | | dup: header.dup(), [INFO] [stdout] 154 | | qos: header.qos()?, [INFO] [stdout] 155 | | retain: header.retain(), [INFO] [stdout] ... | [INFO] [stdout] 158 | | payload: Arc::new(payload), [INFO] [stdout] 159 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 177 | Ok(Box::new(Subscribe { [INFO] [stdout] | ____________^ [INFO] [stdout] 178 | | pid: PacketIdentifier(pid), [INFO] [stdout] 179 | | topics: topics, [INFO] [stdout] 180 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 200 | Ok(Box::new(Suback { [INFO] [stdout] | ____________^ [INFO] [stdout] 201 | | pid: PacketIdentifier(pid), [INFO] [stdout] 202 | | return_codes: return_codes, [INFO] [stdout] 203 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 217 | Ok(Box::new(Unsubscribe { [INFO] [stdout] | ____________^ [INFO] [stdout] 218 | | pid: PacketIdentifier(pid), [INFO] [stdout] 219 | | topics: topics, [INFO] [stdout] 220 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `RustMqtt` (lib) due to 7 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/msg.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn from_pub(publish: Box) -> Result> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Ok(Box::new(Message { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | topic: topic, [INFO] [stdout] 23 | | qos: publish.qos, [INFO] [stdout] 24 | | retain: publish.retain, [INFO] [stdout] 25 | | pid: publish.pid, [INFO] [stdout] 26 | | payload: publish.payload.clone(), [INFO] [stdout] 27 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 118 | Ok(Box::new(Connect { [INFO] [stdout] | ____________^ [INFO] [stdout] 119 | | protocol: protocol, [INFO] [stdout] 120 | | keep_alive: keep_alive, [INFO] [stdout] 121 | | client_id: client_id, [INFO] [stdout] ... | [INFO] [stdout] 125 | | password: password, [INFO] [stdout] 126 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 142 | let topic_name = self.read_mqtt_string(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Ok(Box::new(Publish { [INFO] [stdout] | ____________^ [INFO] [stdout] 153 | | dup: header.dup(), [INFO] [stdout] 154 | | qos: header.qos()?, [INFO] [stdout] 155 | | retain: header.retain(), [INFO] [stdout] ... | [INFO] [stdout] 158 | | payload: Arc::new(payload), [INFO] [stdout] 159 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 177 | Ok(Box::new(Subscribe { [INFO] [stdout] | ____________^ [INFO] [stdout] 178 | | pid: PacketIdentifier(pid), [INFO] [stdout] 179 | | topics: topics, [INFO] [stdout] 180 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 200 | Ok(Box::new(Suback { [INFO] [stdout] | ____________^ [INFO] [stdout] 201 | | pid: PacketIdentifier(pid), [INFO] [stdout] 202 | | return_codes: return_codes, [INFO] [stdout] 203 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 217 | Ok(Box::new(Unsubscribe { [INFO] [stdout] | ____________^ [INFO] [stdout] 218 | | pid: PacketIdentifier(pid), [INFO] [stdout] 219 | | topics: topics, [INFO] [stdout] 220 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `RustMqtt` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ef841b006352945d124c96557c5f8b1fecf0d3baa594cc7021eb83ce8d3ce207", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef841b006352945d124c96557c5f8b1fecf0d3baa594cc7021eb83ce8d3ce207", kill_on_drop: false }` [INFO] [stdout] ef841b006352945d124c96557c5f8b1fecf0d3baa594cc7021eb83ce8d3ce207