[INFO] fetching crate DiskAnalyzer 1.0.1... [INFO] checking DiskAnalyzer-1.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate DiskAnalyzer 1.0.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate DiskAnalyzer 1.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate DiskAnalyzer 1.0.1 [INFO] finished tweaking crates.io crate DiskAnalyzer 1.0.1 [INFO] tweaked toml for crates.io crate DiskAnalyzer 1.0.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate DiskAnalyzer 1.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6142280a07e836aaef034266c1d0942c142e9224330defeb188b116350279342 [INFO] running `Command { std: "docker" "start" "-a" "6142280a07e836aaef034266c1d0942c142e9224330defeb188b116350279342", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6142280a07e836aaef034266c1d0942c142e9224330defeb188b116350279342", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6142280a07e836aaef034266c1d0942c142e9224330defeb188b116350279342", kill_on_drop: false }` [INFO] [stdout] 6142280a07e836aaef034266c1d0942c142e9224330defeb188b116350279342 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6db7ebc3ee0f5e15519650cbeda5273d47997731f58d3562fce16a263b132aeb [INFO] running `Command { std: "docker" "start" "-a" "6db7ebc3ee0f5e15519650cbeda5273d47997731f58d3562fce16a263b132aeb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking rs-abbreviation-number v0.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Compiling cli-table-derive v0.4.5 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking cli-table v0.4.7 [INFO] [stderr] Checking DiskAnalyzer v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/crawler/node.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/crawler/node.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/diagram/tree.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/diagram/tree.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/diagram/shared.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:139:15 [INFO] [stdout] | [INFO] [stdout] 136 | fn new(args: ArgMatches) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 143 | fn from_clap_args(args: ArgMatches) -> CommandArgs { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | / CommandArgs::new(args) [INFO] [stdout] 145 | | .parse_depth() [INFO] [stdout] 146 | | .parse_diagram() [INFO] [stdout] 147 | | .parse_drive() [INFO] [stdout] 148 | | .parse_path() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:199:5 [INFO] [stdout] | [INFO] [stdout] 198 | fn handle_windows_path_arg(args: Command) -> Command { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | / args.arg( [INFO] [stdout] 200 | | Arg::new(DRIVES_ID) [INFO] [stdout] 201 | | .short('d') [INFO] [stdout] 202 | | .long("drive") [INFO] [stdout] 203 | | .help("which drive to scan.\nsplit with space.\n scan all drives if not set") [INFO] [stdout] 204 | | .conflicts_with(PATH_ID), [INFO] [stdout] 205 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 198 | fn handle_windows_path_arg(args: Command) -> Command { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | / Arg::new(PATH_ID) [INFO] [stdout] 208 | | .short('p') [INFO] [stdout] 209 | | .alias("pt") [INFO] [stdout] 210 | | .alias("pth") [INFO] [stdout] 211 | | .long("path") [INFO] [stdout] 212 | | .conflicts_with(DRIVES_ID) [INFO] [stdout] 213 | | .help("analyze give path (default is current directory)"), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 217 | fn handle_linux_path_arg(args: Command) -> Command { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | args.arg( [INFO] [stdout] 219 | / Arg::new(PATH_ID) [INFO] [stdout] 220 | | .short('p') [INFO] [stdout] 221 | | .alias("pt") [INFO] [stdout] 222 | | .alias("pth") [INFO] [stdout] 223 | | .long("path") [INFO] [stdout] 224 | | .help("analyze give path"), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `DiskAnalyzer` (bin "diska") due to 6 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:139:15 [INFO] [stdout] | [INFO] [stdout] 136 | fn new(args: ArgMatches) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 143 | fn from_clap_args(args: ArgMatches) -> CommandArgs { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | / CommandArgs::new(args) [INFO] [stdout] 145 | | .parse_depth() [INFO] [stdout] 146 | | .parse_diagram() [INFO] [stdout] 147 | | .parse_drive() [INFO] [stdout] 148 | | .parse_path() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:199:5 [INFO] [stdout] | [INFO] [stdout] 198 | fn handle_windows_path_arg(args: Command) -> Command { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | / args.arg( [INFO] [stdout] 200 | | Arg::new(DRIVES_ID) [INFO] [stdout] 201 | | .short('d') [INFO] [stdout] 202 | | .long("drive") [INFO] [stdout] 203 | | .help("which drive to scan.\nsplit with space.\n scan all drives if not set") [INFO] [stdout] 204 | | .conflicts_with(PATH_ID), [INFO] [stdout] 205 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 198 | fn handle_windows_path_arg(args: Command) -> Command { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | / Arg::new(PATH_ID) [INFO] [stdout] 208 | | .short('p') [INFO] [stdout] 209 | | .alias("pt") [INFO] [stdout] 210 | | .alias("pth") [INFO] [stdout] 211 | | .long("path") [INFO] [stdout] 212 | | .conflicts_with(DRIVES_ID) [INFO] [stdout] 213 | | .help("analyze give path (default is current directory)"), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 217 | fn handle_linux_path_arg(args: Command) -> Command { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | args.arg( [INFO] [stdout] 219 | / Arg::new(PATH_ID) [INFO] [stdout] 220 | | .short('p') [INFO] [stdout] 221 | | .alias("pt") [INFO] [stdout] 222 | | .alias("pth") [INFO] [stdout] 223 | | .long("path") [INFO] [stdout] 224 | | .help("analyze give path"), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `DiskAnalyzer` (bin "diska" test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "6db7ebc3ee0f5e15519650cbeda5273d47997731f58d3562fce16a263b132aeb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6db7ebc3ee0f5e15519650cbeda5273d47997731f58d3562fce16a263b132aeb", kill_on_drop: false }` [INFO] [stdout] 6db7ebc3ee0f5e15519650cbeda5273d47997731f58d3562fce16a263b132aeb