[INFO] fetching crate ArmlabRadio 0.6.5... [INFO] checking ArmlabRadio-0.6.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ArmlabRadio 0.6.5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ArmlabRadio 0.6.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ArmlabRadio 0.6.5 [INFO] finished tweaking crates.io crate ArmlabRadio 0.6.5 [INFO] tweaked toml for crates.io crate ArmlabRadio 0.6.5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate ArmlabRadio 0.6.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b3011442969f75c5fc5e72dcb6fa30a6703b2a348aa9ef022a1069d840d8488b [INFO] running `Command { std: "docker" "start" "-a" "b3011442969f75c5fc5e72dcb6fa30a6703b2a348aa9ef022a1069d840d8488b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b3011442969f75c5fc5e72dcb6fa30a6703b2a348aa9ef022a1069d840d8488b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3011442969f75c5fc5e72dcb6fa30a6703b2a348aa9ef022a1069d840d8488b", kill_on_drop: false }` [INFO] [stdout] b3011442969f75c5fc5e72dcb6fa30a6703b2a348aa9ef022a1069d840d8488b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8b92415f2993df4642143f54ca73157ff9f5952fead75b0ea2d084ab43b58800 [INFO] running `Command { std: "docker" "start" "-a" "8b92415f2993df4642143f54ca73157ff9f5952fead75b0ea2d084ab43b58800", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling serde_derive v1.0.142 [INFO] [stderr] Compiling serde v1.0.142 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling libc v0.2.127 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling camino v1.0.9 [INFO] [stderr] Compiling serde_json v1.0.83 [INFO] [stderr] Compiling semver v1.0.13 [INFO] [stderr] Compiling ryu v1.0.11 [INFO] [stderr] Compiling pulldown-cmark v0.9.2 [INFO] [stderr] Compiling itoa v1.0.3 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling fastrand v1.8.0 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling bytecount v0.6.3 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Compiling nix v0.10.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling walkdir v2.3.2 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Compiling tempfile v3.3.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking nix v0.24.2 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking serialport v4.2.0 [INFO] [stderr] Compiling cargo-platform v0.1.2 [INFO] [stderr] Compiling cargo_metadata v0.14.2 [INFO] [stderr] Compiling skeptic v0.13.7 [INFO] [stderr] Compiling i2cdev v0.3.2 [INFO] [stderr] Checking ArmlabRadio v0.6.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: crate `ArmlabRadio` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `armlab_radio` [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/radio_serial.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 49 | let mut port = match serialport::new(path, 115200) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(n) => n, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Ok(Radio {port, port_path: path.to_string()}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/radio_serial.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 49 | let mut port = match serialport::new(path, 115200) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(n) => n, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Ok(Radio {port, port_path: path.to_string()}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/radio_serial.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 83 | let mut port = match serialport::new(path, 115200) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(n) => n, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Radio {port, port_path: path.to_string()}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/radio_serial.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 83 | let mut port = match serialport::new(path, 115200) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(n) => n, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Radio {port, port_path: path.to_string()}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/radio_serial.rs:239:15 [INFO] [stdout] | [INFO] [stdout] 237 | let buf: Box<[u8]> = middle.into_boxed_slice(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | [INFO] [stdout] 239 | match self.port.write_all(&buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/radio_serial.rs:239:15 [INFO] [stdout] | [INFO] [stdout] 237 | let buf: Box<[u8]> = middle.into_boxed_slice(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | [INFO] [stdout] 239 | match self.port.write_all(&buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ArmlabRadio` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ArmlabRadio` (lib) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "8b92415f2993df4642143f54ca73157ff9f5952fead75b0ea2d084ab43b58800", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b92415f2993df4642143f54ca73157ff9f5952fead75b0ea2d084ab43b58800", kill_on_drop: false }` [INFO] [stdout] 8b92415f2993df4642143f54ca73157ff9f5952fead75b0ea2d084ab43b58800