[INFO] fetching crate ABC-ECS 0.2.1... [INFO] checking ABC-ECS-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ABC-ECS 0.2.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ABC-ECS 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ABC-ECS 0.2.1 [INFO] finished tweaking crates.io crate ABC-ECS 0.2.1 [INFO] tweaked toml for crates.io crate ABC-ECS 0.2.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 26 packages to latest compatible versions [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2fed3d4c17e675e36d37e5d4472ea800f5ffba687f7772190d7f3fa327c5ad0 [INFO] running `Command { std: "docker" "start" "-a" "a2fed3d4c17e675e36d37e5d4472ea800f5ffba687f7772190d7f3fa327c5ad0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2fed3d4c17e675e36d37e5d4472ea800f5ffba687f7772190d7f3fa327c5ad0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2fed3d4c17e675e36d37e5d4472ea800f5ffba687f7772190d7f3fa327c5ad0", kill_on_drop: false }` [INFO] [stdout] a2fed3d4c17e675e36d37e5d4472ea800f5ffba687f7772190d7f3fa327c5ad0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6cc8d714967fa7797a157c6cc956d7cb6069761b26c1988ca9aae39819d53b8a [INFO] running `Command { std: "docker" "start" "-a" "6cc8d714967fa7797a157c6cc956d7cb6069761b26c1988ca9aae39819d53b8a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking anymap v1.0.0-beta.2 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ABC-ECS v0.2.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/lib.rs:1103:14 [INFO] [stdout] | [INFO] [stdout] 1103 | fs::{self, File, OpenOptions}, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `engine` [INFO] [stdout] --> src/lib.rs:1039:27 [INFO] [stdout] | [INFO] [stdout] 1039 | fn prestep(&mut self, engine: &EntitiesAndComponentsThreadSafe) {} [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_engine` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `single_entity` [INFO] [stdout] --> src/lib.rs:1045:34 [INFO] [stdout] | [INFO] [stdout] 1045 | fn single_entity_step(&self, single_entity: &mut SingleMutEntity) {} [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_single_entity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `engine` [INFO] [stdout] --> src/lib.rs:1051:23 [INFO] [stdout] | [INFO] [stdout] 1051 | fn run(&mut self, engine: &mut EntitiesAndComponents) {} [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_engine` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `remove_all_children` is never used [INFO] [stdout] --> src/lib.rs:502:8 [INFO] [stdout] | [INFO] [stdout] 77 | impl EntitiesAndComponents { [INFO] [stdout] | -------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 502 | fn remove_all_children(&mut self, parent_entity: Entity) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `as_any_mut` is never used [INFO] [stdout] --> src/lib.rs:1073:8 [INFO] [stdout] | [INFO] [stdout] 1066 | trait SystemWrapper { [INFO] [stdout] | ------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 1073 | fn as_any_mut(&mut self) -> &mut dyn std::any::Any; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `ABC_ECS` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `abc_ecs` [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:907:44 [INFO] [stdout] | [INFO] [stdout] 905 | pub fn add_system(&mut self, system: T) -> SystemHandle { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 906 | SystemHandle { [INFO] [stdout] 907 | system_id: self.systems.insert(Box::new(system)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ABC-ECS` (lib) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `engine` [INFO] [stdout] --> src/lib.rs:1039:27 [INFO] [stdout] | [INFO] [stdout] 1039 | fn prestep(&mut self, engine: &EntitiesAndComponentsThreadSafe) {} [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_engine` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `single_entity` [INFO] [stdout] --> src/lib.rs:1045:34 [INFO] [stdout] | [INFO] [stdout] 1045 | fn single_entity_step(&self, single_entity: &mut SingleMutEntity) {} [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_single_entity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `engine` [INFO] [stdout] --> src/lib.rs:1051:23 [INFO] [stdout] | [INFO] [stdout] 1051 | fn run(&mut self, engine: &mut EntitiesAndComponents) {} [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_engine` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `position` [INFO] [stdout] --> src/lib.rs:1320:14 [INFO] [stdout] | [INFO] [stdout] 1320 | let (position, velocity) = [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_position` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `velocity` [INFO] [stdout] --> src/lib.rs:1320:24 [INFO] [stdout] | [INFO] [stdout] 1320 | let (position, velocity) = [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_velocity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/lib.rs:1646:13 [INFO] [stdout] | [INFO] [stdout] 1646 | for i in 0..10000000 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `entity` [INFO] [stdout] --> src/lib.rs:1647:17 [INFO] [stdout] | [INFO] [stdout] 1647 | let entity = entities_and_components.add_entity(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_entity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `position` [INFO] [stdout] --> src/lib.rs:1662:18 [INFO] [stdout] | [INFO] [stdout] 1662 | let (position,) = entities_and_components.get_components::<(Position,)>(*entity); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_position` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `velocity` [INFO] [stdout] --> src/lib.rs:1664:22 [INFO] [stdout] | [INFO] [stdout] 1664 | let (velocity,) = entities_and_components.get_components::<(Velocity,)>(*entity); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_velocity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `position` [INFO] [stdout] --> src/lib.rs:1672:22 [INFO] [stdout] | [INFO] [stdout] 1672 | let (position, velocity) = [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_position` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `velocity` [INFO] [stdout] --> src/lib.rs:1672:32 [INFO] [stdout] | [INFO] [stdout] 1672 | let (position, velocity) = [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_velocity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `position` [INFO] [stdout] --> src/lib.rs:1675:22 [INFO] [stdout] | [INFO] [stdout] 1675 | let (position,) = entities_and_components.get_components::<(Position,)>(*entity); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_position` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `position` [INFO] [stdout] --> src/lib.rs:1683:22 [INFO] [stdout] | [INFO] [stdout] 1683 | let (position, velocity) = [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_position` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `velocity` [INFO] [stdout] --> src/lib.rs:1683:32 [INFO] [stdout] | [INFO] [stdout] 1683 | let (position, velocity) = [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_velocity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `position` [INFO] [stdout] --> src/lib.rs:1686:22 [INFO] [stdout] | [INFO] [stdout] 1686 | let (position,) = [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_position` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `position` [INFO] [stdout] --> src/lib.rs:1695:22 [INFO] [stdout] | [INFO] [stdout] 1695 | let (position, velocity) = [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_position` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `velocity` [INFO] [stdout] --> src/lib.rs:1695:32 [INFO] [stdout] | [INFO] [stdout] 1695 | let (position, velocity) = [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_velocity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `position` [INFO] [stdout] --> src/lib.rs:1698:22 [INFO] [stdout] | [INFO] [stdout] 1698 | let (position,) = [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_position` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `position` [INFO] [stdout] --> src/lib.rs:1707:22 [INFO] [stdout] | [INFO] [stdout] 1707 | let (position, velocity) = [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_position` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `velocity` [INFO] [stdout] --> src/lib.rs:1707:32 [INFO] [stdout] | [INFO] [stdout] 1707 | let (position, velocity) = [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_velocity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `position` [INFO] [stdout] --> src/lib.rs:1710:22 [INFO] [stdout] | [INFO] [stdout] 1710 | let (position,) = [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_position` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `remove_all_children` is never used [INFO] [stdout] --> src/lib.rs:502:8 [INFO] [stdout] | [INFO] [stdout] 77 | impl EntitiesAndComponents { [INFO] [stdout] | -------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 502 | fn remove_all_children(&mut self, parent_entity: Entity) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `as_any_mut` is never used [INFO] [stdout] --> src/lib.rs:1073:8 [INFO] [stdout] | [INFO] [stdout] 1066 | trait SystemWrapper { [INFO] [stdout] | ------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 1073 | fn as_any_mut(&mut self) -> &mut dyn std::any::Any; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `NonSendSyncSystem` is never constructed [INFO] [stdout] --> src/lib.rs:1487:16 [INFO] [stdout] | [INFO] [stdout] 1487 | struct NonSendSyncSystem {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_children` is never used [INFO] [stdout] --> src/lib.rs:1609:8 [INFO] [stdout] | [INFO] [stdout] 1609 | fn test_children() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:907:44 [INFO] [stdout] | [INFO] [stdout] 905 | pub fn add_system(&mut self, system: T) -> SystemHandle { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 906 | SystemHandle { [INFO] [stdout] 907 | system_id: self.systems.insert(Box::new(system)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 26 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ABC-ECS` (lib test) due to 2 previous errors; 26 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6cc8d714967fa7797a157c6cc956d7cb6069761b26c1988ca9aae39819d53b8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6cc8d714967fa7797a157c6cc956d7cb6069761b26c1988ca9aae39819d53b8a", kill_on_drop: false }` [INFO] [stdout] 6cc8d714967fa7797a157c6cc956d7cb6069761b26c1988ca9aae39819d53b8a