[INFO] cloning repository https://github.com/docat-cli/docat [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/docat-cli/docat" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdocat-cli%2Fdocat", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdocat-cli%2Fdocat'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] aff160d012c80c21f1237edc6e4196d29f0f2e22 [INFO] checking docat-cli/docat/aff160d012c80c21f1237edc6e4196d29f0f2e22 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdocat-cli%2Fdocat" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/docat-cli/docat on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/rust-toolchain [INFO] started tweaking git repo https://github.com/docat-cli/docat [INFO] finished tweaking git repo https://github.com/docat-cli/docat [INFO] tweaked toml for git repo https://github.com/docat-cli/docat written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/docat-cli/docat already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5ccad61b99dd7ba2b37ff0d023d7d4e69950125a6bca3b3a55482f5a97a009f0 [INFO] running `Command { std: "docker" "start" "-a" "5ccad61b99dd7ba2b37ff0d023d7d4e69950125a6bca3b3a55482f5a97a009f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5ccad61b99dd7ba2b37ff0d023d7d4e69950125a6bca3b3a55482f5a97a009f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ccad61b99dd7ba2b37ff0d023d7d4e69950125a6bca3b3a55482f5a97a009f0", kill_on_drop: false }` [INFO] [stdout] 5ccad61b99dd7ba2b37ff0d023d7d4e69950125a6bca3b3a55482f5a97a009f0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ed670d36cd96e4fb9ab04145d5f8019c214d76e3c62acdf40738e33ecf2a0eb3 [INFO] running `Command { std: "docker" "start" "-a" "ed670d36cd96e4fb9ab04145d5f8019c214d76e3c62acdf40738e33ecf2a0eb3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking once_cell v1.13.1 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking gimli v0.26.2 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling serde_json v1.0.85 [INFO] [stderr] Compiling anyhow v1.0.62 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking os_str_bytes v6.3.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking zeroize v1.5.7 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking unsafe-libyaml v0.2.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking object v0.29.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Compiling backtrace v0.3.66 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking console v0.15.1 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking dialoguer v0.10.2 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking shellwords v1.1.0 [INFO] [stderr] Compiling darling_core v0.14.1 [INFO] [stderr] Compiling clap_derive v3.2.17 [INFO] [stderr] Compiling darling_macro v0.14.1 [INFO] [stderr] Compiling darling v0.14.1 [INFO] [stderr] Compiling serde_with_macros v2.0.0 [INFO] [stderr] Checking clap v3.2.17 [INFO] [stderr] Checking serde_with v2.0.0 [INFO] [stderr] Checking serde_yaml v0.9.10 [INFO] [stderr] Checking docat v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 40 | .flat_map(|cmd_result| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | / cmd_result [INFO] [stdout] 42 | | .map(|mut cmd| { [INFO] [stdout] 43 | | cmd.current_dir(dir); [INFO] [stdout] 44 | | cmd [INFO] [stdout] 45 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&std::string::String` instead of cloning the inner type [INFO] [stdout] --> src/docat.rs:190:64 [INFO] [stdout] | [INFO] [stdout] 190 | .filter(|(dir_name, _)| down_projects.contains(dir_name.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/docat.rs:281:30 [INFO] [stdout] | [INFO] [stdout] 281 | .and_then(|json| serde_json::from_str(&json).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/docker.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 23 | let mut cmd_wrapper = cmd::new("docker", &file::cwd()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | cmd::run(cmd_wrapper).expect("Could not create docker network") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/docker.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 36 | let mut cmd_wrapper = cmd::new("docker", &file::cwd()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | cmd::run(cmd_wrapper).expect("Could not create docker volume") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/docker.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 49 | let mut cmd_wrapper = cmd::new("docker", dir); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | cmd::run(cmd_wrapper).expect("Could not start project") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 10 | let mut cmd_wrapper = cmd::new("git", directory); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | cmd::run(cmd_wrapper).expect("Failed to clone repository.") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 18 | let mut cmd_wrapper = cmd::new("git", directory); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | cmd::run(cmd_wrapper).expect("Could get get git config") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `docat` (bin "docat") due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 40 | .flat_map(|cmd_result| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | / cmd_result [INFO] [stdout] 42 | | .map(|mut cmd| { [INFO] [stdout] 43 | | cmd.current_dir(dir); [INFO] [stdout] 44 | | cmd [INFO] [stdout] 45 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&std::string::String` instead of cloning the inner type [INFO] [stdout] --> src/docat.rs:190:64 [INFO] [stdout] | [INFO] [stdout] 190 | .filter(|(dir_name, _)| down_projects.contains(dir_name.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/docat.rs:281:30 [INFO] [stdout] | [INFO] [stdout] 281 | .and_then(|json| serde_json::from_str(&json).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/docker.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 23 | let mut cmd_wrapper = cmd::new("docker", &file::cwd()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | cmd::run(cmd_wrapper).expect("Could not create docker network") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/docker.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 36 | let mut cmd_wrapper = cmd::new("docker", &file::cwd()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | cmd::run(cmd_wrapper).expect("Could not create docker volume") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/docker.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 49 | let mut cmd_wrapper = cmd::new("docker", dir); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | cmd::run(cmd_wrapper).expect("Could not start project") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 10 | let mut cmd_wrapper = cmd::new("git", directory); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | cmd::run(cmd_wrapper).expect("Failed to clone repository.") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 18 | let mut cmd_wrapper = cmd::new("git", directory); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | cmd::run(cmd_wrapper).expect("Could get get git config") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `docat` (bin "docat" test) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "ed670d36cd96e4fb9ab04145d5f8019c214d76e3c62acdf40738e33ecf2a0eb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed670d36cd96e4fb9ab04145d5f8019c214d76e3c62acdf40738e33ecf2a0eb3", kill_on_drop: false }` [INFO] [stdout] ed670d36cd96e4fb9ab04145d5f8019c214d76e3c62acdf40738e33ecf2a0eb3