[INFO] cloning repository https://github.com/dmexe/failsafe-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dmexe/failsafe-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdmexe%2Ffailsafe-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdmexe%2Ffailsafe-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5bf89775ea320f288f11935f3b5526e63a865d2a [INFO] checking dmexe/failsafe-rs/5bf89775ea320f288f11935f3b5526e63a865d2a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdmexe%2Ffailsafe-rs" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dmexe/failsafe-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dmexe/failsafe-rs [INFO] finished tweaking git repo https://github.com/dmexe/failsafe-rs [INFO] tweaked toml for git repo https://github.com/dmexe/failsafe-rs written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dmexe/failsafe-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef2214194ac616f96f66638193d495ec946db82f7261a67f0d7fbffa9e4b0f91 [INFO] running `Command { std: "docker" "start" "-a" "ef2214194ac616f96f66638193d495ec946db82f7261a67f0d7fbffa9e4b0f91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef2214194ac616f96f66638193d495ec946db82f7261a67f0d7fbffa9e4b0f91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef2214194ac616f96f66638193d495ec946db82f7261a67f0d7fbffa9e4b0f91", kill_on_drop: false }` [INFO] [stdout] ef2214194ac616f96f66638193d495ec946db82f7261a67f0d7fbffa9e4b0f91 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 98f26af09d6c1a929f101de4759ff6dc79bb42bd27ba374b45a1f9a5622d4a66 [INFO] running `Command { std: "docker" "start" "-a" "98f26af09d6c1a929f101de4759ff6dc79bb42bd27ba374b45a1f9a5622d4a66", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking failsafe v1.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit_breaker.rs:55:15 [INFO] [stdout] | [INFO] [stdout] 46 | fn call_with(&self, predicate: P, f: F) -> Result> [INFO] [stdout] | ------------ ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | match f() { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_machine.rs:118:20 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn new(failure_policy: POLICY, instrument: INSTRUMENT) -> Self { [INFO] [stdout] | ---------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | inner: Arc::new(Inner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 119 | | shared: Mutex::new(Shared { [INFO] [stdout] 120 | | state: State::Closed, [INFO] [stdout] 121 | | failure_policy, [INFO] [stdout] 122 | | }), [INFO] [stdout] 123 | | instrument, [INFO] [stdout] 124 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/failure_policy.rs:89:18 [INFO] [stdout] | [INFO] [stdout] 69 | backoff: BACKOFF, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | backoff: backoff.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/failure_policy.rs:112:18 [INFO] [stdout] | [INFO] [stdout] 104 | backoff: BACKOFF, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | backoff: backoff.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/futures/mod.rs:113:28 [INFO] [stdout] | [INFO] [stdout] 104 | predicate: P, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | state_machine: self.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clock.rs:29:16 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn freeze(f: F) -> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | CLOCK.with(|cell| { [INFO] [stdout] | ________________^ [INFO] [stdout] 30 | | let mut clock = MockClock::new(); [INFO] [stdout] 31 | | [INFO] [stdout] 32 | | assert!( [INFO] [stdout] ... | [INFO] [stdout] 51 | | f(&mut clock) [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `failsafe` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "98f26af09d6c1a929f101de4759ff6dc79bb42bd27ba374b45a1f9a5622d4a66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98f26af09d6c1a929f101de4759ff6dc79bb42bd27ba374b45a1f9a5622d4a66", kill_on_drop: false }` [INFO] [stdout] 98f26af09d6c1a929f101de4759ff6dc79bb42bd27ba374b45a1f9a5622d4a66