[INFO] cloning repository https://github.com/dmaahs2017/sound-bored [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dmaahs2017/sound-bored" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdmaahs2017%2Fsound-bored", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdmaahs2017%2Fsound-bored'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 24a429a14dab85542f0969c69cca2f5a572619b7 [INFO] checking dmaahs2017/sound-bored/24a429a14dab85542f0969c69cca2f5a572619b7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdmaahs2017%2Fsound-bored" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dmaahs2017/sound-bored on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dmaahs2017/sound-bored [INFO] finished tweaking git repo https://github.com/dmaahs2017/sound-bored [INFO] tweaked toml for git repo https://github.com/dmaahs2017/sound-bored written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dmaahs2017/sound-bored already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9a0da01554fa8a385088eaee9d84ec4ffa0f9a5d76231fac3a1edc33eaf8ead4 [INFO] running `Command { std: "docker" "start" "-a" "9a0da01554fa8a385088eaee9d84ec4ffa0f9a5d76231fac3a1edc33eaf8ead4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9a0da01554fa8a385088eaee9d84ec4ffa0f9a5d76231fac3a1edc33eaf8ead4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a0da01554fa8a385088eaee9d84ec4ffa0f9a5d76231fac3a1edc33eaf8ead4", kill_on_drop: false }` [INFO] [stdout] 9a0da01554fa8a385088eaee9d84ec4ffa0f9a5d76231fac3a1edc33eaf8ead4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 343aa208bfea9c6e5e126a9a33c244760ee3f29cc279bfe51065b18887053054 [INFO] running `Command { std: "docker" "start" "-a" "343aa208bfea9c6e5e126a9a33c244760ee3f29cc279bfe51065b18887053054", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.85 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling cc v1.0.66 [INFO] [stderr] Checking dasp_ring_buffer v0.11.0 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking dasp_frame v0.11.0 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Compiling indexmap v1.6.1 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking tinyvec v1.1.1 [INFO] [stderr] Checking ogg v0.8.0 [INFO] [stderr] Checking dasp_window v0.11.0 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking slice-deque v0.3.0 [INFO] [stderr] Checking dasp_peak v0.11.0 [INFO] [stderr] Checking dasp_rms v0.11.0 [INFO] [stderr] Checking dasp_interpolate v0.11.0 [INFO] [stderr] Compiling minimp3-sys v0.3.2 [INFO] [stderr] Checking dasp_envelope v0.11.0 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking textwrap v0.13.2 [INFO] [stderr] Checking dasp_signal v0.11.0 [INFO] [stderr] Checking rand_core v0.6.1 [INFO] [stderr] Checking dasp_slice v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking os_str_bytes v2.4.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking dasp v0.11.0 [INFO] [stderr] Compiling serde_json v1.0.62 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.23 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.2 (https://github.com/clap-rs/clap/#3b59f5d3) [INFO] [stderr] Checking thiserror v1.0.23 [INFO] [stderr] Checking minimp3 v0.5.1 [INFO] [stderr] Checking creak v0.3.0 [INFO] [stderr] Checking clap v3.0.0-beta.2 (https://github.com/clap-rs/clap/#3b59f5d3) [INFO] [stderr] Checking sound-bored v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 15 | let mut samples = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(samples.into_iter().flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 11 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | let decoder = creak::Decoder::open(path)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let samples = convert_to_mono_channel(samples.into_iter(), info.channels() as u32)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | [INFO] [stdout] 24 | let mut signal = signal::from_iter(samples); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let interp = Linear::new(signal.next(), signal.next()); [INFO] [stdout] 26 | let signal = signal.from_hz_to_hz(interp, info.sample_rate() as f64, target_sample_rate as f64); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | Ok(signal.until_exhausted()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 32 | signal: impl Iterator, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let mut new_signal = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let mut v = T::default(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(new_signal.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sound-bored` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 15 | let mut samples = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(samples.into_iter().flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 11 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | let decoder = creak::Decoder::open(path)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let samples = convert_to_mono_channel(samples.into_iter(), info.channels() as u32)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | [INFO] [stdout] 24 | let mut signal = signal::from_iter(samples); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let interp = Linear::new(signal.next(), signal.next()); [INFO] [stdout] 26 | let signal = signal.from_hz_to_hz(interp, info.sample_rate() as f64, target_sample_rate as f64); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | Ok(signal.until_exhausted()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 32 | signal: impl Iterator, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let mut new_signal = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let mut v = T::default(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(new_signal.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:146:15 [INFO] [stdout] | [INFO] [stdout] 142 | let dir = tempfile::tempdir().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | [INFO] [stdout] 144 | let res = get_audio_file_paths(dir.path(), &["test"]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | [INFO] [stdout] 146 | match res.expect_err("Expected an error") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:15 [INFO] [stdout] | [INFO] [stdout] 157 | let dir = tempfile::tempdir().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | let res = get_audio_file_paths(&path, &["test"]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | [INFO] [stdout] 163 | match res.expect_err("Expected an error") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sound-bored` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "343aa208bfea9c6e5e126a9a33c244760ee3f29cc279bfe51065b18887053054", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "343aa208bfea9c6e5e126a9a33c244760ee3f29cc279bfe51065b18887053054", kill_on_drop: false }` [INFO] [stdout] 343aa208bfea9c6e5e126a9a33c244760ee3f29cc279bfe51065b18887053054